From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Jambor Subject: Bug in block_write_full_page (fs/buffer.c)? Date: Mon, 6 Jun 2005 22:02:51 +0200 Message-ID: <8e70aacf05060613022b1466ff@mail.gmail.com> References: <8e70aacf05060519472206605e@mail.gmail.com> Reply-To: Martin Jambor Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from zproxy.gmail.com ([64.233.162.204]:36540 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S261664AbVFFUCw convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2005 16:02:52 -0400 Received: by zproxy.gmail.com with SMTP id 16so1848571nzp for ; Mon, 06 Jun 2005 13:02:52 -0700 (PDT) To: linux-fsdevel@vger.kernel.org In-Reply-To: <8e70aacf05060519472206605e@mail.gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, when block_write_full_page (fs/buffer.c) is called and the page is fully outside the i_size, the function does not call end_page_writeback() even though Documentation/filesystems/Locking explicitly says that any implementation of aops->writepage must do so in any case. "If no I/O is submitted, the filesystem must run end_page_writeback() against the page before returning from writepage." Is this a bug, is the documentation wrong or is it just me? TIA, Martin Jambor