From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ARM: dts: imx27-eukrea-mbimxsd27: Fix ADS7846 interrupt
Date: Thu, 12 Dec 2024 13:08:53 +0100 [thread overview]
Message-ID: <8e82a0f6-de16-48d1-a194-c7764c29cc0b@kernel.org> (raw)
In-Reply-To: <20241212114535.558496-1-festevam@gmail.com>
On 12/12/2024 12:45, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> According to ti,ads7843.yaml the ADS7846 interrupt should be described
That's not true. Above binding does not tell it at all. Nothing about
parent.
> via interrupt-parent and interrupts properties.
>
> Do it accordingly to fix the following dt-schema warning:
>
> ads7846@0: interrupts: [[9], [25], [8]] is too long
Not entirely. Your reasons are just not correct. There is different
error there - wrong interrupt specifier because you have some specific
interrupt controller (GPIO). Author probably wanted interrupts extended.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-12 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 11:45 [PATCH] ARM: dts: imx27-eukrea-mbimxsd27: Fix ADS7846 interrupt Fabio Estevam
2024-12-12 12:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e82a0f6-de16-48d1-a194-c7764c29cc0b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.