Re: [OE-core] [PATCH] mesa: Fix bindgen includes

["Böszörményi Zoltán" <zboszor@gmail.com>]

2025. 06. 10. 21:49 keltezéssel, Dmitry Baryshkov via lists.openembedded.org írta:
> On Tue, 10 Jun 2025 at 17:24, Zoltán Böszörményi <zboszor@gmail.com> wrote:
>> Add a patch to fix bindgen errors due to not finding headers
>> in the system, like:
>>
>> |...
>> | ../mesa-25.1.2/src/gallium/frontends/rusticl/rusticl_llvm_bindings.hpp:1:10: fatal error: 'clang/Basic/Version.h' file not found
>> | Unable to generate bindings: clang diagnosed error: ../mesa-25.1.2/src/gallium/frontends/rusticl/rusticl_llvm_bindings.hpp:1:10: fatal error: 'clang/Basic/Version.h' file not found
>> |...
>> | .../work/corei7-64-oe-linux/mesa/25.1.2/mesa-25.1.2/include/./GL/glx.h:30:10: fatal error: 'X11/Xlib.h' file not found
>> | Unable to generate bindings: clang diagnosed error: /data2/dtd-yocto-5.2/tmp-sicom/work/corei7-64-oe-linux/mesa/25.1.2/mesa-25.1.2/include/./GL/glx.h:30:10: fatal error: 'X11/Xlib.h' file not found
> Can we fix this on the meson side by passing additional include path
> through the cross file?

This seems to work in mesa.inc without patching Mesa:

CFLAGS:append:class-target = " -I${STAGING_INCDIR}"
CXXFLAGS:append:class-target = " -I${STAGING_INCDIR}"

but it also[1] prints this for some of the bindgen runs:

clang diag: 
/home/zozo/yocto-5.2/tmp-sicom/work/corei7-64-oe-linux/mesa/25.1.3/recipe-sysroot/usr/include/stdint.h:95:11: 
warning: '__INT64_C' macro redefined [-Wmacro-redefined]
clang diag: 
/home/zozo/yocto-5.2/tmp-sicom/work/corei7-64-oe-linux/mesa/25.1.3/recipe-sysroot/usr/include/stdint.h:96:11: 
warning: '__UINT64_C' macro redefined [-Wmacro-redefined]

[1] Using the previously posted patch also prints the same.

It seems to be caused by a meson bug because it doesn't
collect the -isystem or --sysroot flags for rust/bindgen.
See the discussion at the MR link in the patch.

CFLAGS and CXXFLAGS changes are both needed because
bindgen is run on both .h and .hpp files for rusticl.

>> Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
>> ---
>>   ...w-build-option-for-extra-bindgen-inc.patch | 57 +++++++++++++++++++
>>   meta/recipes-graphics/mesa/mesa.inc           |  3 +-
>>   2 files changed, 59 insertions(+), 1 deletion(-)
>>   create mode 100644 meta/recipes-graphics/mesa/files/0001-rusticl-Add-a-new-build-option-for-extra-bindgen-inc.patch
>>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#218438): https://lists.openembedded.org/g/openembedded-core/message/218438
> Mute This Topic: https://lists.openembedded.org/mt/113570520/3617728
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [zboszor@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>