From: Tim Chen <tim.c.chen@linux.intel.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback_work
Date: Thu, 08 Feb 2024 11:26:10 -0800 [thread overview]
Message-ID: <8e9bf21039eb3ea9ee72c93cadc33f18e849933f.camel@linux.intel.com> (raw)
In-Reply-To: <20240208172024.23625-4-shikemeng@huaweicloud.com>
On Fri, 2024-02-09 at 01:20 +0800, Kemeng Shi wrote:
> Remove unused parameter wb of finish_writeback_work.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
> ---
> fs/fs-writeback.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index edb0cff51673..2619f74ced70 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb)
> spin_unlock_irq(&wb->work_lock);
> }
>
> -static void finish_writeback_work(struct bdi_writeback *wb,
> - struct wb_writeback_work *work)
> +static void finish_writeback_work(struct wb_writeback_work *work)
> {
> struct wb_completion *done = work->done;
>
> @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb,
> list_add_tail(&work->list, &wb->work_list);
> mod_delayed_work(bdi_wq, &wb->dwork, 0);
> } else
> - finish_writeback_work(wb, work);
> + finish_writeback_work(work);
>
> spin_unlock_irq(&wb->work_lock);
> }
> @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb)
> while ((work = get_next_work_item(wb)) != NULL) {
> trace_writeback_exec(wb, work);
> wrote += wb_writeback(wb, work);
> - finish_writeback_work(wb, work);
> + finish_writeback_work(work);
> }
>
> /*
next prev parent reply other threads:[~2024-02-08 19:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:20 [PATCH 0/7] Fixes and cleanups to fs-writeback Kemeng Shi
2024-02-08 17:20 ` [PATCH 1/7] fs/writeback: avoid to writeback non-expired inode in kupdate writeback Kemeng Shi
2024-02-08 18:29 ` Tim Chen
2024-02-18 2:01 ` Kemeng Shi
2024-02-28 1:46 ` Kemeng Shi
2024-02-23 13:42 ` Jan Kara
2024-02-26 11:47 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 2/7] fs/writeback: bail out if there is no more inodes for IO and queued once Kemeng Shi
2024-02-08 19:21 ` Tim Chen
2024-02-18 2:11 ` Kemeng Shi
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback_work Kemeng Shi
2024-02-08 19:26 ` Tim Chen [this message]
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 4/7] fs/writeback: remove unneeded check in writeback_single_inode Kemeng Shi
2024-02-08 19:34 ` Tim Chen
2024-02-10 0:46 ` Dave Chinner
2024-02-18 2:37 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 5/7] fs/writeback: only calculate dirtied_before when b_io is empty Kemeng Shi
2024-02-23 13:58 ` Jan Kara
2024-02-26 11:50 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 6/7] fs/writeback: correct comment of __wakeup_flusher_threads_bdi Kemeng Shi
2024-02-23 13:59 ` Jan Kara
2024-02-08 17:20 ` [PATCH 7/7] fs/writeback: remove unnecessary return in writeback_inodes_sb Kemeng Shi
2024-02-23 13:59 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e9bf21039eb3ea9ee72c93cadc33f18e849933f.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.