From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.7 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795020680; b=Tods9eJ5C1e50/FKJZV6ynH0eEGH1cRmkvKwYOxdJVz5AUwqbQQNu7erDV+fWFQgwK1J gYVVe8vXp1krHEiwmoVE/nvquZEjp2JX0EPnG1ea2Fx0dm3rD22R2z9IIM5EflVL2fzFg sdljW+vRh6NEsZSknMLc4e1xqc6VEd4twmEN4sYwuZC8kvrT48J+R4AGOcXTXRgzgSpgQ ADH1JjUDUidGMOcsIq9wS1ls72a+d7vnhgK7XdHjg+vRNleNz662aHdTHD2Q+pGP7erp8 dPFA/ni4Uj6NAzsP/RZB5kUIns6RtNj5mRTQHy5W1G5RYzsWGRFlyRL1gdtJgrYJ2rA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795020680; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: In-Reply-To:Organization:References:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=/cUldU1e2XAI/ZxV0Ch4uDE5FUyxfirjC3SAjGA4JrA=; b=MdOsyd5LBjGK8ictZiH3Sl6o/W92FdT9eWuDEAT6TIxJW4D6oE57uLfjSyWWjKdccfDc vmz6qYzZJz+90OY29Y5YAmbGJJQqsJUHwuiclA7bKaf5ws+ZniT5cki9Z52y6eyyb83D8 pMPnjUgYqUJxz6BFJQHgE3eh8/38s+HCgYW6mKIJDY9FQcSY2bxr+EEeVqN8krKf9IJVx +v7Pw8wimSnww8Ob35XiApCmbPclTt4P30tBQ+EMXXX0REdc7qlhbnwu+nl+Zf5ZdXnU9 6AJ14xCfo+oLS8HiaLUoWX0xMxXo5ftY1H4Vh3FAMzxuDkoU5L3+ul4/A7EClMr5RUQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b="E7bR/4DJ"; arc=none smtp.remote-ip=192.198.163.7 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C42760A263C; Wed, 18 Nov 2026 16:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0C42760A263C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E7bR/4DJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795020680; x=1826556680; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ajDnh0zw+64dcFPrEUfvS5sWfWZYQWJZbcQwO+AcVNs=; b=E7bR/4DJh5YbzHocFFIpAPmtKk9ggCJnqN7MeuUBIy77erwdx4Qj0zW9 7AmNZZdHn+mbO/c8iNCVhx+Lf1UfjdgKq4PCJAfcKdEtPaOqOltBKxMJ4 yhIwzQ34h21kM/n6FLQc8d5UapQYlDuwkIWIp7NMq5rPlOEl66TH293FC P9QbpRnJNgc+z2koC+4bFreXbDesML2ZT9GreUYVunZu5FhlSX5AixWDL vUItwz6XzUEKLENsGQNIGbqkJ6vXRu2s1H/EZQ3oIWrCsXpQF49egqqqj adaqme7U88uBmf5gmN2NZ/S46kgz/B1arycKCWvwZkIxUFzAfuU27qXxt w==; X-CSE-ConnectionGUID: 2pM0sEieQwey1oInVeA3WQ== X-CSE-MsgGUID: poBVPHPaTf+8pvsf5oAIYQ== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3699698" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3699698" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:31 -0800 X-CSE-ConnectionGUID: k/DCmaX/Qp2q9S20vakyDw== X-CSE-MsgGUID: YVFQiz1BSVmcIhLrCJbvrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="9985477" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:21 -0800 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Date: Wed, 18 Nov 2026 18:50:19 +0200 Message-ID: <8ebe3b7219ffd963a498cccbcfe6cefc92717f0c@intel.com> X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 18 Nov 2026, Uwe Kleine-K=C3=B6nig w= rote: > Hello Jani, > > On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: >> > [...] >> > drivers/gpu/ipu-v3/ipu-common.c | 8 +- >> > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- >> > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- >> > 254 files changed, 1155 insertions(+), 940 deletions(-) >>=20 >> How do you expect a patch of this size be merged? > > Using b4 am :-) Honestly, in the cover letter I wrote about an immutable > branch and offered to rebase to 7.4-rc1. When trying to apply this > series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete > and 5x content); these are all not so hard to resolve (and even dropping > the respective hunks (i.e. resolving using `git checkout HEAD`) is fine > for me.) > >> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i9= 15_pci.c >> > index 84a7dc6ab5db..faceb3de4fa3 100644 >> > --- a/drivers/gpu/drm/i915/i915_pci.c >> > +++ b/drivers/gpu/drm/i915/i915_pci.c >> > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { >> > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), >> > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), >> > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), >> > - {} >> > + { } >>=20 >> Personally, I would *always* use {} instead of { }, and would rather not >> change. >>=20 >> Across the tree, {} is slightly more common than { }. IMO changing them >> is pointless churn. > > It depends on how you count. My statistic looks as follows (on top of > next-20261117): > > $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/de= vice_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | u= niq -c > 2 } > 2 { > 6 { } > 2598 { } > 1262 {} > > So over all *_device_id { } is more common by a factor of > 2. This > series fixes one { } and reduces the number of {} by 37. For only > pci_device_id it's: > > $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if = m/pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | = sort | uniq -c > 159 { } > 32 {} > > Without the context of an array initializer there are many empty > code blocks (function bodys or `do {} while (0)`), empty dt nodes, and > {} in Rust code, which IMHO have to be considered off-topic for this > statistic. I realize my phrasing was careless. My point was not so much about one being more common than the other, but rather that there are *thousands* of instances of both, specifically as C compound literals with empty initializer list. I think it's pointless to convert one to other, regardless of whether you're adding or removing a space. I mentioned my preference, because if I were to go on a style fixing spree, I'd go the other direction. But I think that too would be pointless. I suggest to just accept either. BR, Jani. --=20 Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE82B60A5BC3 for ; Wed, 18 Nov 2026 16:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=MR+cqIhP Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9374010FE84; Wed, 18 Nov 2026 16:51:33 +0000 (UTC) Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 091F149546; Wed, 18 Nov 2026 16:31:39 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1795019498; b=pGO5gSYRvAXo2nasLyjpSkzLE7SzOCA7N6JmYlIyHmjLnFvXEi9+vUbrHMiKogpClRf7F dvOT8uRD1K7ljB7lAPjxdYSYDWld+4c4bUeq0V82EC0M8ZW70Nr/EKYeWJtGEKTkstvIUHz UfzQFIXPq0F3uSovQTIr16N+hXZIsg25/3ZFfUq34zv7VjC/yvjc/6C5u9mXx/x8nUAn/MC yo28fjlZpB/2Aaa0sXINRILF3PPuUTns8y0R0RHd8a36Faf92z8zBFO8ijB0NspBX08C5+7 GjBdCY3hqfnJz1OOBXUsReuD/kRyqgKg70eevtxmOSKISsC77OuFMtCi2GiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1795019498; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=/cUldU1e2XAI/ZxV0Ch4uDE5FUyxfirjC3SAjGA4JrA=; b=pMenB7TibD2DrzFoBjlW+5rRL3QU6koKJrPZvAVQGHiyQ94Xxp065LCPK2oDlBSXgu4Me 3cNmqexTQoRE4DQRXWvPhjlwoVJdqcNiVF4GRFIHzIli+bDXCLmTdAq/zubG+p2+dQHTlOz 3TILCxPb/yLMUWRmv0MyMQrijJBNqSG/OwaYS+7+DRqDfM+LTWX0LofHgCgzKFPJlNMdx64 a5JA8pjn7xQHXHNedOWGSMUd32f3G9Z/HAOKBSGPNTXZ7N90pbkNiOemKq40YuTXx5FQW59 6IVbydh2EZOz1on7pf32ZjfLIcT1t+jLYnr0OjEooDkbkydeXvXSZhKbEjng== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=intel.com header.i=@intel.com; arc=none (Message is not ARC signed); dmarc=pass (Used Org Domain Record) header.from=linux.intel.com policy.dmarc=none Authentication-Results: mail.freedesktop.org; dkim=pass header.d=intel.com header.i=@intel.com; arc=none (Message is not ARC signed); dmarc=pass (Used Org Domain Record) header.from=linux.intel.com policy.dmarc=none Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 32D004668B; Wed, 18 Nov 2026 16:31:35 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE96810FE75; Wed, 18 Nov 2026 16:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795020684; x=1826556684; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ajDnh0zw+64dcFPrEUfvS5sWfWZYQWJZbcQwO+AcVNs=; b=MR+cqIhPvcv9ENCgwgQp+w136q5E5ZrF8Gr2k1oHAStv3nmORyTsYhIx dmB4ZhZA3RiHYKpQT9jX+b9oATSksOCgpupoAqcVsB6qiO987bQJCdp2+ RvFFOvAEPIQYhayUD6l7g0YziH62AmA1xbRHANVmNBNhDrsm/sT62LZ+1 los1cgShguo+tNWVMW5YTqnOFCf+4MI3IP5FktQFdubs9TNg5rw1x2kLt aT7NzqI44nrUxjFq72/wodsiZN9iPoQtNnoJphJCdqCJTFjpYQLcPxwr0 +ppilDS7nihsZEZvDQnpPZxEFDxvsIXNunqPfO47sNuWDzZSwx77IZqCQ Q==; X-CSE-ConnectionGUID: ufF2x8MjSTe8MVsBRvojhg== X-CSE-MsgGUID: hTuyctwxQIOM9eJRzdtD/g== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3699708" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3699708" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:31 -0800 X-CSE-ConnectionGUID: k/DCmaX/Qp2q9S20vakyDw== X-CSE-MsgGUID: YVFQiz1BSVmcIhLrCJbvrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="9985477" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:21 -0800 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Date: Wed, 18 Nov 2026 18:50:19 +0200 Message-ID: <8ebe3b7219ffd963a498cccbcfe6cefc92717f0c@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FA6J4J2HXQLLZNP7YP44MOFSAKQABBMG X-Message-ID-Hash: FA6J4J2HXQLLZNP7YP44MOFSAKQABBMG X-MailFrom: jani.nikula@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, 18 Nov 2026, Uwe Kleine-K=C3=B6nig w= rote: > Hello Jani, > > On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: >> > [...] >> > drivers/gpu/ipu-v3/ipu-common.c | 8 +- >> > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- >> > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- >> > 254 files changed, 1155 insertions(+), 940 deletions(-) >>=20 >> How do you expect a patch of this size be merged? > > Using b4 am :-) Honestly, in the cover letter I wrote about an immutable > branch and offered to rebase to 7.4-rc1. When trying to apply this > series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete > and 5x content); these are all not so hard to resolve (and even dropping > the respective hunks (i.e. resolving using `git checkout HEAD`) is fine > for me.) > >> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i9= 15_pci.c >> > index 84a7dc6ab5db..faceb3de4fa3 100644 >> > --- a/drivers/gpu/drm/i915/i915_pci.c >> > +++ b/drivers/gpu/drm/i915/i915_pci.c >> > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { >> > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), >> > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), >> > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), >> > - {} >> > + { } >>=20 >> Personally, I would *always* use {} instead of { }, and would rather not >> change. >>=20 >> Across the tree, {} is slightly more common than { }. IMO changing them >> is pointless churn. > > It depends on how you count. My statistic looks as follows (on top of > next-20261117): > > $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/de= vice_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | u= niq -c > 2 } > 2 { > 6 { } > 2598 { } > 1262 {} > > So over all *_device_id { } is more common by a factor of > 2. This > series fixes one { } and reduces the number of {} by 37. For only > pci_device_id it's: > > $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if = m/pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | = sort | uniq -c > 159 { } > 32 {} > > Without the context of an array initializer there are many empty > code blocks (function bodys or `do {} while (0)`), empty dt nodes, and > {} in Rust code, which IMHO have to be considered off-topic for this > statistic. I realize my phrasing was careless. My point was not so much about one being more common than the other, but rather that there are *thousands* of instances of both, specifically as C compound literals with empty initializer list. I think it's pointless to convert one to other, regardless of whether you're adding or removing a space. I mentioned my preference, because if I were to go on a style fixing spree, I'd go the other direction. But I think that too would be pointless. I suggest to just accept either. BR, Jani. --=20 Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15F8B606A338 for ; Wed, 18 Nov 2026 16:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XSHgx72/; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mP4DwPyz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=3uuyTRs0sLw57WXvDo+7moc1aZIQodU96NmW2+QZxII=; b=XSHgx72/5fQG5lelUU/8687pfR ++cSbE1jy9tAcPzgKDXc1ilinBmMPlIocmY+nCKQ4Y8SnO3RMapzuAS6eZpnVHiy7WJEO8p/oQm7A 3XIfD3yP1QMwZbCx5Pp/fKaWAUj4wCgpfFPRgGoOdU9NksHdYjnDsp9MkhZBb26qc1w7ifj9z7IqD PIk7/T8Q0Ej5SIqPc35McOh7VuKe4s8KAp9ghqOxVezkdMwWZ5VjGUwYfqgYzkAnXiIbT/YgWdiM2 HYbcRD2geeh2jo/7GxjQKbQ3L7GY8wgWeGBK64U6zT+grbeJVueFnTCxAWqkkOhV6xF5pi6KS1iP2 KxVo3Vpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTisn-00000009anh-2rcM; Wed, 18 Nov 2026 16:51:41 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTisS-00000009aT7-3KDx; Wed, 18 Nov 2026 16:51:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795020681; x=1826556681; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ajDnh0zw+64dcFPrEUfvS5sWfWZYQWJZbcQwO+AcVNs=; b=mP4DwPyzA12OflFAs7cqsLyFUlGk851Vd/gqVwVcN25x8BrQL+i7AmOL 8mYJpmast9tqACSNx8lBA4jZ4/q1QzUvavsA4vMpmrO4kXPI5tmgD7UvX RIKZkYtrXgFcDgMSDp8+RxF/Qsk0Pdt1zP/11+VRi9zgvwFg2kn0/zAaJ juFRnpN5gAXJQ16xhWq2lvyYTb3qIRMVB9Yj0aB5dYr71LMGSI/TCUXfu Q/vbbt3vkm3f9HlNHt84ek7qFjbaO9159QwvU9BrlJgluRx7ACzWJzJJs wtZ+6YyX/GEjAKJa7Ohka54I7IWU1FNw+PjgE6WXf82fCJhvvI5wWCOY1 w==; X-CSE-ConnectionGUID: oZ2rE8KxRlG7KJlEHRUcVA== X-CSE-MsgGUID: 8DpQhJ4ORkulGvnvyMycQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3699699" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3699699" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:31 -0800 X-CSE-ConnectionGUID: k/DCmaX/Qp2q9S20vakyDw== X-CSE-MsgGUID: YVFQiz1BSVmcIhLrCJbvrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="9985477" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:21 -0800 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Date: Wed, 18 Nov 2026 18:50:19 +0200 Message-ID: <8ebe3b7219ffd963a498cccbcfe6cefc92717f0c@intel.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_085120_862726_7CECB254 X-CRM114-Status: GOOD ( 23.59 ) X-Spam-Score: -4.3 (----) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 T24gV2VkLCAxOCBOb3YgMjAyNiwgVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bi YXlsaWJyZS5jb20+IHdyb3RlOgo+IEhlbGxvIEphbmksCj4KPiBPbiBXZWQsIE5vdiAxOCwgMjAy NiBhdCAwMzoyNzo0MFBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gPiBbLi4uXQo+PiA+ ICBkcml2ZXJzL2dwdS9pcHUtdjMvaXB1LWNvbW1vbi5jICAgICAgICAgICAgICAgfCAgIDggKy0K Pj4gPiAgZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1wcmUuYyAgICAgICAgICAgICAgICAgIHwgICA0 ICstCj4+ID4gIGRyaXZlcnMvZ3B1L2lwdS12My9pcHUtcHJnLmMgICAgICAgICAgICAgICAgICB8 ICAgNCArLQo+PiA+ICAyNTQgZmlsZXMgY2hhbmdlZCwgMTE1NSBpbnNlcnRpb25zKCspLCA5NDAg ZGVsZXRpb25zKC0pCj4+IAo+PiBIb3cgZG8geW91IGV4cGVjdCBhIHBhdGNoIG9mIHRoaXMgc2l6 ZSBiZSBtZXJnZWQ/Cj4KPiBVc2luZyBiNCBhbSA6LSkgSG9uZXN0bHksIGluIHRoZSBjb3ZlciBs ZXR0ZXIgSSB3cm90ZSBhYm91dCBhbiBpbW11dGFibGUKPiBicmFuY2ggYW5kIG9mZmVyZWQgdG8g cmViYXNlIHRvIDcuNC1yYzEuIFdoZW4gdHJ5aW5nIHRvIGFwcGx5IHRoaXMKPiBzZXJpZXMgb24g dG9wIG92IDcuNC1yYzEgdGhlcmUgYXJlIG9ubHkgNiBjb25mbGljdHMgKDF4IG1vZGlmeS9kZWxl dGUKPiBhbmQgNXggY29udGVudCk7IHRoZXNlIGFyZSBhbGwgbm90IHNvIGhhcmQgdG8gcmVzb2x2 ZSAoYW5kIGV2ZW4gZHJvcHBpbmcKPiB0aGUgcmVzcGVjdGl2ZSBodW5rcyAoaS5lLiByZXNvbHZp bmcgdXNpbmcgYGdpdCBjaGVja291dCBIRUFEYCkgaXMgZmluZQo+IGZvciBtZS4pCj4KPj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcGNpLmMKPj4gPiBpbmRleCA4NGE3ZGM2YWI1ZGIuLmZhY2ViM2RlNGZh MyAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+PiA+IEBAIC04NzAsNyArODcw LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlX2lkIHBjaWlkbGlzdFtdID0gewo+ PiA+ICAJSU5URUxfQVRTX01fSURTKElOVEVMX1ZHQV9ERVZJQ0UsICZhdHNfbV9pbmZvKSwKPj4g PiAgCUlOVEVMX0FSTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAgCUlO VEVMX01UTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAtCXt9Cj4+ID4g Kwl7IH0KPj4gCj4+IFBlcnNvbmFsbHksIEkgd291bGQgKmFsd2F5cyogdXNlIHt9IGluc3RlYWQg b2YgeyB9LCBhbmQgd291bGQgcmF0aGVyIG5vdAo+PiBjaGFuZ2UuCj4+IAo+PiBBY3Jvc3MgdGhl IHRyZWUsIHt9IGlzIHNsaWdodGx5IG1vcmUgY29tbW9uIHRoYW4geyB9LiBJTU8gY2hhbmdpbmcg dGhlbQo+PiBpcyBwb2ludGxlc3MgY2h1cm4uCj4KPiBJdCBkZXBlbmRzIG9uIGhvdyB5b3UgY291 bnQuIE15IHN0YXRpc3RpYyBsb29rcyBhcyBmb2xsb3dzIChvbiB0b3Agb2YKPiBuZXh0LTIwMjYx MTE3KToKPgo+IAkkIGdpdCBncmVwIC1sIGRldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAt biAtZSAncHJpbnQgIiQxXG4iIGlmIG0vZGV2aWNlX2lkXHMqW2EtekEtWl8wLTldKlxbXF1ccyo9 XHMqeyg/OlxzKntbXn1dKn0sXHMqKHtccyp9KSkvJyB8IHNvcnQgfCB1bmlxIC1jCj4gCSAgICAg IDIgCX0KPiAJICAgICAgMiB7Cj4gCSAgICAgIDYgeyAgfQo+IAkgICAyNTk4IHsgfQo+IAkgICAx MjYyIHt9Cj4KPiBTbyBvdmVyIGFsbCAqX2RldmljZV9pZCB7IH0gaXMgbW9yZSBjb21tb24gYnkg YSBmYWN0b3Igb2YgPiAyLiBUaGlzCj4gc2VyaWVzIGZpeGVzIG9uZSB7ICB9IGFuZCByZWR1Y2Vz IHRoZSBudW1iZXIgb2Yge30gYnkgMzcuIEZvciBvbmx5Cj4gcGNpX2RldmljZV9pZCBpdCdzOgo+ Cj4gCSQgZ2l0IGdyZXAgLWwgcGNpX2RldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAtbiAt ZSAncHJpbnQgIiQxXG4iIGlmIG0vcGNpX2RldmljZV9pZFxzKlthLXpBLVpfMC05XSpcW1xdXHMq PVxzKnsoPzpccyp7W159XSp9LFxzKih7XHMqfSkpLycgfCBzb3J0IHwgdW5pcSAtYwo+IAkgICAg MTU5IHsgfQo+IAkgICAgIDMyIHt9Cj4KPiBXaXRob3V0IHRoZSBjb250ZXh0IG9mIGFuIGFycmF5 IGluaXRpYWxpemVyIHRoZXJlIGFyZSBtYW55IGVtcHR5Cj4gY29kZSBibG9ja3MgKGZ1bmN0aW9u IGJvZHlzIG9yIGBkbyB7fSB3aGlsZSAoMClgKSwgZW1wdHkgZHQgbm9kZXMsIGFuZAo+IHt9IGlu IFJ1c3QgY29kZSwgd2hpY2ggSU1ITyBoYXZlIHRvIGJlIGNvbnNpZGVyZWQgb2ZmLXRvcGljIGZv ciB0aGlzCj4gc3RhdGlzdGljLgoKSSByZWFsaXplIG15IHBocmFzaW5nIHdhcyBjYXJlbGVzcy4K Ck15IHBvaW50IHdhcyBub3Qgc28gbXVjaCBhYm91dCBvbmUgYmVpbmcgbW9yZSBjb21tb24gdGhh biB0aGUgb3RoZXIsIGJ1dApyYXRoZXIgdGhhdCB0aGVyZSBhcmUgKnRob3VzYW5kcyogb2YgaW5z dGFuY2VzIG9mIGJvdGgsIHNwZWNpZmljYWxseSBhcwpDIGNvbXBvdW5kIGxpdGVyYWxzIHdpdGgg ZW1wdHkgaW5pdGlhbGl6ZXIgbGlzdC4gSSB0aGluayBpdCdzIHBvaW50bGVzcwp0byBjb252ZXJ0 IG9uZSB0byBvdGhlciwgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIHlvdSdyZSBhZGRpbmcgb3IgcmVt b3ZpbmcKYSBzcGFjZS4KCkkgbWVudGlvbmVkIG15IHByZWZlcmVuY2UsIGJlY2F1c2UgaWYgSSB3 ZXJlIHRvIGdvIG9uIGEgc3R5bGUgZml4aW5nCnNwcmVlLCBJJ2QgZ28gdGhlIG90aGVyIGRpcmVj dGlvbi4gQnV0IEkgdGhpbmsgdGhhdCB0b28gd291bGQgYmUKcG9pbnRsZXNzLgoKSSBzdWdnZXN0 IHRvIGp1c3QgYWNjZXB0IGVpdGhlci4KCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F947606A336 for ; Wed, 18 Nov 2026 16:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VaMienvV; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mP4DwPyz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=VNxEUzwXjO8Sf2HfDvUSf/osFrCpqKon6xNBL52fyf4=; b=VaMienvVImEjndSSGIYqMgHHql IamUkEi7VzahsrbkFgBTKhFjuF4LeqXNXck7A+VwMpckRDJxSjSQW1esoAXea1zE3DHkeAd2CzSNu MRRkf9QLOR48l+iLvmFhe8oIJqxRK7aQguXQcXNxXipZW5ddhBKtcVC6qlvUIPtmHPMbVrBqE3nKr XafHVH/Mb90h3vGVPWaqj88Mu3hkpgwGCT3ZyFyic8Lr4DQjvuLQn+ogLqywYmON3AULE0XE4Ujo3 Bwpw0znbeblFDKfSCRz51CqEsMB9S6ohpkk4QStUtkziYZNyqnXO8dyXcaOs2HE4dnH7th/f+Ca0f 6IbH+f7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTiso-00000009ap6-16Di; Wed, 18 Nov 2026 16:51:42 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTisS-00000009aT7-3KDx; Wed, 18 Nov 2026 16:51:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795020681; x=1826556681; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ajDnh0zw+64dcFPrEUfvS5sWfWZYQWJZbcQwO+AcVNs=; b=mP4DwPyzA12OflFAs7cqsLyFUlGk851Vd/gqVwVcN25x8BrQL+i7AmOL 8mYJpmast9tqACSNx8lBA4jZ4/q1QzUvavsA4vMpmrO4kXPI5tmgD7UvX RIKZkYtrXgFcDgMSDp8+RxF/Qsk0Pdt1zP/11+VRi9zgvwFg2kn0/zAaJ juFRnpN5gAXJQ16xhWq2lvyYTb3qIRMVB9Yj0aB5dYr71LMGSI/TCUXfu Q/vbbt3vkm3f9HlNHt84ek7qFjbaO9159QwvU9BrlJgluRx7ACzWJzJJs wtZ+6YyX/GEjAKJa7Ohka54I7IWU1FNw+PjgE6WXf82fCJhvvI5wWCOY1 w==; X-CSE-ConnectionGUID: oZ2rE8KxRlG7KJlEHRUcVA== X-CSE-MsgGUID: 8DpQhJ4ORkulGvnvyMycQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3699699" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3699699" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:31 -0800 X-CSE-ConnectionGUID: k/DCmaX/Qp2q9S20vakyDw== X-CSE-MsgGUID: YVFQiz1BSVmcIhLrCJbvrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="9985477" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:21 -0800 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Date: Wed, 18 Nov 2026 18:50:19 +0200 Message-ID: <8ebe3b7219ffd963a498cccbcfe6cefc92717f0c@intel.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_085120_862726_7CECB254 X-CRM114-Status: GOOD ( 23.59 ) X-Spam-Score: -4.3 (----) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 T24gV2VkLCAxOCBOb3YgMjAyNiwgVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bi YXlsaWJyZS5jb20+IHdyb3RlOgo+IEhlbGxvIEphbmksCj4KPiBPbiBXZWQsIE5vdiAxOCwgMjAy NiBhdCAwMzoyNzo0MFBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gPiBbLi4uXQo+PiA+ ICBkcml2ZXJzL2dwdS9pcHUtdjMvaXB1LWNvbW1vbi5jICAgICAgICAgICAgICAgfCAgIDggKy0K Pj4gPiAgZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1wcmUuYyAgICAgICAgICAgICAgICAgIHwgICA0 ICstCj4+ID4gIGRyaXZlcnMvZ3B1L2lwdS12My9pcHUtcHJnLmMgICAgICAgICAgICAgICAgICB8 ICAgNCArLQo+PiA+ICAyNTQgZmlsZXMgY2hhbmdlZCwgMTE1NSBpbnNlcnRpb25zKCspLCA5NDAg ZGVsZXRpb25zKC0pCj4+IAo+PiBIb3cgZG8geW91IGV4cGVjdCBhIHBhdGNoIG9mIHRoaXMgc2l6 ZSBiZSBtZXJnZWQ/Cj4KPiBVc2luZyBiNCBhbSA6LSkgSG9uZXN0bHksIGluIHRoZSBjb3ZlciBs ZXR0ZXIgSSB3cm90ZSBhYm91dCBhbiBpbW11dGFibGUKPiBicmFuY2ggYW5kIG9mZmVyZWQgdG8g cmViYXNlIHRvIDcuNC1yYzEuIFdoZW4gdHJ5aW5nIHRvIGFwcGx5IHRoaXMKPiBzZXJpZXMgb24g dG9wIG92IDcuNC1yYzEgdGhlcmUgYXJlIG9ubHkgNiBjb25mbGljdHMgKDF4IG1vZGlmeS9kZWxl dGUKPiBhbmQgNXggY29udGVudCk7IHRoZXNlIGFyZSBhbGwgbm90IHNvIGhhcmQgdG8gcmVzb2x2 ZSAoYW5kIGV2ZW4gZHJvcHBpbmcKPiB0aGUgcmVzcGVjdGl2ZSBodW5rcyAoaS5lLiByZXNvbHZp bmcgdXNpbmcgYGdpdCBjaGVja291dCBIRUFEYCkgaXMgZmluZQo+IGZvciBtZS4pCj4KPj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcGNpLmMKPj4gPiBpbmRleCA4NGE3ZGM2YWI1ZGIuLmZhY2ViM2RlNGZh MyAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+PiA+IEBAIC04NzAsNyArODcw LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlX2lkIHBjaWlkbGlzdFtdID0gewo+ PiA+ICAJSU5URUxfQVRTX01fSURTKElOVEVMX1ZHQV9ERVZJQ0UsICZhdHNfbV9pbmZvKSwKPj4g PiAgCUlOVEVMX0FSTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAgCUlO VEVMX01UTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAtCXt9Cj4+ID4g Kwl7IH0KPj4gCj4+IFBlcnNvbmFsbHksIEkgd291bGQgKmFsd2F5cyogdXNlIHt9IGluc3RlYWQg b2YgeyB9LCBhbmQgd291bGQgcmF0aGVyIG5vdAo+PiBjaGFuZ2UuCj4+IAo+PiBBY3Jvc3MgdGhl IHRyZWUsIHt9IGlzIHNsaWdodGx5IG1vcmUgY29tbW9uIHRoYW4geyB9LiBJTU8gY2hhbmdpbmcg dGhlbQo+PiBpcyBwb2ludGxlc3MgY2h1cm4uCj4KPiBJdCBkZXBlbmRzIG9uIGhvdyB5b3UgY291 bnQuIE15IHN0YXRpc3RpYyBsb29rcyBhcyBmb2xsb3dzIChvbiB0b3Agb2YKPiBuZXh0LTIwMjYx MTE3KToKPgo+IAkkIGdpdCBncmVwIC1sIGRldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAt biAtZSAncHJpbnQgIiQxXG4iIGlmIG0vZGV2aWNlX2lkXHMqW2EtekEtWl8wLTldKlxbXF1ccyo9 XHMqeyg/OlxzKntbXn1dKn0sXHMqKHtccyp9KSkvJyB8IHNvcnQgfCB1bmlxIC1jCj4gCSAgICAg IDIgCX0KPiAJICAgICAgMiB7Cj4gCSAgICAgIDYgeyAgfQo+IAkgICAyNTk4IHsgfQo+IAkgICAx MjYyIHt9Cj4KPiBTbyBvdmVyIGFsbCAqX2RldmljZV9pZCB7IH0gaXMgbW9yZSBjb21tb24gYnkg YSBmYWN0b3Igb2YgPiAyLiBUaGlzCj4gc2VyaWVzIGZpeGVzIG9uZSB7ICB9IGFuZCByZWR1Y2Vz IHRoZSBudW1iZXIgb2Yge30gYnkgMzcuIEZvciBvbmx5Cj4gcGNpX2RldmljZV9pZCBpdCdzOgo+ Cj4gCSQgZ2l0IGdyZXAgLWwgcGNpX2RldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAtbiAt ZSAncHJpbnQgIiQxXG4iIGlmIG0vcGNpX2RldmljZV9pZFxzKlthLXpBLVpfMC05XSpcW1xdXHMq PVxzKnsoPzpccyp7W159XSp9LFxzKih7XHMqfSkpLycgfCBzb3J0IHwgdW5pcSAtYwo+IAkgICAg MTU5IHsgfQo+IAkgICAgIDMyIHt9Cj4KPiBXaXRob3V0IHRoZSBjb250ZXh0IG9mIGFuIGFycmF5 IGluaXRpYWxpemVyIHRoZXJlIGFyZSBtYW55IGVtcHR5Cj4gY29kZSBibG9ja3MgKGZ1bmN0aW9u IGJvZHlzIG9yIGBkbyB7fSB3aGlsZSAoMClgKSwgZW1wdHkgZHQgbm9kZXMsIGFuZAo+IHt9IGlu IFJ1c3QgY29kZSwgd2hpY2ggSU1ITyBoYXZlIHRvIGJlIGNvbnNpZGVyZWQgb2ZmLXRvcGljIGZv ciB0aGlzCj4gc3RhdGlzdGljLgoKSSByZWFsaXplIG15IHBocmFzaW5nIHdhcyBjYXJlbGVzcy4K Ck15IHBvaW50IHdhcyBub3Qgc28gbXVjaCBhYm91dCBvbmUgYmVpbmcgbW9yZSBjb21tb24gdGhh biB0aGUgb3RoZXIsIGJ1dApyYXRoZXIgdGhhdCB0aGVyZSBhcmUgKnRob3VzYW5kcyogb2YgaW5z dGFuY2VzIG9mIGJvdGgsIHNwZWNpZmljYWxseSBhcwpDIGNvbXBvdW5kIGxpdGVyYWxzIHdpdGgg ZW1wdHkgaW5pdGlhbGl6ZXIgbGlzdC4gSSB0aGluayBpdCdzIHBvaW50bGVzcwp0byBjb252ZXJ0 IG9uZSB0byBvdGhlciwgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIHlvdSdyZSBhZGRpbmcgb3IgcmVt b3ZpbmcKYSBzcGFjZS4KCkkgbWVudGlvbmVkIG15IHByZWZlcmVuY2UsIGJlY2F1c2UgaWYgSSB3 ZXJlIHRvIGdvIG9uIGEgc3R5bGUgZml4aW5nCnNwcmVlLCBJJ2QgZ28gdGhlIG90aGVyIGRpcmVj dGlvbi4gQnV0IEkgdGhpbmsgdGhhdCB0b28gd291bGQgYmUKcG9pbnRsZXNzLgoKSSBzdWdnZXN0 IHRvIGp1c3QgYWNjZXB0IGVpdGhlci4KCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1943606A33B for ; Wed, 18 Nov 2026 16:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kUu+QHFN; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mP4DwPyz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=csSwdwSdHCh6zgiHQE3ctNmVs78QaNxiKw4f3MnCy7o=; b=kUu+QHFNUkAZEpRzhveiOD5rLJ CyflrMLXinCV539uzHwqc5lgHujJFe9gJrsoxjIgVubaKFlhP5hjsyKKmlJ7lyzY3zMHeanPXebe+ nS7Of1Y4mF8+0OV21GFwY6IRI/Lv3zqbx+S8VYLzlxBGkHmSbai05c2laP4FyDsbdSF6S+gc+Nnj8 fiLXXMG6/7SK404U47cPlQETrzPYMvVAJRqpWPYJnCIIUeVxfUq+mrLu3k6wTZbd+PnHe8BW7PzUW Lm1rPrM88QJc90k31ID25TXU7DXcd6msClQ7HqiWpwYAG/em85VZBQDEMvAGOACcFbJEOCJ4Y3ZwY MXtHZLHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTisn-00000009anw-3f0o; Wed, 18 Nov 2026 16:51:41 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTisS-00000009aT7-3KDx; Wed, 18 Nov 2026 16:51:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795020681; x=1826556681; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ajDnh0zw+64dcFPrEUfvS5sWfWZYQWJZbcQwO+AcVNs=; b=mP4DwPyzA12OflFAs7cqsLyFUlGk851Vd/gqVwVcN25x8BrQL+i7AmOL 8mYJpmast9tqACSNx8lBA4jZ4/q1QzUvavsA4vMpmrO4kXPI5tmgD7UvX RIKZkYtrXgFcDgMSDp8+RxF/Qsk0Pdt1zP/11+VRi9zgvwFg2kn0/zAaJ juFRnpN5gAXJQ16xhWq2lvyYTb3qIRMVB9Yj0aB5dYr71LMGSI/TCUXfu Q/vbbt3vkm3f9HlNHt84ek7qFjbaO9159QwvU9BrlJgluRx7ACzWJzJJs wtZ+6YyX/GEjAKJa7Ohka54I7IWU1FNw+PjgE6WXf82fCJhvvI5wWCOY1 w==; X-CSE-ConnectionGUID: oZ2rE8KxRlG7KJlEHRUcVA== X-CSE-MsgGUID: 8DpQhJ4ORkulGvnvyMycQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11970"; a="3699699" X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="3699699" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:31 -0800 X-CSE-ConnectionGUID: k/DCmaX/Qp2q9S20vakyDw== X-CSE-MsgGUID: YVFQiz1BSVmcIhLrCJbvrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,219,1787036400"; d="scan'208";a="9985477" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.187]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2026 08:50:21 -0800 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Date: Wed, 18 Nov 2026 18:50:19 +0200 Message-ID: <8ebe3b7219ffd963a498cccbcfe6cefc92717f0c@intel.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_085120_862726_7CECB254 X-CRM114-Status: GOOD ( 23.59 ) X-Spam-Score: -4.3 (----) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 T24gV2VkLCAxOCBOb3YgMjAyNiwgVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bi YXlsaWJyZS5jb20+IHdyb3RlOgo+IEhlbGxvIEphbmksCj4KPiBPbiBXZWQsIE5vdiAxOCwgMjAy NiBhdCAwMzoyNzo0MFBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gPiBbLi4uXQo+PiA+ ICBkcml2ZXJzL2dwdS9pcHUtdjMvaXB1LWNvbW1vbi5jICAgICAgICAgICAgICAgfCAgIDggKy0K Pj4gPiAgZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1wcmUuYyAgICAgICAgICAgICAgICAgIHwgICA0 ICstCj4+ID4gIGRyaXZlcnMvZ3B1L2lwdS12My9pcHUtcHJnLmMgICAgICAgICAgICAgICAgICB8 ICAgNCArLQo+PiA+ICAyNTQgZmlsZXMgY2hhbmdlZCwgMTE1NSBpbnNlcnRpb25zKCspLCA5NDAg ZGVsZXRpb25zKC0pCj4+IAo+PiBIb3cgZG8geW91IGV4cGVjdCBhIHBhdGNoIG9mIHRoaXMgc2l6 ZSBiZSBtZXJnZWQ/Cj4KPiBVc2luZyBiNCBhbSA6LSkgSG9uZXN0bHksIGluIHRoZSBjb3ZlciBs ZXR0ZXIgSSB3cm90ZSBhYm91dCBhbiBpbW11dGFibGUKPiBicmFuY2ggYW5kIG9mZmVyZWQgdG8g cmViYXNlIHRvIDcuNC1yYzEuIFdoZW4gdHJ5aW5nIHRvIGFwcGx5IHRoaXMKPiBzZXJpZXMgb24g dG9wIG92IDcuNC1yYzEgdGhlcmUgYXJlIG9ubHkgNiBjb25mbGljdHMgKDF4IG1vZGlmeS9kZWxl dGUKPiBhbmQgNXggY29udGVudCk7IHRoZXNlIGFyZSBhbGwgbm90IHNvIGhhcmQgdG8gcmVzb2x2 ZSAoYW5kIGV2ZW4gZHJvcHBpbmcKPiB0aGUgcmVzcGVjdGl2ZSBodW5rcyAoaS5lLiByZXNvbHZp bmcgdXNpbmcgYGdpdCBjaGVja291dCBIRUFEYCkgaXMgZmluZQo+IGZvciBtZS4pCj4KPj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcGNpLmMKPj4gPiBpbmRleCA4NGE3ZGM2YWI1ZGIuLmZhY2ViM2RlNGZh MyAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+PiA+IEBAIC04NzAsNyArODcw LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlX2lkIHBjaWlkbGlzdFtdID0gewo+ PiA+ICAJSU5URUxfQVRTX01fSURTKElOVEVMX1ZHQV9ERVZJQ0UsICZhdHNfbV9pbmZvKSwKPj4g PiAgCUlOVEVMX0FSTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAgCUlO VEVMX01UTF9JRFMoSU5URUxfVkdBX0RFVklDRSwgJm10bF9pbmZvKSwKPj4gPiAtCXt9Cj4+ID4g Kwl7IH0KPj4gCj4+IFBlcnNvbmFsbHksIEkgd291bGQgKmFsd2F5cyogdXNlIHt9IGluc3RlYWQg b2YgeyB9LCBhbmQgd291bGQgcmF0aGVyIG5vdAo+PiBjaGFuZ2UuCj4+IAo+PiBBY3Jvc3MgdGhl IHRyZWUsIHt9IGlzIHNsaWdodGx5IG1vcmUgY29tbW9uIHRoYW4geyB9LiBJTU8gY2hhbmdpbmcg dGhlbQo+PiBpcyBwb2ludGxlc3MgY2h1cm4uCj4KPiBJdCBkZXBlbmRzIG9uIGhvdyB5b3UgY291 bnQuIE15IHN0YXRpc3RpYyBsb29rcyBhcyBmb2xsb3dzIChvbiB0b3Agb2YKPiBuZXh0LTIwMjYx MTE3KToKPgo+IAkkIGdpdCBncmVwIC1sIGRldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAt biAtZSAncHJpbnQgIiQxXG4iIGlmIG0vZGV2aWNlX2lkXHMqW2EtekEtWl8wLTldKlxbXF1ccyo9 XHMqeyg/OlxzKntbXn1dKn0sXHMqKHtccyp9KSkvJyB8IHNvcnQgfCB1bmlxIC1jCj4gCSAgICAg IDIgCX0KPiAJICAgICAgMiB7Cj4gCSAgICAgIDYgeyAgfQo+IAkgICAyNTk4IHsgfQo+IAkgICAx MjYyIHt9Cj4KPiBTbyBvdmVyIGFsbCAqX2RldmljZV9pZCB7IH0gaXMgbW9yZSBjb21tb24gYnkg YSBmYWN0b3Igb2YgPiAyLiBUaGlzCj4gc2VyaWVzIGZpeGVzIG9uZSB7ICB9IGFuZCByZWR1Y2Vz IHRoZSBudW1iZXIgb2Yge30gYnkgMzcuIEZvciBvbmx5Cj4gcGNpX2RldmljZV9pZCBpdCdzOgo+ Cj4gCSQgZ2l0IGdyZXAgLWwgcGNpX2RldmljZV9pZCB8IHhhcmdzIC1uIDEgcGVybCAtZyAtbiAt ZSAncHJpbnQgIiQxXG4iIGlmIG0vcGNpX2RldmljZV9pZFxzKlthLXpBLVpfMC05XSpcW1xdXHMq PVxzKnsoPzpccyp7W159XSp9LFxzKih7XHMqfSkpLycgfCBzb3J0IHwgdW5pcSAtYwo+IAkgICAg MTU5IHsgfQo+IAkgICAgIDMyIHt9Cj4KPiBXaXRob3V0IHRoZSBjb250ZXh0IG9mIGFuIGFycmF5 IGluaXRpYWxpemVyIHRoZXJlIGFyZSBtYW55IGVtcHR5Cj4gY29kZSBibG9ja3MgKGZ1bmN0aW9u IGJvZHlzIG9yIGBkbyB7fSB3aGlsZSAoMClgKSwgZW1wdHkgZHQgbm9kZXMsIGFuZAo+IHt9IGlu IFJ1c3QgY29kZSwgd2hpY2ggSU1ITyBoYXZlIHRvIGJlIGNvbnNpZGVyZWQgb2ZmLXRvcGljIGZv ciB0aGlzCj4gc3RhdGlzdGljLgoKSSByZWFsaXplIG15IHBocmFzaW5nIHdhcyBjYXJlbGVzcy4K Ck15IHBvaW50IHdhcyBub3Qgc28gbXVjaCBhYm91dCBvbmUgYmVpbmcgbW9yZSBjb21tb24gdGhh biB0aGUgb3RoZXIsIGJ1dApyYXRoZXIgdGhhdCB0aGVyZSBhcmUgKnRob3VzYW5kcyogb2YgaW5z dGFuY2VzIG9mIGJvdGgsIHNwZWNpZmljYWxseSBhcwpDIGNvbXBvdW5kIGxpdGVyYWxzIHdpdGgg ZW1wdHkgaW5pdGlhbGl6ZXIgbGlzdC4gSSB0aGluayBpdCdzIHBvaW50bGVzcwp0byBjb252ZXJ0 IG9uZSB0byBvdGhlciwgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIHlvdSdyZSBhZGRpbmcgb3IgcmVt b3ZpbmcKYSBzcGFjZS4KCkkgbWVudGlvbmVkIG15IHByZWZlcmVuY2UsIGJlY2F1c2UgaWYgSSB3 ZXJlIHRvIGdvIG9uIGEgc3R5bGUgZml4aW5nCnNwcmVlLCBJJ2QgZ28gdGhlIG90aGVyIGRpcmVj dGlvbi4gQnV0IEkgdGhpbmsgdGhhdCB0b28gd291bGQgYmUKcG9pbnRsZXNzLgoKSSBzdWdnZXN0 IHRvIGp1c3QgYWNjZXB0IGVpdGhlci4KCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2lj Cg==