Re: [PATCH i-g-t 1/2] tests/kms_pm_dc: Ensure PSR is enabled

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2024-03-27 at 06:42 +0000, Thasleem, Mohammed wrote:
> LGTM:
> Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

Thank you Mohammed for reviewing my patches. These are now pushed to
master.

BR,

Jouni Högander

> 
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Jouni Högander
> Sent: Tuesday, March 26, 2024 6:50 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogander@intel.com>
> Subject: [PATCH i-g-t 1/2] tests/kms_pm_dc: Ensure PSR is enabled
> 
> In certain cases PSR support is informed, but it doesn't get enabled
> due to some limitations. This is causing failures which are actually
> just expected behaviour. Fix this by checking PSR is really enabled
> and skip in case it is not
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9737
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  tests/intel/kms_pm_dc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index
> 7deebf83d..176f7a04b 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -399,6 +399,7 @@ static void test_dc_state_psr(data_t *data, int
> dc_flag)
>         dc_counter_before_psr = read_dc_counter(data->debugfs_fd,
> dc_flag);
>         setup_output(data);
>         setup_primary(data);
> +       igt_require(!psr_disabled_check(data->debugfs_fd));
>         igt_assert(psr_wait_entry(data->debugfs_fd, data-
> >op_psr_mode, NULL));
>         check_dc_counter(data, dc_flag, dc_counter_before_psr);
>         cleanup_dc_psr(data);
> @@ -605,6 +606,7 @@ static void test_pkgc_state_psr(data_t *data)
>         prev_value = read_pkgc_counter(data->debugfs_root_fd);
>         setup_output(data);
>         setup_primary(data);
> +       igt_require(!psr_disabled_check(data->debugfs_fd));
>         igt_assert(psr_wait_entry(data->debugfs_fd, data-
> >op_psr_mode, NULL));
>         psr_dpms(data, DRM_MODE_DPMS_OFF);
>         igt_wait((cur_value = read_pkgc_counter(data-
> >debugfs_root_fd)) > prev_value,
> --
> 2.34.1
>