From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state Date: Thu, 4 Oct 2018 15:25:42 +0200 Message-ID: <8eddb830-516b-ce91-5da7-e6403881c4a2@linux.intel.com> References: <20181004094604.2646-1-maarten.lankhorst@linux.intel.com> <20181004094604.2646-9-maarten.lankhorst@linux.intel.com> <20181004125755.GQ9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30B26E242 for ; Thu, 4 Oct 2018 13:25:57 +0000 (UTC) In-Reply-To: <20181004125755.GQ9144@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDQtMTAtMTggb20gMTQ6NTcgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVGh1LCBP Y3QgMDQsIDIwMTggYXQgMTE6NDU6NTlBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IERvIG5vdCByZWx5IG9uIGNydGMtPmNvbmZpZyBhbnkgbW9yZS4gUmVtb3ZlIHRoZSBhc3Nl cnRpb24gZnJvbQo+PiBpYnhfcGNoX2RwbGxfZGlzYWJsZSwgYmVjYXVzZSB3ZSB0aGUgZHBsbCBz dGF0ZSB0cmFja2luZyBzaG91bGQKPj4gYWxyZWFkeSBoYW5kbGUgdGhpcyBjYXNlIGNvcnJlY3Rs eS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPj4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jICB8IDE0ICsrKysrKy0tLS0tLQo+PiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8IDMxICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCB8ICA2ICsrKy0tLQo+PiAg MyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPj4KPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCBmZThjY2JkZDRlYTEuLjRk ZjQyOTNhNzkxNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBA QCAtNDc0OSw3ICs0NzQ5LDcgQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfcGNoX2VuYWJsZShjb25z dCBzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4gIAkgKiBOb3RlIHRoYXQgZW5h YmxlX3NoYXJlZF9kcGxsIHRyaWVzIHRvIGRvIHRoZSByaWdodCB0aGluZywgYnV0Cj4+ICAJICog Z2V0X3NoYXJlZF9kcGxsIHVuY29uZGl0aW9uYWxseSByZXNldHMgdGhlIHBsbCAtIHdlIG5lZWQg dGhhdCB0byBoYXZlCj4+ICAJICogdGhlIHJpZ2h0IExWRFMgZW5hYmxlIHNlcXVlbmNlLiAqLwo+ PiAtCWludGVsX2VuYWJsZV9zaGFyZWRfZHBsbChjcnRjKTsKPj4gKwlpbnRlbF9lbmFibGVfc2hh cmVkX2RwbGwoY3J0Y19zdGF0ZSk7Cj4+ICAKPj4gIAkvKiBzZXQgdHJhbnNjb2RlciB0aW1pbmcs IHBhbmVsIG11c3QgYWxsb3cgaXQgKi8KPj4gIAlhc3NlcnRfcGFuZWxfdW5sb2NrZWQoZGV2X3By aXYsIHBpcGUpOwo+PiBAQCAtNTU5MSw4ICs1NTkxLDggQEAgc3RhdGljIHZvaWQgaXJvbmxha2Vf Y3J0Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+PiAgCWlu dGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmcoZGV2X3ByaXYsIHBpcGUsIGZhbHNl KTsKPj4gIAlpbnRlbF9zZXRfcGNoX2ZpZm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBw aXBlLCBmYWxzZSk7Cj4+ICAKPj4gLQlpZiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2Vu Y29kZXIpCj4+IC0JCWludGVsX3ByZXBhcmVfc2hhcmVkX2RwbGwoaW50ZWxfY3J0Yyk7Cj4+ICsJ aWYgKHBpcGVfY29uZmlnLT5oYXNfcGNoX2VuY29kZXIpCj4+ICsJCWludGVsX3ByZXBhcmVfc2hh cmVkX2RwbGwocGlwZV9jb25maWcpOwo+PiAgCj4+ICAJaWYgKGludGVsX2NydGNfaGFzX2RwX2Vu Y29kZXIoaW50ZWxfY3J0Yy0+Y29uZmlnKSkKPj4gIAkJaW50ZWxfZHBfc2V0X21fbihpbnRlbF9j cnRjLCBNMV9OMSk7Cj4+IEBAIC01NzEwLDggKzU3MTAsOCBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxs X2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPj4gIAo+ PiAgCWludGVsX2VuY29kZXJzX3ByZV9wbGxfZW5hYmxlKGNydGMsIHBpcGVfY29uZmlnLCBvbGRf c3RhdGUpOwo+PiAgCj4+IC0JaWYgKGludGVsX2NydGMtPmNvbmZpZy0+c2hhcmVkX2RwbGwpCj4+ IC0JCWludGVsX2VuYWJsZV9zaGFyZWRfZHBsbChpbnRlbF9jcnRjKTsKPj4gKwlpZiAocGlwZV9j b25maWctPnNoYXJlZF9kcGxsKQo+PiArCQlpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwocGlwZV9j b25maWcpOwo+PiAgCj4+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4+ICAJCWlj bF9tYXBfcGxsc190b19wb3J0cyhjcnRjLCBwaXBlX2NvbmZpZywgb2xkX3N0YXRlKTsKPj4gQEAg LTYyODYsNyArNjI4Niw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2NydGNfZGlzYWJsZV9ub2F0b21p YyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+ICAKPj4gIAlpbnRlbF9mYmNfZGlzYWJsZShpbnRl bF9jcnRjKTsKPj4gIAlpbnRlbF91cGRhdGVfd2F0ZXJtYXJrcyhpbnRlbF9jcnRjKTsKPj4gLQlp bnRlbF9kaXNhYmxlX3NoYXJlZF9kcGxsKGludGVsX2NydGMpOwo+PiArCWludGVsX2Rpc2FibGVf c2hhcmVkX2RwbGwoY3J0Y19zdGF0ZSk7Cj4gSSBndWVzcyB0aGlzIGlzIHRoZSBleHBsb3Npb24g b24gaTkxNWcvaTk2NWcuIFdlJ3ZlIGFscmVhZHkgZnJlZWQgdGhpcwo+IGNydGMgc3RhdGUgYXQg dGhpcyBwb2ludC4gU28gSSBndWVzcyBzL2NydGNfc3RhdGUvY3J0Yy0+c3RhdGUvIGFuZCBpdAo+ IHNob3VsZCBiZSBmaW5lPwo+Ck5vLCB0aGUgZXhwbG9zaW9uIGlzIGF0CgotCWlmIChXQVJOX09O KHBsbCA9PSBOVUxMKSkKKwlpZiAoIVdBUk5fT04oIXBsbCkpCiAJCXJldHVybjsKCk9vcHMhIFNo b3VsZCBiZSBmaXhlZCBpbiB2MiBJJ20gc2VuZGluZyBub3cuCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK