From: Krzysztof Kozlowski <krzk@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Casey Connolly <casey.connolly@linaro.org>,
Joel Selvaraj <joelselvaraj.oss@gmail.com>,
Jens Reidel <adrian@travitia.xyz>,
Petr Hodina <petr.hodina@protonmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings
Date: Sun, 5 Apr 2026 10:55:06 +0200 [thread overview]
Message-ID: <8ef78376-87f5-4ad4-8453-c59d6aa1dcb5@kernel.org> (raw)
In-Reply-To: <205d43a0-70aa-4e49-af36-8bc2d5809110@ixit.cz>
On 05/04/2026 10:01, David Heidelberg wrote:
> On 05/04/2026 09:55, Krzysztof Kozlowski wrote:
>> On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
>>> Add documentation for Tianma display and touchscreen variant.
>>>
>>> While at it, correct binding documentation expectation.
>>
>> What expectation? What exactly did you corrected that you claim this is
>> a fix?
>
> I would say the missing Tianma variant, which been with us for some time. The
Expectation of missing Tianma? We don't have such expectations...
> follow up commit fixes the missing compatible and order, thus it would make
> sense to me have also the dt-bindings part backported and fixed.
You probably should read original discussion why this ended up like that.
>
> I agree I don't have strong case here. Should I drop the tag, keep it or replace
> it with Cc: stable@vger.kernel.org?
If you cannot explain what you are fixing, then this is not a fix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-05 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 16:55 [PATCH 0/2] Correct Xiaomi Poco F1 compatible strings and evaluation David Heidelberg
2026-04-03 16:55 ` David Heidelberg via B4 Relay
2026-04-03 16:55 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings David Heidelberg
2026-04-03 16:55 ` David Heidelberg via B4 Relay
2026-04-05 7:55 ` Krzysztof Kozlowski
2026-04-05 8:01 ` David Heidelberg
2026-04-05 8:55 ` Krzysztof Kozlowski [this message]
2026-04-05 9:19 ` David Heidelberg
2026-04-03 16:55 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Fix compatible strings David Heidelberg
2026-04-03 16:55 ` David Heidelberg via B4 Relay
2026-04-05 8:02 ` Krzysztof Kozlowski
2026-04-05 8:09 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef78376-87f5-4ad4-8453-c59d6aa1dcb5@kernel.org \
--to=krzk@kernel.org \
--cc=adrian@travitia.xyz \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=joelselvaraj.oss@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=petr.hodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.