From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-block@nongnu.org
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/2] block/gluster: add support to choose libgfapi logfile
Date: Tue, 13 Sep 2016 10:23:32 -0500 [thread overview]
Message-ID: <8ef98a4a-c44b-3074-e213-7b7e46c66410@redhat.com> (raw)
In-Reply-To: <1473745333-7548-2-git-send-email-jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On 09/13/2016 12:42 AM, Jeff Cody wrote:
> From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
>
> currently all the libgfapi logs defaults to '/dev/stderr' as it was hardcoded
> in a call to glfs logging api. When the debug level is chosen to DEBUG/TRACE,
> gfapi logs will be huge and fill/overflow the console view.
>
> This patch provides a commandline option to mention log file path which helps
> in logging to the specified file and also help in persisting the gfapi logs.
>
> +++ b/qapi/block-core.json
> @@ -2154,13 +2154,16 @@
> #
> # @debug-level: #optional libgfapi log level (default '4' which is Error)
> #
> +# @logfile: #optional libgfapi log file (default /dev/stderr)
> +#
> # Since: 2.7
logfile missed 2.7; please add a '(since 2.8)' designator on the
@logfile line as a followup patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-13 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 5:42 [Qemu-devel] [PULL 0/2] Block patches Jeff Cody
2016-09-13 5:42 ` [Qemu-devel] [PULL 1/2] block/gluster: add support to choose libgfapi logfile Jeff Cody
2016-09-13 15:23 ` Eric Blake [this message]
2016-09-13 15:25 ` Jeff Cody
2016-09-13 5:42 ` [Qemu-devel] [PULL 2/2] qapi/block-core: add doc describing GlusterServer vs. SocketAddress Jeff Cody
2016-09-13 11:59 ` [Qemu-devel] [PULL 0/2] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef98a4a-c44b-3074-e213-7b7e46c66410@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.