From: Jan Beulich <jbeulich@suse.com>
To: Michal Orzel <michal.orzel@amd.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger@xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/3] drivers/char: Check if console=dtuart for ACPI SPCR serial bring up
Date: Wed, 2 Sep 2026 10:56:30 +0200 [thread overview]
Message-ID: <8efb31c8-cb19-4cc7-b752-7786139afafa@suse.com> (raw)
In-Reply-To: <20260902073606.61062-3-michal.orzel@amd.com>
On 02.09.2026 09:36, Michal Orzel wrote:
> dtuart denotes a generic UART parsed from a device tree (back then it
> was the only method, hence dt prefix) or ACPI SPCR table (they all use
> the SERHND_DTUART serial handle). Currently we only check if console= is
> set to dtuart in the DT flow and not in the ACPI flow. This means that
> even if we set console=none we would still bring up ACPI parsed
> serial device for nothing. Move the check to uart_init() to cover both
> paths.
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2026-09-02 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:36 [PATCH 0/3] dtuart fixes Michal Orzel
2026-09-02 7:36 ` [PATCH 1/3] cmdline: Document console=dtuart option Michal Orzel
2026-09-02 8:55 ` Jan Beulich
2026-09-02 11:12 ` Orzel, Michal
2026-09-02 7:36 ` [PATCH 2/3] drivers/char: Check if console=dtuart for ACPI SPCR serial bring up Michal Orzel
2026-09-02 8:56 ` Jan Beulich [this message]
2026-09-02 7:36 ` [PATCH 3/3] drivers/char: Panic when the requested UART fails to initialise Michal Orzel
2026-09-02 9:44 ` Halder, Ayan Kumar
2026-09-08 10:15 ` Halder, Ayan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8efb31c8-cb19-4cc7-b752-7786139afafa@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.