From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C52CDC4743C for ; Mon, 21 Jun 2021 18:35:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B427B6109F for ; Mon, 21 Jun 2021 18:35:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B427B6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DEB6981ED0; Mon, 21 Jun 2021 20:35:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="WqGQI5rR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 951CB829A6; Mon, 21 Jun 2021 20:35:29 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6FBED80563 for ; Mon, 21 Jun 2021 20:35:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624300524; bh=qhMg8sMy6Wb4KRm4mqyyZN8WdVZlsEkNqvDw0u6RGJg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=WqGQI5rRYAm6MFaJvrB7DuoILOIZWI3bX7KUrbrH+0wyupSRVa5LaCqjgtrXHuJtK Wyha0ZH1KdbgabQIvq43ZRgLjRzUdyJRXGi4yPIbGNTiKzXz8Rt90z1/Tk8ruCG44A 7oq0OdxSLmDRhhXKtM2dwmXzl4FNL1O2UEKerd2s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mv2xU-1l4OXU1fbk-00qxtq; Mon, 21 Jun 2021 20:35:24 +0200 Subject: Re: [PATCH v2 1/3] tools: docker: Install a readable kernel for libguestfs-tools To: Alper Nebi Yasak , u-boot@lists.denx.de Cc: AKASHI Takahiro , Bin Meng , Tom Rini , Simon Glass , Daniel Schwierzeck , Marek Vasut References: <20210613140731.16254-1-alpernebiyasak@gmail.com> <20210613140731.16254-2-alpernebiyasak@gmail.com> <0354f009-4bfa-9f17-0835-edf28a6bb9ce@gmail.com> From: Heinrich Schuchardt Message-ID: <8f4d811a-0e7f-e997-9d8d-dc4dedbdd7f5@gmx.de> Date: Mon, 21 Jun 2021 20:35:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <0354f009-4bfa-9f17-0835-edf28a6bb9ce@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:doyMWSzuaVapLPA+RkPEzeUNrzM+AgVRUu4xgNKAdd4SCEVMC6S 06HrUqB1JWN1OKk+Ni3Es+P805vSKKPdFcgAhZn0Q0j3KIhdQx5QYwGV+cRF1fJXXZUaLH4 b/w7VlXz6lA8R9llQNkxzaW1XPUMpSabIc7I+jcsdSxOQVNa2Rr+XgYLdDBAex7j3OSWY6t NzvJULDR73cadOTQVoxPg== X-UI-Out-Filterresults: notjunk:1;V03:K0:G5jLMXUIQGo=:P3BmShNWD9cLA6CNY2qLVD h3vZr2B4+1RejgJmPkMUmNp3TIK0Jfn8tKXBTFWXGQj1uY0jjaBJjC2na9Z497cWYlBFMmW8n Lsl72kR7Pb34bm5FvzUVyuafKMTjij0+B+s2ogv8LDFctaZLdlgXioJDmtY5BS+Cbh25c9CLb Ak2tnKw1g5kXpY+72xQp2E0L6+0ifYKT95MhCT9QR2qiCKbX6ZzTfTmkBZ19CokRp57OIeyfC nfCTqq7YI9Pj2+8KrdUKps/KP0nnlmKUqSwJsvdZmBl+DaRaAyeeQK5p4L2ldXMQ2pYc8LKof TFo8KEIIR5NVHue+h/eqnuF7ctNlZYGGyedtDny+47x78HlUuwZwHV5CgYuZKt+qj5i9I/2FR so/yaavcO7tgRqczgxCA4coCFRBr+/oT9K6oosPaoaagMRsY2yJrNDoXmvljdgm89fkzg7Uce zI9yI6aXFn6Ej9/MJzPoH7JQQjEx28WdGnEjETemHwRNzK+8S4kx10eI1E0ERkHCxhWx8RaR5 mkn4lSBxHDKNQ0Zj+/2SEyivVuRtceeu8LkXvpi7RH8kc6088RvAyNxKk8wZes/WiZB+n6uri qGQoWsvm78xue6AV22iK4w+mEKkXDS5MYYb9uWKJRcrE1ky2igNdQ+JNKbEyGGanSUQWjsUcg 9ud3Z/x5Xx8MEc7sWGQNcVxBxcOGb/qOqdYT2zmD1xV4fLkrsd5tbccVa4ZnsJLeZa19VVAY3 4EN5sNljSU0HmXGo1KhqQKQycnEX30Jzu3sp7N7q4+pYT2Tv9GtAOlHQClTQunPXlTsG0EYcs k9lDM6fw2/zJ0/+HeUx5q9M2eJsrb3OmqDUuy7R/BR3ub81O5US2Rr9GfxVm69Np0bPkzTjqy TOgZ1AmFRquh5eASs7ts/7B6B0R7GbfhQeLPPtUxVpHPYQI/PyepqYP7xHFkOKE0JUhOZGwRf HeGteo+ON7WFZg6K0NptSPEIPgvUOy+3OxDG5N7uYlmxBxzYZk3u2Gk2FJILGb0IRAQ2QzpLl At/2zkEQfRzf/ck5xesgKsDan3GsodmnAoxmZpIC2JA/varNbDxxvhSHWZtI9Hr01CUJOg1G3 8xVUcX/si6zYiTM0BOa8dVucy9vU8dnlyMI X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 6/21/21 8:12 PM, Alper Nebi Yasak wrote: > On 14/06/2021 20:29, Heinrich Schuchardt wrote: >> On 6/13/21 4:07 PM, Alper Nebi Yasak wrote: >>> >>> supermin: failed to find a suitable kernel (host_cpu=3Dx86_64). >>> >>> I looked for kernels in /boot and modules in /lib/modules. >>> >>> [...] >>> >>> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile >>> index d2f0074ee8a6..563b16639e54 100644 >>> --- a/tools/docker/Dockerfile >>> +++ b/tools/docker/Dockerfile >>> @@ -71,6 +71,7 @@ RUN apt-get update && apt-get install -y \ >>> libssl-dev \ >>> libudev-dev \ >>> libusb-1.0-0-dev \ >>> + linux-image-kvm \ >>> lzma-alone \ >>> lzop \ >>> mount \ >>> @@ -99,6 +100,9 @@ RUN apt-get update && apt-get install -y \ >>> zip \ >>> && rm -rf /var/lib/apt/lists/* >>> >>> +# Make kernels readable for libguestfs tools to work correctly >>> +RUN chmod +r /boot/vmlinu* /lib/modules/*/vmlinu* || true >> >> /lib/modules/4.15.0-1092-kvm# find . -name 'vm*' >> does not find any file. >> >> We don't need '|| true' if you do not refer to non-existent files. > > I included both dirs as libguestfs checks both of them. If that doesn't > convince you, I can send a v3 with just `chmod +r /boot/vmlinu*`. We are on Ubuntu. We only need to consider files that Ubuntu actually provides. Best regards Heinrich > > I actually misread the error message above as mentioning both dirs for > kernel so I didn't explicitly write it in the commit message, but the > source code [1] confirms that both are checked. > > [1] > https://github.com/libguestfs/supermin/blob/master/src/format_ext2_kerne= l.ml#L28-L49 > > (sorry for the late reply) >