From: Daniel Carpenter <dc@ammonit.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: http.sslVersion only specifies minimum TLS version, later versions are allowed
Date: Mon, 3 May 2021 11:56:32 +0000 [thread overview]
Message-ID: <8f664b07d1df45bcb6b3f787f42bd046@ammonit.com> (raw)
When I run: "GIT_SSL_VERSION=tlsv1.2 GIT_CURL_VERBOSE=T git clone https://github.com/git/git.git"
I see: "SSL connection using TLS1.3 / ECDHE_RSA_AES_128_GCM_SHA256", but I was expecting to see "TLS1.2".
This happens because the "sslversions" array ( https://github.com/git/git/blob/7e391989789db82983665667013a46eabc6fc570/http.c#L58 ) uses "CURL_SSLVERSION_TLSv1_2" which only specifies TLS 1.2 or later ( https://curl.se/libcurl/c/CURLOPT_SSLVERSION.html ).
I think configuring "tlsv1.2" should imply "CURL_SSLVERSION_TLSv1_2 | CURL_SSLVERSION_MAX_TLSv1_2", to force that specific version (and the same for "tlsv1.0", "tlsv1.1", "tlsv1.3").
For background: I noticed this because of this issue with debian buster https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987188 . The new libcurl backport enables TLS 1.3 support with gnutls, but it doesn't work for certain operations, so buster applications using a backported libcurl need to explicitly disable TLS 1.3 .
next reply other threads:[~2021-05-03 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 11:56 Daniel Carpenter [this message]
2021-05-03 13:55 ` http.sslVersion only specifies minimum TLS version, later versions are allowed Ævar Arnfjörð Bjarmason
2021-05-03 14:10 ` Jeff King
2021-05-03 15:02 ` Daniel Carpenter
2021-05-03 20:46 ` Jeff King
2021-05-03 20:56 ` Daniel Stenberg
2021-05-03 21:01 ` Randall S. Becker
2021-05-03 21:09 ` Daniel Stenberg
2021-05-03 21:23 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f664b07d1df45bcb6b3f787f42bd046@ammonit.com \
--to=dc@ammonit.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.