From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-13.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 924C87D00A for ; Sat, 11 Aug 2018 02:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727140AbeHKFXD (ORCPT ); Sat, 11 Aug 2018 01:23:03 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:46062 "EHLO mail-pg1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbeHKFXD (ORCPT ); Sat, 11 Aug 2018 01:23:03 -0400 Received: by mail-pg1-f179.google.com with SMTP id f1-v6so5168387pgq.12 for ; Fri, 10 Aug 2018 19:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=hnzYgA6uCwW08Ug9p00hDteCJhVAynNSJJOUtsY8aP0=; b=ExkWi+KnOI76hi36jb9qEcO63Qxdq9XY0ZDeElrNwKPrZ9oUEqXmScUmoD93GM6sy8 iEk3zRVDpEeQNV84DDtaeOfatorUK7FNFcwMYu8jEBECXTAxb3svMvA9sKXIYx+jpDvD VgRe3WPnsBPDiV+ZC6+TknXit6c/CXBk4UpNIDobd08XsL1mLPVBU8bwZ9rr+fz3o5I8 4uv5mNXuq0qK9qvTa4JqkjbNbVZH39WAWkdTyJfcReRx9C6XeyYT5V4cyBtGXFXK8J1i XjkDNSwggZgW0w5mraGViTGc9LIL+nEA5juZnoYvgxoX8UI+58Epl5MZRtFuE3XqcOdN UcLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=hnzYgA6uCwW08Ug9p00hDteCJhVAynNSJJOUtsY8aP0=; b=W/3Rq36sdzJ7fFV9TNVp+pf+aD1roYNjN1SrjYQg2Zk6CetcsYe7YqgKWdHaj27a++ M+zInAs75OU0yYpNzuwpeh7FxXNEStUnyS8xGsM/eHHYF55hMeeLgVluxaGtCJo+lRop EGwibIxJH/N7rgPhrp2dHlMrlOQ8Ky/YpI4hdurhO9IXGwvglynRV0ZBhv/OM/psfEKm xG6Uf1/W6xBNAPKWknM4RD1NlmLs1BzK+pY5gPI/XCLlUMlCoagaH7hs/CezH9Q6ApJI ygLPfUHse+6+vmPdXQCiNYjuMDnTzUlmVdIdFBRIFcivC6+EOkNFvu+nOAmaDCFpYGzc rBTA== X-Gm-Message-State: AOUpUlHJTwh1HExkZ8n/6z4lMcCjm7mpIvzoqe4J67RF2CEltdbWsIEp c0/bFwh7GpwgbF8RU9sTJm3qxg== X-Google-Smtp-Source: AA+uWPx947n63KO3xBOYclfMs8WtAki2RSkIR9MlEpy+ys+PgWnfQpFLaEDYxxHTssnSVUaIECHKfA== X-Received: by 2002:a62:b29c:: with SMTP id z28-v6mr9689604pfl.8.1533955831092; Fri, 10 Aug 2018 19:50:31 -0700 (PDT) Received: from drosen.mtv.corp.google.com ([2620:0:1000:1612:726:adc3:41a6:c383]) by smtp.gmail.com with ESMTPSA id r81-v6sm16674925pfa.18.2018.08.10.19.50.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 19:50:30 -0700 (PDT) Subject: Re: [PATCH v3] f2fs: checkpoint disabling To: Chao Yu , Jaegeuk Kim , Jonathan Corbet , linux-f2fs-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com References: <20180807234843.129387-1-drosen@google.com> From: Daniel Rosenberg Message-ID: <8fa37886-7eef-edca-ea14-9d3465efaeac@google.com> Date: Fri, 10 Aug 2018 19:50:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 08/10/2018 01:40 AM, Chao Yu wrote: > Hi Daniel, > > When filesystem is full, statfs shown abnormally as below: > > /dev/zram0 2095104 -17177769548 17179864652 - /mnt/f2fs > > I guess it's related to this patch, could you have a look at this? > > Thanks, > Thanks. It looks like I failed to check if we're running with checkpoints disabled inside of update_sit_entry when I updated the stats, causing it to underflow. I'll fix that in the next version.