From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4766542A8C for ; Thu, 6 Mar 2025 20:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741292463; cv=none; b=gTXtrhhK6n50A34zzQisQPctYmriD/CW4iTBivpTc7U++hMnbZ281NdFYKYeVHG3MdVF/oCGTKliCAFlZjvixMRMHYDtLQzmaYEdKcLOuV/ud2LlMkGG8/Kub1Vzl+/Mo2zmW0mf+uOIDsmm5gyrgspe0RU1Gh6xBcsNrob0MEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741292463; c=relaxed/simple; bh=Tj2sOTDgus+leh3sU6PUfk79WjG7Rkx54kg9qb51RXs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hav4itxGpQPiqEzCkrwY2uO+0Rhv058zUfpmUN1f910h3WNHBmytY3V9w5ogEU2SgWgWmTJRqLpvvqfVxMACnUDhKrR9AYHrFX4kDpBpiw8MACT6fmtfy7XaMqJf9+TeodtRWRd9jond+jjGiSvJ10CShR7EKT7K7QPIZOEkg7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=f+00Mo7W; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="f+00Mo7W" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3f675d848c4so600235b6e.1 for ; Thu, 06 Mar 2025 12:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1741292461; x=1741897261; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=276ofz5QkzEct3fd4rq+WUas8/anCxqWq357qm3rDLU=; b=f+00Mo7W6Nff/Ki/NcpGT4mvojCKXjJoys9W7zxF3WJnUergknZOaNXLRgN36WWXJQ cmBbqlwsWU0aY406iMubLKUfHzfuQi/xlORmMzpFWEIgeCD78fcpxyq4Xl+QzzOqki2U yxgr7B4Ecy3vrQ9ZKr6C+/Nvo+pf6EGmafvF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741292461; x=1741897261; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=276ofz5QkzEct3fd4rq+WUas8/anCxqWq357qm3rDLU=; b=Ujtohi6QP9HjmmWCk/U9+K4U0x/1972aOYCixd4exbIhwcFr/CXVkO9n2fQjTzvQHU yJuYgK1ecc7eUUhasZIgC//MuWD15P+Vpdg/IdALaixbeimuCtqmU3QZ7YcqePuM1+BL kplpU6lBibRMaeTs8EMLX8M+27820ns1FvVIgzlLcumzzxt0HhD6ykSdLWu8dJrj/Ta8 DPmQpkGgGvTDeoo2Ql4a7fxcd/0ekw7IdAsqKHQSMvTkPXdBjfRNtP1zUCIj4XTwwxah qqSI1FGop9SNok60UsjjvsjjRJaToWN4WVG22qvrApRk+l0SQ9mgqYeBTwqY+lBMSdVK hDcA== X-Forwarded-Encrypted: i=1; AJvYcCX6RQQO1JR/cRwsC0/1o2b2LYlit/HnAcyOD/0v6UftalVfCrPRXN82bcFt9rcKVecmEDmmbHk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1xKdueJdPHKgRhq4yH3m7PvWlOpkqTS+j60Fp+p4NfEDWw5KR YaPBNJnW0QmzbSeYbsXhxkCAks1LuB3paW+QK23b8V9ETte+it44TrNJqsPL8w== X-Gm-Gg: ASbGnctodBjrckAIYezGExOuCv5n0qUwFX1ZBm46U8LpyBtQwyBaXBsiE23jnRkEp1g oDE3XwSBSRR6Yecbu7GNIAuWEMyOTpSJ/0PiQ5MYTnRxvkpHAZCoAhMMIJJXdirjOX3hfH19F2o 4GW+lSjgsYn2Zg/d81sFLJN076cmwxLrQQKsd6HZ4wibVvvL/GQi1nG0CWk1NlZDXxLiZhLnocq SM1s0KHkxudfq3cZXKSNWLs3djq8Tz/Sb5jftxohE68qLG0rw1Kh/dQW+L+UrtSfTC+UbrGSCiw YmkVfTZ8CNDRT29xITv+JsxN3PqUSz+TLZCUNS/fw6RzTqZzGPwSd1iZsaRMvUxPJANZYP2ZjiF mHNEGeY1p X-Google-Smtp-Source: AGHT+IHu5jh5ZvZHOtzln4TyIJ0dT6XeBQJu4aAru7AFcCyArky93rH1XQeisVhcmjrEQ0BeM9mG/A== X-Received: by 2002:a05:6808:320a:b0:3f6:7782:b5c8 with SMTP id 5614622812f47-3f697b3a28dmr580254b6e.4.1741292461393; Thu, 06 Mar 2025 12:21:01 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f68efbcf0bsm388329b6e.14.2025.03.06.12.20.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 12:20:58 -0800 (PST) Message-ID: <8fae919c-a88a-40ea-a6ce-c34c12892adb@broadcom.com> Date: Thu, 6 Mar 2025 12:20:55 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/14] net: bcmgenet: consolidate dma initialization To: Doug Berger , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Broadcom internal kernel review list , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250306192643.2383632-1-opendmb@gmail.com> <20250306192643.2383632-10-opendmb@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250306192643.2383632-10-opendmb@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/25 11:26, Doug Berger wrote: > The functions bcmgenet_dma_disable and bcmgenet_enable_dma are > only used as part of dma initialization. Their functionality is > moved inside bcmgenet_init_dma and the functions are removed. > > Since the dma is always disabled inside of bcmgenet_init_dma, > the initialization functions bcmgenet_init_rx_queues and > bcmgenet_init_tx_queues no longer need to attempt to manage its > state. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian