From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
Cc: kaara.satwik@chelsio.com
Subject: Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close
Date: Thu, 17 Sep 2020 13:46:24 +0100 [thread overview]
Message-ID: <8fb4bbbf-9bbd-b3e0-b96b-aae6647fe211@intel.com> (raw)
In-Reply-To: <ceb95db6242808b5f5e568a0da60c91a3bc2d9a6.1598979347.git.rahul.lakkireddy@chelsio.com>
On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote:
> Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports
> enumerated under the PF. Free up the underlying port Virtual
> Identifier (VI) and associated resources during port close.
> Once all the ports under the PF are closed, free up the PF-wide
> shared resources. Invoke port close function of all ports under
> the PF, in PCI remove too.
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
<...>
> @@ -1204,11 +1222,13 @@ static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev)
>
> static int eth_cxgbe_dev_uninit(struct rte_eth_dev *eth_dev)
> {
> - struct port_info *pi = eth_dev->data->dev_private;
> - struct adapter *adap = pi->adapter;
> + struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> + uint16_t port_id;
>
> /* Free up other ports and all resources */
> - cxgbe_close(adap);
> + RTE_ETH_FOREACH_DEV_OF(port_id, &pci_dev->device)
> + rte_eth_dev_close(port_id);
Is there a reason to call the ethdev wrapper API here? Why not calling
'cxgbe_dev_close()' directly?
next prev parent reply other threads:[~2020-09-17 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 17:16 [dpdk-dev] [PATCH 0/2] net/cxgbe: release port resources during port close Rahul Lakkireddy
2020-09-01 17:16 ` [dpdk-dev] [PATCH 1/2] net/cxgbe: fix queue DMA ring leaks " Rahul Lakkireddy
2020-09-01 17:16 ` [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources " Rahul Lakkireddy
2020-09-17 12:46 ` Ferruh Yigit [this message]
2020-09-18 13:18 ` Rahul Lakkireddy
2020-09-18 14:38 ` Ferruh Yigit
2020-09-18 14:57 ` [dpdk-dev] [PATCH 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fb4bbbf-9bbd-b3e0-b96b-aae6647fe211@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=kaara.satwik@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.