All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 4/5] ap: add StartWithConfig DBus method
Date: Fri, 30 Oct 2020 11:42:57 -0700	[thread overview]
Message-ID: <8fb55576de7b78c4a738e11923f8edd6765909ce.camel@gmail.com> (raw)
In-Reply-To: <a15dfd36-254e-08d8-bf7c-9554b26409d8@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

Hi Denis,

> 
> > +	config = l_queue_find(ap_configs, match_ssid, ssid);
> > +	if (!config)
> > +		return dbus_error_not_found(message);
> 
> Question, why store the profiles in a list when you could simply try
> and load 
> the profile here?  Then you wouldn't really need to distinguish
> between 
> filesystem and non-filesystem based ap_configs.

Yes I like this much better. This would also allow the configs to be
changed while IWD was running as long as the AP is stopped.

> 
> > +
> > +	ap_if->ap = ap_start(ap_if->netdev, config, &ap_dbus_ops, &err,
> > ap_if);
> > +	if (!ap_if->ap)
> > +		return dbus_error_from_errno(err, message);
> > +
> > +	ap_if->pending = l_dbus_message_ref(message);
> > +	return NULL;
> > +}
> > +
> >   static bool ap_dbus_property_get_started(struct l_dbus *dbus,
> >   					struct l_dbus_message *message,
> >   					struct l_dbus_message_builder
> > *builder,
> > @@ -2729,6 +2767,9 @@ static void ap_setup_interface(struct
> > l_dbus_interface *interface)
> >   	l_dbus_interface_method(interface, "Start", 0, ap_dbus_start,
> > "",
> >   			"ss", "ssid", "wpa2_passphrase");
> >   	l_dbus_interface_method(interface, "Stop", 0, ap_dbus_stop, "",
> > "");
> > +	l_dbus_interface_method(interface, "StartWithConfig", 0,
> 
> Lets try to avoid shortened words in the API.  StartWithConfiguration
> or 
> StartProfile would be better.

Sure, StartProfile it is.

> 
> > +					ap_dbus_start_with_config, "",
> > "s",
> > +					"ssid");
> >   
> >   	l_dbus_interface_property(interface, "Started", 0, "b",
> >   					ap_dbus_property_get_started,
> > NULL);
> > 
> 
> Regards,
> -Denis

  reply	other threads:[~2020-10-30 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 16:34 [PATCH 1/5] storage: add storage_network_filename_from_path James Prestwood
2020-10-30 16:34 ` [PATCH 2/5] storage: add storage_get_ap_path James Prestwood
2020-10-30 18:41   ` Denis Kenzior
2020-10-30 18:48     ` James Prestwood
2020-10-30 16:34 ` [PATCH 3/5] ap: add provisioning file parsing James Prestwood
2020-10-30 16:34 ` [PATCH 4/5] ap: add StartWithConfig DBus method James Prestwood
2020-10-30 18:37   ` Denis Kenzior
2020-10-30 18:42     ` James Prestwood [this message]
2020-10-30 16:34 ` [PATCH 5/5] ap: allow DHCP settings in provisioning files James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fb55576de7b78c4a738e11923f8edd6765909ce.camel@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.