From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1C030FF23; Mon, 17 Nov 2025 06:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763361741; cv=none; b=c/c1lmAvc1PZ2Fk0Hcr1LFXNvpI9cAMALfsQdI88gLhYWKaztFgSPR8+YmXC3OLECERdRo0aMcCT16lqeZr00V0l7w3WI282uORK33eatCdN57kygALB1nBP27R08d6wzu4Yq1idudF62ep3LK7JU5+Ee8y3hT5kHpBDgLMTt4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763361741; c=relaxed/simple; bh=hWqNY7muDzX4eHDWmSxYlqHlAWmhyiLq5vYJBTcMrpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B2/tuvF2uDhJqH1QxDaZYRGeSBPF0y0oR0k9xVpM5MrKKr7I3utUbOHj52RfTMFxETtZBTlbUylb7SQx3qz+uI+1eWZvOsz1ZUZE/synZqHcKF+/lYLm+8d35CLUoe6a58SK7a4dTym/nQB3rAOb/zRZqet8Be+bKO7qhFoOJ7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LXkvl6fW; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LXkvl6fW" Message-ID: <8fbeb3e8-7c30-46f6-a0a4-289efbf45ac0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763361727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F61/44VrimXOAEuXiMeNmI+aj0JYokmyCnACi/yOoLA=; b=LXkvl6fWXks2EBeWBZhRCeAyF3ikTcHZiBnXiOf/E69BeQQS14g5s1Z7/bB8YxlQXeJX97 ZSrM63UX77TU+weQcxR68BHoTI37uR0exm53LyIVRGyINLRhjXjK25ABUedOBpfn59DJNX OX6fbBjMivdCT5ijsyT8t8ax4mXTWFY= Date: Mon, 17 Nov 2025 14:41:10 +0800 Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 3/7] loongarch: mm: enable MMU_GATHER_RCU_TABLE_FREE To: Huacai Chen Cc: will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, dev.jain@arm.com, akpm@linux-foundation.org, david@redhat.com, ioworker0@gmail.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Qi Zheng , WANG Xuerui References: <146b5a0207052b38d04caac6b20756a61c2189b3.1763117269.git.zhengqi.arch@bytedance.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi Huacai, On 11/14/25 10:17 PM, Huacai Chen wrote: > Hi, Qi Zheng, [...] >> >> -#define __pmd_free_tlb(tlb, x, addr) pmd_free((tlb)->mm, x) >> +#define __pmd_free_tlb(tlb, x, addr) \ >> + tlb_remove_ptdesc((tlb), virt_to_ptdesc(x)) > I think we can define it in one line. Do we need to change __pte_free_tlb() to a single-line format as well? Thanks, Qi >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED058CEACEF for ; Mon, 17 Nov 2025 06:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i5rfjQWRz8DMMDstDRRfIhTQPqUkdNe93V34qiNrwho=; b=3nXwfcmrxGnZZ/ 8F06cX9qrUUceEyp6/IpQHujRCHtECbZGp9JQTx0Uvc4dR+92nD35m79OT9KwZ6NEB2b1FYIlElEt SwUvDxllB8MOF+lS5jJ3ojHdhkOXF/cSyuRpKTCZDEtDZcpYyEW27OLX1vXSooyHf2Hl43hIkltH5 lOpjlYGi83ZKQeBkMBsm86iik26uwXDgdFbOXo2dunkTA22AURuKTB6TVwqwrz0i/7SDyK5p2/V0b 7tp14aGGswiWeZs2gCajxWi2M4VbFjWkVPdmSFeh/Avw7p7gyLumgwhEZJKqTLszPJyPh85Y6UrwZ yZA544Tjx3fgIfnYiLYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vKswe-0000000FWzJ-2x6l; Mon, 17 Nov 2025 06:42:36 +0000 Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vKswb-0000000FWy1-2IHE for linux-snps-arc@lists.infradead.org; Mon, 17 Nov 2025 06:42:34 +0000 Message-ID: <8fbeb3e8-7c30-46f6-a0a4-289efbf45ac0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763361727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F61/44VrimXOAEuXiMeNmI+aj0JYokmyCnACi/yOoLA=; b=LXkvl6fWXks2EBeWBZhRCeAyF3ikTcHZiBnXiOf/E69BeQQS14g5s1Z7/bB8YxlQXeJX97 ZSrM63UX77TU+weQcxR68BHoTI37uR0exm53LyIVRGyINLRhjXjK25ABUedOBpfn59DJNX OX6fbBjMivdCT5ijsyT8t8ax4mXTWFY= Date: Mon, 17 Nov 2025 14:41:10 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 3/7] loongarch: mm: enable MMU_GATHER_RCU_TABLE_FREE To: Huacai Chen Cc: will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, dev.jain@arm.com, akpm@linux-foundation.org, david@redhat.com, ioworker0@gmail.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Qi Zheng , WANG Xuerui References: <146b5a0207052b38d04caac6b20756a61c2189b3.1763117269.git.zhengqi.arch@bytedance.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251116_224233_753579_BA678D2F X-CRM114-Status: UNSURE ( 4.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Hi Huacai, On 11/14/25 10:17 PM, Huacai Chen wrote: > Hi, Qi Zheng, [...] >> >> -#define __pmd_free_tlb(tlb, x, addr) pmd_free((tlb)->mm, x) >> +#define __pmd_free_tlb(tlb, x, addr) \ >> + tlb_remove_ptdesc((tlb), virt_to_ptdesc(x)) > I think we can define it in one line. Do we need to change __pte_free_tlb() to a single-line format as well? Thanks, Qi >> _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc