From: Bart Van Assche <bvanassche@acm.org>
To: Animesh Rai <animeshrai853@gmail.com>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@sandisk.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufshcd: use str_enabled_disabled() for Write Booster messages
Date: Mon, 6 Jul 2026 07:10:38 -0700 [thread overview]
Message-ID: <8fc64eb4-d4bf-4231-ae0f-2db357b58a0e@acm.org> (raw)
In-Reply-To: <20260701175152.7446-1-animeshrai853@gmail.com>
On 7/1/26 10:51 AM, Animesh Rai wrote:
> Replace open-coded ternary expressions of the form
> enable ? "enabled" : "disabled"
> with the str_enabled_disabled() helper from <linux/string_choices.h>.
>
> This reduces code duplication and allows the linker to deduplicate the
> constant strings across the kernel image.
This patch doesn't look like an improvement to me. I don't think that we
need this patch.
Bart.
prev parent reply other threads:[~2026-07-06 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 17:51 [PATCH] scsi: ufs: ufshcd: use str_enabled_disabled() for Write Booster messages Animesh Rai
2026-07-06 14:10 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc64eb4-d4bf-4231-ae0f-2db357b58a0e@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=animeshrai853@gmail.com \
--cc=avri.altman@sandisk.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.