From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "ming.lei@redhat.com" <ming.lei@redhat.com>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
"jiangguoqing@kylinos.cn" <jiangguoqing@kylinos.cn>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH 0/4] blk-lib: cleanup bdev_get_queue()
Date: Mon, 14 Feb 2022 06:45:47 -0700 [thread overview]
Message-ID: <8fe8553e-d9b0-bcbf-f332-55dbf1985358@kernel.dk> (raw)
In-Reply-To: <5e12a394-031f-51f6-a5f1-39f8d0ee369c@nvidia.com>
On 2/14/22 3:19 AM, Chaitanya Kulkarni wrote:
> On 2/14/22 2:08 AM, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> Based on the comment in the include/linux/blkdev.h:bdev_get_queue()
>> the return value of the function will never be NULL. This patch series
>> removes those checks present in the blk-lib.c, also removes the not
>> needed local variable pointer to request_queue from the write_zeroes
>> helpers.
>>
>> Below is the test log for discard (__blkdev_issue_disacrd()) and
>> write-zeroes (__blkdev_issue_write_zeroes/__blkdev_issue_zero_pages()).
>>
>> -ck
>>
>
> This clashes with Christoph's write same cleanup. I'll resend this
> once that is in the linux-block tree, meanwhile any comments on
> discard, write-zeroes and zero-pages patches are welcome.
Please just collapse those patches into 1. Right now it's 4 patches
with identical titles, that's very confusing.
--
Jens Axboe
prev parent reply other threads:[~2022-02-14 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 10:08 [PATCH 0/4] blk-lib: cleanup bdev_get_queue() Chaitanya Kulkarni
2022-02-14 10:08 ` [PATCH 1/4] blk-lib: don't check bdev_get_queue() NULL check Chaitanya Kulkarni
2022-02-14 10:08 ` [PATCH 2/4] " Chaitanya Kulkarni
2022-02-14 10:08 ` [PATCH 3/4] " Chaitanya Kulkarni
2022-02-14 10:08 ` [PATCH 4/4] " Chaitanya Kulkarni
2022-02-14 10:19 ` [PATCH 0/4] blk-lib: cleanup bdev_get_queue() Chaitanya Kulkarni
2022-02-14 13:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe8553e-d9b0-bcbf-f332-55dbf1985358@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=damien.lemoal@wdc.com \
--cc=jiangguoqing@kylinos.cn \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.