From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbdJEVQA (ORCPT ); Thu, 5 Oct 2017 17:16:00 -0400 Received: from exactco.de ([144.76.154.42]:54796 "EHLO exactco.de" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751766AbdJEVP6 (ORCPT ); Thu, 5 Oct 2017 17:15:58 -0400 Subject: Re: [PREVIEW] Add x86 zstd kernel compression To: Nick Terrell Cc: linux-kernel@vger.kernel.org References: <76B54446-B110-4CF0-BCA0-3AB94B44AFD3@exactcode.com> <20171005192248.640495-1-terrelln@fb.com> From: =?UTF-8?Q?Ren=c3=a9_Rebe?= Message-ID: <8feb92b2-6dcd-6199-0d74-ecbda1472410@exactcode.com> Date: Thu, 5 Oct 2017 23:15:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171005192248.640495-1-terrelln@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.8 (/) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/05/2017 09:22 PM, Nick Terrell wrote: > On 10/5/17, 1:18 AM, "René Rebe" wrote: >> >> Hi Nick, >> >> On Oct 5, 2017, at 1:29, Nick Terrell wrote: >> >>> On 10/4/17, 3:01 AM, "linux-kernel-owner@vger.kernel.org on behalf of René Rebe" wrote: >>>> Hi, >>>> >>>> I noticed zstd compression was recently added for btrfs and squashfs. >>>> Are there actually already patches floating around for zstd kernel and intird compression? >>>> Looks like that would be a quite nice fit regarding speed and compression ratio, … >>>> >>>> Regards, >>>> René >>> >>> I started working on some patches yesterday, and just got zstd kernel, >>> initrd, and initramfs compression working today. I think I'll be ready to >>> send the patches out within a week. >> >> awesome, if you have something to test I could give it a try on my test bench, too. > > Here is a preview of the patch, though its not quite ready. > I believe it works, but I still need to clean it up a bit, and split it > into the decompression function, the initrd piece, and the x86 specific > piece. I'll try to get the patch set out this week, and I'll CC you. thanks for the preview, which I applied cleanly, modulo this white-space chunk: diff --git a/lib/Kconfig b/lib/Kconfig index b1445b2..02fdcac 100644 @@ -296,7 +300,7 @@ config GENERIC_ALLOCATOR # config REED_SOLOMON tristate - + config REED_SOLOMON_ENC8 bool to the 4.14-rc2 tarball and it compiled and booted on x86-64, including a zstd initrd! Great work, will probably start testing it on my personal laptop, to use the same compression everywhere. Regards, René -- René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10117 Berlin http://exactcode.com | http://t2-project.org | http://rene.rebe.de