From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: test11-pre5
Date: 14 Nov 2000 15:51:50 -0800 [thread overview]
Message-ID: <8usj6m$10i$1@penguin.transmeta.com> (raw)
In-Reply-To: <3A11C1B6.E61FF9F6@mandrakesoft.com> <Pine.LNX.4.21.0011150104250.26856-100000@callisto.yi.org>
In article <Pine.LNX.4.21.0011150104250.26856-100000@callisto.yi.org>,
Dan Aloni <karrde@callisto.yi.org> wrote:
>On Tue, 14 Nov 2000, Jeff Garzik wrote:
>
>> Dan Aloni wrote:
>> >
>> > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
>> > net_init.c:register_netdev(&dev_3c501), which calls strchr(),
>> > {and might also,which might} dereference dev_3c501.name.
>>
>> There is no dereferencing involved, and therefore no problem.
>
>Well, at least I was alertive. Almost a bug fix ;-)
>Is there a special reason why dev->name is not a pointer?
It used to be.
And we used to have an incredible number of bugs with initialization and
with creating these things dynamically. A lot of Space.c was due to
horrible hackery with getting the static allocation right for these
things. Turning it into a plain array got rid of all the hackery, and
saved memory anyway.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-15 0:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-14 21:47 test11-pre5 Linus Torvalds
2000-11-14 22:45 ` [PATCH] test11-pre5 Dan Aloni
2000-11-14 22:50 ` Jeff Garzik
2000-11-14 23:10 ` Dan Aloni
2000-11-14 23:14 ` Jeff Garzik
2000-11-14 23:51 ` Linus Torvalds [this message]
2000-11-16 8:51 ` Nick Holloway
2000-11-14 23:47 ` Linus Torvalds
2000-11-15 0:25 ` Dan Aloni
2000-11-15 0:25 ` David S. Miller
2000-11-15 0:59 ` Dan Aloni
2000-11-15 0:49 ` David S. Miller
2000-11-14 22:47 ` test11-pre5 Jes Sorensen
2000-11-14 23:08 ` [uPATCH] test11-pre5 Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='8usj6m$10i$1@penguin.transmeta.com' \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.