From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver Date: Tue, 22 Feb 2011 16:17:20 -0800 Message-ID: <8ya62sbli3z.fsf@huya.qualcomm.com> References: <1297989299-27320-1-git-send-email-kheitke@codeaurora.org> <1297989432.9680.50.camel@c-dwalke-linux.qualcomm.com> <4D5DC289.1090004@codeaurora.org> <1298054771.17758.1.camel@c-dwalke-linux.qualcomm.com> <1298419839.17118.5.camel@m0nster> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:36230 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526Ab1BWARV (ORCPT ); Tue, 22 Feb 2011 19:17:21 -0500 In-Reply-To: <1298419839.17118.5.camel@m0nster> (Daniel Walker's message of "Tue, 22 Feb 2011 16:10:39 -0800") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Daniel Walker Cc: Dima Zavin , Bryan Huntsman , Kenneth Heitke , Pavel Machek , tsoni@codeaurora.org, linux-arm-msm@vger.kernel.org, ARM PORT , open list On Tue, Feb 22 2011, Daniel Walker wrote: > On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote: > >> What is the problem leaving it under arch/arm/mach-msm? > > Because it's a driver. There are a lot of other drivers currently under various arch subsystems. I'm not sure if a driver that is specific to only one arch has a strong reason to be elsewhere in the kernel. If there was a possibility of there being other devices that used SSBI, it might make sense to put it elsewhere. But, as far as I know, this device is only found on MSM chips. It seems kind of unusual to create an entirely new directory under drivers to hold what will only ever be a single driver. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davidb@codeaurora.org (David Brown) Date: Tue, 22 Feb 2011 16:17:20 -0800 Subject: [PATCH] msm: add single-wire serial bus interface (SSBI) driver In-Reply-To: <1298419839.17118.5.camel@m0nster> (Daniel Walker's message of "Tue, 22 Feb 2011 16:10:39 -0800") References: <1297989299-27320-1-git-send-email-kheitke@codeaurora.org> <1297989432.9680.50.camel@c-dwalke-linux.qualcomm.com> <4D5DC289.1090004@codeaurora.org> <1298054771.17758.1.camel@c-dwalke-linux.qualcomm.com> <1298419839.17118.5.camel@m0nster> Message-ID: <8ya62sbli3z.fsf@huya.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 22 2011, Daniel Walker wrote: > On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote: > >> What is the problem leaving it under arch/arm/mach-msm? > > Because it's a driver. There are a lot of other drivers currently under various arch subsystems. I'm not sure if a driver that is specific to only one arch has a strong reason to be elsewhere in the kernel. If there was a possibility of there being other devices that used SSBI, it might make sense to put it elsewhere. But, as far as I know, this device is only found on MSM chips. It seems kind of unusual to create an entirely new directory under drivers to hold what will only ever be a single driver. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.