From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets Date: Fri, 11 Feb 2011 14:37:18 -0800 Message-ID: <8ya7hd6kxk1.fsf@huya.qualcomm.com> References: <1297456098-3241-1-git-send-email-stepanm@codeaurora.org> <1297456098-3241-2-git-send-email-stepanm@codeaurora.org> <1297462350.4852.31.camel@m0nster> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:11458 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758338Ab1BKWhT (ORCPT ); Fri, 11 Feb 2011 17:37:19 -0500 In-Reply-To: <1297462350.4852.31.camel@m0nster> (Daniel Walker's message of "Fri, 11 Feb 2011 14:12:30 -0800") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Daniel Walker Cc: Stepan Moskovchenko , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Fri, Feb 11 2011, Daniel Walker wrote: > On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: >> Make the IOMMU platform data target-independent in >> preparation for adding MSM8960 IOMMU support. The IOMMU >> configuration on MSM8x60 and MSM8960 is identical and the >> same platform data can be used for both. >> >> Signed-off-by: Stepan Moskovchenko >> --- >> arch/arm/mach-msm/Makefile | 4 +- >> .../{devices-msm8x60-iommu.c => devices-iommu.c} | 54 +++++++++---------- >> arch/arm/mach-msm/include/mach/msm_iomap-8x60.h | 36 ------------- >> 3 files changed, 28 insertions(+), 66 deletions(-) >> rename arch/arm/mach-msm/{devices-msm8x60-iommu.c => devices-iommu.c} (93%) > > If it's like what you and David are suggesting I think you would need a > SoC designation in the filename .. It is functionality that will be shared across multiple socs. Putting the name of a specific soc would just be misleading. Currently, it's our only iommu. Support for another family that uses a different iommu could perhaps call it iommu2. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davidb@codeaurora.org (David Brown) Date: Fri, 11 Feb 2011 14:37:18 -0800 Subject: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets In-Reply-To: <1297462350.4852.31.camel@m0nster> (Daniel Walker's message of "Fri, 11 Feb 2011 14:12:30 -0800") References: <1297456098-3241-1-git-send-email-stepanm@codeaurora.org> <1297456098-3241-2-git-send-email-stepanm@codeaurora.org> <1297462350.4852.31.camel@m0nster> Message-ID: <8ya7hd6kxk1.fsf@huya.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 11 2011, Daniel Walker wrote: > On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: >> Make the IOMMU platform data target-independent in >> preparation for adding MSM8960 IOMMU support. The IOMMU >> configuration on MSM8x60 and MSM8960 is identical and the >> same platform data can be used for both. >> >> Signed-off-by: Stepan Moskovchenko >> --- >> arch/arm/mach-msm/Makefile | 4 +- >> .../{devices-msm8x60-iommu.c => devices-iommu.c} | 54 +++++++++---------- >> arch/arm/mach-msm/include/mach/msm_iomap-8x60.h | 36 ------------- >> 3 files changed, 28 insertions(+), 66 deletions(-) >> rename arch/arm/mach-msm/{devices-msm8x60-iommu.c => devices-iommu.c} (93%) > > If it's like what you and David are suggesting I think you would need a > SoC designation in the filename .. It is functionality that will be shared across multiple socs. Putting the name of a specific soc would just be misleading. Currently, it's our only iommu. Support for another family that uses a different iommu could perhaps call it iommu2. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.