From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init Date: Fri, 25 Jan 2013 10:16:31 -0800 Message-ID: <8yak3r15ds0.fsf@huya.qualcomm.com> References: <1359123276-15833-1-git-send-email-arnd@arndb.de> <1359123276-15833-4-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:64501 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778Ab3AYSQb (ORCPT ); Fri, 25 Jan 2013 13:16:31 -0500 In-Reply-To: <1359123276-15833-4-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 25 Jan 2013 14:14:20 +0000") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@list.infradead.org, linux-kernel@vger.kernel.org, Bryan Huntsman , Daniel Walker , linux-arm-msm@vger.kernel.org Arnd Bergmann writes: > msm_smd_probe is a driver probe function and may get > called after the __init time, so it must not call > any __init function, as the link-time warning reports. > Take away the __init annotation on proc_comm_boot_wait > to fix this. > > Without this patch, building msm_defconfig results in: > > WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() > The function msm_smd_probe() references > the function __init proc_comm_boot_wait(). > This is often because msm_smd_probe lacks a __init > annotation or the annotation of proc_comm_boot_wait is wrong. > > Signed-off-by: Arnd Bergmann > Cc: David Brown > Cc: Bryan Huntsman > Cc: Daniel Walker > Cc: linux-arm-msm@vger.kernel.org > --- > arch/arm/mach-msm/proc_comm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Arnd, you're welcome to pull this into your tree: Acked-by: David Brown I don't forsee any conflicts with upcoming patches. David -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation