From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code. Date: Wed, 23 Mar 2011 15:47:15 -0700 Message-ID: <8yay6455ua4.fsf@huya.qualcomm.com> References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485423-27281-1-git-send-email-carlv@codeaurora.org> <1300885912.6117.16.camel@m0nster> <4D8A5B44.9050306@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:12387 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932785Ab1CWWqg (ORCPT ); Wed, 23 Mar 2011 18:46:36 -0400 In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Carl Vanderlip Cc: Daniel Walker , Russell King , Bryan Huntsman , Brian Swetland , Dima Zavin , Rebecca Schultz Zavin , Colin Cross , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Mar 23 2011, Carl Vanderlip wrote: > On 03/23/2011 06:11 AM, Daniel Walker wrote: >> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote: >>> index df9d74e..d6e75c3 100644 >>> --- a/arch/arm/mach-msm/Kconfig >>> +++ b/arch/arm/mach-msm/Kconfig >>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS >>> config MSM_VIC >>> bool >>> >>> +config MSM_MDP22 >>> + bool >>> + depends on ARCH_MSM7X00A >>> + default y >>> + >> You should remove the "default y" and this should be moved to a Kconfig >> under video (shouldn't be added into mach-msm). >> >> Daniel >> > What about removing the 'depends on' and 'default y' and making it be > selected by MSM7X00A? But why should the feature be in the Kconfig for arch/arm/mach-msm when the driver is under drivers/video/msm? If it does indeed need configuration, why not put a Kconfig under drivers/video/msm? The last patch does select this, so it shouldn't need to get a default. Does the code work if both MDP22 and MDP31 are defined? Eventually, it will be possible to enable multiple SOCs, so this driver will need to be able to handle that determination at run-time. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Date: Wed, 23 Mar 2011 22:47:15 +0000 Subject: Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code. Message-Id: <8yay6455ua4.fsf@huya.qualcomm.com> List-Id: References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485423-27281-1-git-send-email-carlv@codeaurora.org> <1300885912.6117.16.camel@m0nster> <4D8A5B44.9050306@codeaurora.org> In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, Mar 23 2011, Carl Vanderlip wrote: > On 03/23/2011 06:11 AM, Daniel Walker wrote: >> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote: >>> index df9d74e..d6e75c3 100644 >>> --- a/arch/arm/mach-msm/Kconfig >>> +++ b/arch/arm/mach-msm/Kconfig >>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS >>> config MSM_VIC >>> bool >>> >>> +config MSM_MDP22 >>> + bool >>> + depends on ARCH_MSM7X00A >>> + default y >>> + >> You should remove the "default y" and this should be moved to a Kconfig >> under video (shouldn't be added into mach-msm). >> >> Daniel >> > What about removing the 'depends on' and 'default y' and making it be > selected by MSM7X00A? But why should the feature be in the Kconfig for arch/arm/mach-msm when the driver is under drivers/video/msm? If it does indeed need configuration, why not put a Kconfig under drivers/video/msm? The last patch does select this, so it shouldn't need to get a default. Does the code work if both MDP22 and MDP31 are defined? Eventually, it will be possible to enable multiple SOCs, so this driver will need to be able to handle that determination at run-time. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davidb@codeaurora.org (David Brown) Date: Wed, 23 Mar 2011 15:47:15 -0700 Subject: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code. In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700") References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485423-27281-1-git-send-email-carlv@codeaurora.org> <1300885912.6117.16.camel@m0nster> <4D8A5B44.9050306@codeaurora.org> Message-ID: <8yay6455ua4.fsf@huya.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 23 2011, Carl Vanderlip wrote: > On 03/23/2011 06:11 AM, Daniel Walker wrote: >> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote: >>> index df9d74e..d6e75c3 100644 >>> --- a/arch/arm/mach-msm/Kconfig >>> +++ b/arch/arm/mach-msm/Kconfig >>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS >>> config MSM_VIC >>> bool >>> >>> +config MSM_MDP22 >>> + bool >>> + depends on ARCH_MSM7X00A >>> + default y >>> + >> You should remove the "default y" and this should be moved to a Kconfig >> under video (shouldn't be added into mach-msm). >> >> Daniel >> > What about removing the 'depends on' and 'default y' and making it be > selected by MSM7X00A? But why should the feature be in the Kconfig for arch/arm/mach-msm when the driver is under drivers/video/msm? If it does indeed need configuration, why not put a Kconfig under drivers/video/msm? The last patch does select this, so it shouldn't need to get a default. Does the code work if both MDP22 and MDP31 are defined? Eventually, it will be possible to enable multiple SOCs, so this driver will need to be able to handle that determination at run-time. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.