From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update Date: Wed, 14 Dec 2016 11:10:09 +0200 Message-ID: <9003662.GMTnJkJbn3@avalon> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <8209536.SBuD0B7HP3@avalon> <4c863692-d6d4-3940-b78e-3e7b9d114cad@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4c863692-d6d4-3940-b78e-3e7b9d114cad@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Aaro Koskinen , Tony Lindgren , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sebastian Reichel , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org SGkgVG9taSwKCk9uIFdlZG5lc2RheSAxNCBEZWMgMjAxNiAxMDo0MzoxOCBUb21pIFZhbGtlaW5l biB3cm90ZToKPiBPbiAxMy8xMi8xNiAxOTozNSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+ IE9uIFR1ZXNkYXkgMDggTWFyIDIwMTYgMTc6Mzk6NDQgU2ViYXN0aWFuIFJlaWNoZWwgd3JvdGU6 Cj4gPj4gVGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIGEgaGFyZHdhcmUgYnVnIG9jY3VyaW5nCj4g Pj4gb24gT01BUDMgd2l0aCBtYW51YWxseSB1cGRhdGVkIHBhbmVscy4KPiA+IAo+ID4gQ291bGQg eW91IHBsZWFzZSBleHBsYWluIHdoYXQgdGhlIGJ1ZyBpcyBhbmQgaG93IHRoZSB3b3JrYXJvdW5k IG9wZXJhdGVzID8KPiA+IERvIHlvdSBoYXZlIGEgcmVmZXJlbmNlIHRvIGFuIGVycmF0YSBkb2N1 bWVudCA/Cj4gCj4gSSBkb24ndCB0aGluayBJIGV2ZXIgZm91bmQgb3V0IGV4YWN0bHkgd2h5IHRo ZSBwcm9ibGVtIGhhcHBlbnMuIEJ1dCBvbgo+IE9NQVAzIERTSSwgdGhlIGZpZm8gdGhyZXNob2xk cyBoYWQgdG8gYmUgdHVuZWQgc2xpZ2h0bHksIG90aGVyd2lzZSBESVNQQwo+IHdvdWxkIHN0b3Au IGRpc3BjX292bF9jb21wdXRlX2ZpZm9fdGhyZXNob2xkcygpIGRvZXMgdGhhdCB0dW5pbmcgaWYK PiAibWFudWFsX3VwZGF0ZSIgcGFyYW1ldGVyIGlzIHNldCBvbiBPTUFQMy4KCkkndmUgaGFkIGEg bG9vayBhdCBkaXNwY19vdmxfY29tcHV0ZV9maWZvX3RocmVzaG9sZHMoKSBhbmQgdGhlIHBhdGNo IG1ha2VzIApzZW5zZSB0byBtZS4gSWYgU2ViYXN0aWFuIGNvdWxkIGFkZHJlc3MgdGhlIHNtYWxs IGlzc3VlcyBJIHBvaW50ZWQgb3V0LCB3ZSAKY291bGQgdGhlbiBtZXJnZSB0aGlzLiBBbHRlcm5h dGl2ZWx5IEkgY2FuIHRha2UgY2FyZSBvZiBhZGRyZXNzaW5nIHRoZW0uCgotLSAKUmVnYXJkcywK CkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128AbcLNJJj (ORCPT ); Wed, 14 Dec 2016 04:09:39 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:43399 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754987AbcLNJJg (ORCPT ); Wed, 14 Dec 2016 04:09:36 -0500 From: Laurent Pinchart To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org, Sebastian Reichel , Tony Lindgren , Aaro Koskinen , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update Date: Wed, 14 Dec 2016 11:10:09 +0200 Message-ID: <9003662.GMTnJkJbn3@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <4c863692-d6d4-3940-b78e-3e7b9d114cad@ti.com> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <8209536.SBuD0B7HP3@avalon> <4c863692-d6d4-3940-b78e-3e7b9d114cad@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, On Wednesday 14 Dec 2016 10:43:18 Tomi Valkeinen wrote: > On 13/12/16 19:35, Laurent Pinchart wrote: > > On Tuesday 08 Mar 2016 17:39:44 Sebastian Reichel wrote: > >> This is a workaround for a hardware bug occuring > >> on OMAP3 with manually updated panels. > > > > Could you please explain what the bug is and how the workaround operates ? > > Do you have a reference to an errata document ? > > I don't think I ever found out exactly why the problem happens. But on > OMAP3 DSI, the fifo thresholds had to be tuned slightly, otherwise DISPC > would stop. dispc_ovl_compute_fifo_thresholds() does that tuning if > "manual_update" parameter is set on OMAP3. I've had a look at dispc_ovl_compute_fifo_thresholds() and the patch makes sense to me. If Sebastian could address the small issues I pointed out, we could then merge this. Alternatively I can take care of addressing them. -- Regards, Laurent Pinchart