From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 0/5] eal: simplify devargs and hotplug
	functions
Date: Thu, 11 Oct 2018 14:10:18 +0200
Message-ID: <9014753.JheKqXxJ3f@xps>
References: <20180907222727.20521-1-thomas@monjalon.net>
 <20181007093244.20659-1-thomas@monjalon.net>
 <20181008144509.3c3a5933@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Stephen Hemminger <stephen@networkplumber.org>, gaetan.rivet@6wind.com,
 ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com,
 ktraynor@redhat.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7BC651B3B3
 for <dev@dpdk.org>; Thu, 11 Oct 2018 14:10:22 +0200 (CEST)
In-Reply-To: <20181008144509.3c3a5933@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/10/2018 23:45, Stephen Hemminger:
> On Sun,  7 Oct 2018 11:32:39 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > This is a follow-up of an idea presented at Dublin
> > during the "hotplug talk".
> > 
> > Instead of changing the existing hotplug functions, as in the RFC,
> > some new experimental functions are added.
> > The old functions lose their experimental status in order to provide
> > a non-experimental replacement for deprecated attach/detach functions.
> > 
> > It has been discussed briefly in the latest technical board meeting.
> > 
> > 
> > Changes in v6 - after Gaetan's review:
> >   - bump ABI version of all buses (because of rte_device change)
> >   - unroll snprintf loop in rte_eal_hotplug_add
> > 
> > Changes in v5:
> >   - rte_devargs_remove is fixed in case of null devargs (patch 2)
> >   - a pointer to the bus is added in rte_device (patch 3)
> >   - rte_dev_remove is fixed in case of no devargs (patch 5)
> > 
> > Changes in v4 - after Andrew's review:
> >   - add API changes in release notes (patches 1 & 2)
> >   - fix memory leak in rte_eal_hotplug_add (patch 4)
> > 
> > Change in v3:
> >   - fix null dereferencing in error path (patch 2)
> > 
> > 
> > Thomas Monjalon (5):
> >   devargs: remove deprecated functions
> >   devargs: simplify parameters of removal function
> >   eal: add bus pointer in device structure
> >   eal: remove experimental flag of hotplug functions
> >   eal: simplify parameters of hotplug functions
> 
> I like these changes.
> 
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>

Applied