All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Sinan Kaya <okaya@kernel.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 02/11] net/tap: check if name is null
Date: Mon, 21 Nov 2022 22:41:23 +0100	[thread overview]
Message-ID: <9023252.CDJkKcVGEf@thomas> (raw)
In-Reply-To: <20221121204015.1135573-3-okaya@kernel.org>

21/11/2022 21:40, okaya@kernel.org:
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
>  	struct rte_eth_dev *eth_dev;
>  
>  	name = rte_vdev_device_name(dev);
> +	if (!name) {

Please it is preferred to check against NULL,
because name is not a boolean, thanks.
I know it's longer but it is more explicit.

Thanks for the fixes in this series.




  reply	other threads:[~2022-11-21 21:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 20:40 [PATCH 00/11] codeql fixes for various subsystems okaya
2022-11-21 20:40 ` [PATCH 01/11] ethdev: check return result of rte_eth_dev_info_get okaya
2022-11-21 20:40 ` [PATCH 02/11] net/tap: check if name is null okaya
2022-11-21 21:41   ` Thomas Monjalon [this message]
2022-11-21 22:03     ` Sinan Kaya
2022-11-21 22:57       ` Ferruh Yigit
2022-11-21 20:40 ` [PATCH 03/11] memzone: check result of rte_fbarray_get okaya
2022-11-21 20:40 ` [PATCH 04/11] memzone: check result of malloc_elem_from_data okaya
2022-11-21 20:40 ` [PATCH 05/11] malloc: malloc_elem_join_adjacent_free can return null okaya
2022-11-21 20:40 ` [PATCH 06/11] malloc: check result of rte_mem_virt2memseg_list okaya
2022-11-21 20:40 ` [PATCH 07/11] malloc: check result of rte_fbarray_get okaya
2022-11-21 20:40 ` [PATCH 08/11] malloc: check result of rte_mem_virt2memseg okaya
2022-11-21 20:40 ` [PATCH 09/11] malloc: check result of malloc_elem_free okaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9023252.CDJkKcVGEf@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=okaya@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.