All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Stewart Hildebrand" <stewart.hildebrand@amd.com>,
	"Jürgen Groß" <jgross@suse.com>,
	"Furkan Caliskan" <frn1furkan10@gmail.com>,
	xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	roger.pau@citrix.com, dfaggioli@suse.com, gwd@xenproject.org,
	jbeulich@suse.com
Subject: Re: [PATCH v2] xen/sched: remove stale file path comments in common/sched directory
Date: Thu, 28 May 2026 11:17:20 +0100	[thread overview]
Message-ID: <902cd39c-badb-4194-8cd9-dc2e42d33eb2@citrix.com> (raw)
In-Reply-To: <61fbcf6a-4533-4a1d-ac2a-0c8b2427d27d@amd.com>

On 27/05/2026 8:51 pm, Stewart Hildebrand wrote:
> On 5/26/26 06:09, Jürgen Groß wrote:
>> On 26.05.26 09:52, Furkan Caliskan wrote:
>>> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
>>> dedicated directory") moved the scheduler files from xen/common/ to
>>> xen/common/sched and renamed some of them, but did not update the
>>> in-file path comments at the top of each file.
>>>
>>> Remove the comments rather than updating them, as they are redundant
>>> information already conveyed by the filename itself.
>>>
>>> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Suggested-by: Juergen Gross <jgross@suse.com>
>>> Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> For ARINC 653:
> Acked-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
>
> FYI, we are in the release cycle for 4.22, and I'm not sure this is justified to
> be included in this release. IMO it would be OK to wait for the next cycle.

Bugfixes are still being accepted, and wrong comments are a bug.  I've
taken the patch.

~Andrew


      reply	other threads:[~2026-05-28 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 10:25 [PATCH] xen/sched: fix stale file path comments in common/sched directory Furkan Caliskan
2026-05-25 10:58 ` Roger Pau Monné
2026-05-26  6:18   ` Jürgen Groß
2026-05-26  6:26     ` Furkan Çalışkan
2026-05-26  7:52 ` [PATCH v2] xen/sched: remove " Furkan Caliskan
2026-05-26 10:09   ` Jürgen Groß
2026-05-27 19:51     ` Stewart Hildebrand
2026-05-28 10:17       ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=902cd39c-badb-4194-8cd9-dc2e42d33eb2@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=dfaggioli@suse.com \
    --cc=frn1furkan10@gmail.com \
    --cc=gwd@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=stewart.hildebrand@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.