From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] drm/stm: drv: Improve data transfers Date: Tue, 30 Jan 2018 17:01:30 +0200 Message-ID: <9032382.xZ397EfsLU@avalon> References: <20180130104200.21602-1-philippe.cornu@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8C7C6E7AF for ; Tue, 30 Jan 2018 15:01:13 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard Cc: Alexandre Torgue , David Airlie , Philippe Cornu , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Yannick Fertre , Fabien Dessenne , Maxime Coquelin , Mickael Reulier , Vincent Abriou , Ludovic Barre List-Id: dri-devel@lists.freedesktop.org SGkgQmVuamFtaW4sCgpPbiBUdWVzZGF5LCAzMCBKYW51YXJ5IDIwMTggMTI6NTE6MjUgRUVUIEJl bmphbWluIEdhaWduYXJkIHdyb3RlOgo+IDIwMTgtMDEtMzAgMTE6NDIgR01UKzAxOjAwIFBoaWxp cHBlIENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5jb20+Ogo+ID4gVG8gb3B0aW1pemUgZGF0YSB0 cmFuc2ZlcnMsIGFsaWduIHBpdGNoIG9uIDEyOCBieXRlcyAmIGhlaWdodAo+ID4gb24gNCBieXRl cy4gVGhpcyBvcHRpbWl6YXRpb24gaXMgbm90IGFwcGxpY2FibGUgb24gaHcgd2l0aG91dCBNTVUu Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFlhbm5pY2sgRmVydHJlIDx5YW5uaWNrLmZlcnRyZUBz dC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaW5jZW50IEFicmlvdSA8dmluY2VudC5hYnJpb3VA c3QuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgQ29ybnUgPHBoaWxpcHBlLmNvcm51 QHN0LmNvbT4KPiAKPiBBcHBsaWVkIG9uIGRybS1taXNjLW5leHQuCgpBIDkgbWludXRlcyByZXZp ZXcgd2luZG93IGlzIHByZXR0eSBzbWFsbC4uLiBJJ3ZlIGJlZW4gdG9sZCBiZWZvcmUgdGhhdCBJ IApzaG91bGQgdGhlbiByZXZpZXcgdjEgaW5zdGVhZCBvZiBjb21wbGFpbmluZyBhYm91dCBzaG9y dCByZXZpZXcgdGltZXMgZm9yIHYyLCAKYnV0IGluIHRoaXMgY2FzZSB2MiBpbnRyb2R1Y2VzIGEg YnVnIHRoYXQgd2Fzbid0IHByZXNlbnQgaW4gdjEuCgo+ID4gLS0tCj4gPiBDaGFuZ2VzIGluIHYy OiBSZW5hbWUgc3RtX2R1bWJfY3JlYXRlKCkgdG8gc3RtX2dlbV9jbWFfZHVtYl9jcmVhdGUoKSBh bmQKPiA+IAo+ID4gICBtb3ZlIENPTkZJR19NTVUgaW5zaWRlIHRoZSBmdW5jdGlvbiBmb2xsb3dp bmcgY29tbWVudHMgZnJvbSBCZW5qYW1pbgo+ID4gICBHYWlnbmFyZC4KPiA+ICAKPiA+ICBkcml2 ZXJzL2dwdS9kcm0vc3RtL2Rydi5jIHwgMjAgKysrKysrKysrKysrKysrKysrKy0KPiA+ICAxIGZp bGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0bS9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9zdG0v ZHJ2LmMKPiA+IGluZGV4IDhmZTk1NGMyN2ZiYS4uOGJjN2U4NDE4YjhkIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3N0bS9kcnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N0 bS9kcnYuYwo+ID4gQEAgLTMxLDYgKzMxLDI0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX21v ZGVfY29uZmlnX2Z1bmNzCj4gPiBkcnZfbW9kZV9jb25maWdfZnVuY3MgPSB7PiAKPiA+ICAgICAg ICAgLmF0b21pY19jb21taXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXQsCj4gPiAgCj4gPiAg fTsKPiA+IAo+ID4gK3N0YXRpYyBpbnQgc3RtX2dlbV9jbWFfZHVtYl9jcmVhdGUoc3RydWN0IGRy bV9maWxlICpmaWxlLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdHJ1Y3QgZHJtX21vZGVfY3JlYXRlX2R1bWIgKmFyZ3MpCj4gPiArewo+ID4gKyNpZmRlZiBD T05GSUdfTU1VCj4gPiArICAgICAgIHVuc2lnbmVkIGludCBtaW5fcGl0Y2ggPSBESVZfUk9VTkRf VVAoYXJncy0+d2lkdGggKiBhcmdzLT5icHAsIDgpOwo+ID4gKwo+ID4gKyAgICAgICAvKgo+ID4g KyAgICAgICAgKiBpbiBvcmRlciB0byBvcHRpbWl6ZSBkYXRhIHRyYW5zZmVyLCBwaXRjaCBpcyBh bGlnbmVkIG9uCj4gPiArICAgICAgICAqIDEyOCBieXRlcywgaGVpZ2h0IGlzIGFsaWduZWQgb24g NCBieXRlcwo+ID4gKyAgICAgICAgKi8KPiA+ICsgICAgICAgYXJncy0+cGl0Y2ggPSByb3VuZHVw KG1pbl9waXRjaCwgMTI4KTsKPiA+ICsgICAgICAgYXJncy0+aGVpZ2h0ID0gcm91bmR1cChhcmdz LT5oZWlnaHQsIDQpOwo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gKyAgICAgICByZXR1cm4gZHJtX2dl bV9jbWFfZHVtYl9jcmVhdGVfaW50ZXJuYWwoZmlsZSwgZGV2LCBhcmdzKTsKPiA+ICt9Cj4gPiAr Cj4gPiAKPiA+ICBERUZJTkVfRFJNX0dFTV9DTUFfRk9QUyhkcnZfZHJpdmVyX2ZvcHMpOwo+ID4g IAo+ID4gIHN0YXRpYyBzdHJ1Y3QgZHJtX2RyaXZlciBkcnZfZHJpdmVyID0gewo+ID4gCj4gPiBA QCAtNDQsNyArNjIsNyBAQCBzdGF0aWMgc3RydWN0IGRybV9kcml2ZXIgZHJ2X2RyaXZlciA9IHsK PiA+IAo+ID4gICAgICAgICAubWlub3IgPSAwLAo+ID4gICAgICAgICAucGF0Y2hsZXZlbCA9IDAs Cj4gPiAgICAgICAgIC5mb3BzID0gJmRydl9kcml2ZXJfZm9wcywKPiA+IAo+ID4gLSAgICAgICAu ZHVtYl9jcmVhdGUgPSBkcm1fZ2VtX2NtYV9kdW1iX2NyZWF0ZSwKPiA+ICsgICAgICAgLmR1bWJf Y3JlYXRlID0gc3RtX2dlbV9jbWFfZHVtYl9jcmVhdGUsCj4gPiAKPiA+ICAgICAgICAgLnByaW1l X2hhbmRsZV90b19mZCA9IGRybV9nZW1fcHJpbWVfaGFuZGxlX3RvX2ZkLAo+ID4gICAgICAgICAu cHJpbWVfZmRfdG9faGFuZGxlID0gZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUsCj4gPiAgICAg ICAgIC5nZW1fZnJlZV9vYmplY3RfdW5sb2NrZWQgPSBkcm1fZ2VtX2NtYV9mcmVlX29iamVjdCwK PiA+IAo+ID4gLS0KPiA+IDIuMTUuMQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbeA3PBP (ORCPT ); Tue, 30 Jan 2018 10:01:15 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:45511 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbeA3PBN (ORCPT ); Tue, 30 Jan 2018 10:01:13 -0500 From: Laurent Pinchart To: Benjamin Gaignard Cc: Philippe Cornu , Yannick Fertre , Vincent Abriou , David Airlie , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Archit Taneja , Andrzej Hajda , Fabien Dessenne , Mickael Reulier , Ludovic Barre , Alexandre Torgue , Maxime Coquelin Subject: Re: [PATCH v2] drm/stm: drv: Improve data transfers Date: Tue, 30 Jan 2018 17:01:30 +0200 Message-ID: <9032382.xZ397EfsLU@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180130104200.21602-1-philippe.cornu@st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, On Tuesday, 30 January 2018 12:51:25 EET Benjamin Gaignard wrote: > 2018-01-30 11:42 GMT+01:00 Philippe Cornu : > > To optimize data transfers, align pitch on 128 bytes & height > > on 4 bytes. This optimization is not applicable on hw without MMU. > > > > Signed-off-by: Yannick Fertre > > Signed-off-by: Vincent Abriou > > Signed-off-by: Philippe Cornu > > Applied on drm-misc-next. A 9 minutes review window is pretty small... I've been told before that I should then review v1 instead of complaining about short review times for v2, but in this case v2 introduces a bug that wasn't present in v1. > > --- > > Changes in v2: Rename stm_dumb_create() to stm_gem_cma_dumb_create() and > > > > move CONFIG_MMU inside the function following comments from Benjamin > > Gaignard. > > > > drivers/gpu/drm/stm/drv.c | 20 +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c > > index 8fe954c27fba..8bc7e8418b8d 100644 > > --- a/drivers/gpu/drm/stm/drv.c > > +++ b/drivers/gpu/drm/stm/drv.c > > @@ -31,6 +31,24 @@ static const struct drm_mode_config_funcs > > drv_mode_config_funcs = {> > > .atomic_commit = drm_atomic_helper_commit, > > > > }; > > > > +static int stm_gem_cma_dumb_create(struct drm_file *file, > > + struct drm_device *dev, > > + struct drm_mode_create_dumb *args) > > +{ > > +#ifdef CONFIG_MMU > > + unsigned int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8); > > + > > + /* > > + * in order to optimize data transfer, pitch is aligned on > > + * 128 bytes, height is aligned on 4 bytes > > + */ > > + args->pitch = roundup(min_pitch, 128); > > + args->height = roundup(args->height, 4); > > +#endif > > + > > + return drm_gem_cma_dumb_create_internal(file, dev, args); > > +} > > + > > > > DEFINE_DRM_GEM_CMA_FOPS(drv_driver_fops); > > > > static struct drm_driver drv_driver = { > > > > @@ -44,7 +62,7 @@ static struct drm_driver drv_driver = { > > > > .minor = 0, > > .patchlevel = 0, > > .fops = &drv_driver_fops, > > > > - .dumb_create = drm_gem_cma_dumb_create, > > + .dumb_create = stm_gem_cma_dumb_create, > > > > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, > > .prime_fd_to_handle = drm_gem_prime_fd_to_handle, > > .gem_free_object_unlocked = drm_gem_cma_free_object, > > > > -- > > 2.15.1 -- Regards, Laurent Pinchart