From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] libs/power: add p-state driver
	compatibility
Date: Thu, 20 Dec 2018 11:10:23 +0100
Message-ID: <9037763.qK0Rf51nFT@xps>
References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com>
 <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com>
 <ed680411-32c5-f7aa-b21e-6d4fa7c0d028@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "Hunt, David" <david.hunt@intel.com>, Liang Ma <liang.j.ma@intel.com>,
 dev@dpdk.org, qian.q.xu@intel.com, ferruh.yigit@intel.com
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, bluca@debian.org
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 83E041B3FB
 for <dev@dpdk.org>; Thu, 20 Dec 2018 11:10:28 +0100 (CET)
In-Reply-To: <ed680411-32c5-f7aa-b21e-6d4fa7c0d028@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/12/2018 10:33, Burakov, Anatoly:
> On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote:
> > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote:
> >> 19/12/2018 10:09, Hunt, David:
> >>> On 19/12/2018 3:18 AM, Thomas Monjalon wrote:
> >>>> 14/12/2018 14:11, Liang Ma:
> >>>>> Previously, in order to use the power library, it was necessary
> >>>>> for the user to disable the intel_pstate driver by adding
> >>>>> =E2=80=9Cintel_pstate=3Ddisable=E2=80=9D to the kernel command line=
 for the system,
> >>>>> which causes the acpi_cpufreq driver to be loaded in its place.
> >>>>>
> >>>>> This patch adds the ability for the power library use the intel-pst=
ate
> >>>>> driver.
> >>>>>
> >>>>> It adds a new suite of functions behind the current power library A=
PI,
> >>>>> and will seamlessly set up the user facing API function pointers to
> >>>>> the relevant functions depending on whether the system is running w=
ith
> >>>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a gues=
t,
> >>>>> using kvm. The library API and ABI is unchanged.
> >>>>>
> >>>>> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> >>>>>
> >>>>> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>>> ---
> >>>> Please write a changelog when sending a new version.
> >>>>
> >>>> Dave, any comment on this patch?
> >>>
> >>>
> >>> Looks good to me.
> >>>
> >>> Acked-by: David Hunt <david.hunt@intel.com>
> >>>
> >>>
> >>>>> --- /dev/null
> >>>>> +++ b/lib/librte_power/power_pstate_cpufreq.c
> >>>>> @@ -0,0 +1,770 @@
> >>>>> +/* SPDX-License-Identifier: BSD-3-Clause
> >>>>> + * Copyright(c) 2018-2018 Intel Corporation
> >>>> Something wrong here :)
> >>>
> >>> Yes, should simply be "Copyright(c) 2018 Intel Corporation"
> >>
> >>
> >> There is also a compilation error with meson:
> >>
> >> lib/librte_power/rte_power_empty_poll.h:20:10: fatal error:
> >>     rte_timer.h: No such file or directory
> >=20
> > That's an EAL header, and this file was not modified or referenced in=20
> > this commit. This sounds like a pre-existing problem (with meson=20
> > build-system?), not related to the patchset.
> >=20
> > Is this library not built by default by our patch compilation CI?
> >=20
>=20
> Disregard that, the patch has a bug in meson build file.
>=20
> Still, why doesn't our CI build meson?

I think we should build a new CI for compilation testing.
Luca proposed to use OBS.
Luca, can we work on it?