From: Thomas Monjalon <thomas@monjalon.net>
To: Richael Zhuang <richael.zhuang@arm.com>
Cc: dev@dpdk.org, stable@dpdk.org, David Hunt <david.hunt@intel.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/1] power: check freq count before filling the freqs array
Date: Sat, 24 Jul 2021 10:11:01 +0200 [thread overview]
Message-ID: <90397231.fzX3LJKVxB@thomas> (raw)
In-Reply-To: <d7d2ee14-8f18-6e66-a7e8-a9bfacdff5d3@intel.com>
23/07/2021 10:37, David Hunt:
> Hi Richael,
>
> On 23/7/2021 3:22 AM, Richael Zhuang wrote:
> > The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the
> > array with num_freqs elements, restrict the total num to
> > RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue
> > like:
> > Overrunning array "pi->freqs" of 256 bytes by passing it to a
> > function which accesses it at byte offset 464.
> >
> > Coverity issue: 371913
> > Fixes: ef1cc88f1837 ("power: support cppc_cpufreq driver")
> > Cc: richael.zhuang@arm.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
>
> LGTM to fix the coverity issue.
>
> Acked-by: David Hunt <david.hunt@intel.com>
Removed the space before ":" and applied, thanks.
prev parent reply other threads:[~2021-07-24 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 9:27 [dpdk-dev] [PATCH v1 0/1] power: check freq count before filling the freqs array Richael Zhuang
2021-07-21 9:27 ` [dpdk-dev] [PATCH v1 1/1] " Richael Zhuang
2021-07-22 19:43 ` Thomas Monjalon
2021-07-23 2:07 ` Richael Zhuang
2021-07-23 2:13 ` [dpdk-dev] [PATCH v2 0/1] power: check freq count before filling the freqs Richael Zhuang
2021-07-23 2:13 ` [dpdk-dev] [PATCH v2 1/1] power: check freq count before filling the freqs array Richael Zhuang
2021-07-23 2:22 ` [dpdk-dev] [PATCH v3 0/1] " Richael Zhuang
2021-07-23 2:22 ` [dpdk-dev] [PATCH v3 1/1] " Richael Zhuang
2021-07-23 8:37 ` David Hunt
2021-07-24 8:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90397231.fzX3LJKVxB@thomas \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=richael.zhuang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.