From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 25/46] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Date: Tue, 8 Jan 2019 09:00:02 +0000 Message-ID: <904c67e2-509a-f84a-c7e5-19d1a69eafac@linux.intel.com> References: <20190107115509.12523-1-chris@chris-wilson.co.uk> <20190107115509.12523-25-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8FE776EEDB for ; Tue, 8 Jan 2019 09:00:06 +0000 (UTC) In-Reply-To: <20190107115509.12523-25-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzAxLzIwMTkgMTE6NTQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBoYXZlIHR3byBj bGFzc2VzIG9mIFZNLCBnbG9iYWwgR1RUIGFuZCBwZXItcHJvY2VzcyBHVFQuIEluIG9yZGVyIHRv Cj4gYWxsb3cgb3Vyc2VsdmVzIHRoZSBmcmVlZG9tIHRvIG1peCBib3RoIGFsb25nIGNhbGwgY2hh aW5zLCBkaXN0aW5ndWlzaAo+IHRoZSB0d28gY2xhc3NlcyB3aXRoIHJlZ2FyZHMgdG8gdGhlaXIg bXV0ZXggYW5kIGxvY2tkZXAgbWFwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmggICAgICAgfCAgMiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgfCAgNiArKystLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuYwo+IGluZGV4IDllOWNlMzExNDJiMS4uMmYzNWYxM2QxNzdkIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtNDc0LDggKzQ3NCw3IEBAIHN0YXRpYyB2 b2lkIHZtX2ZyZWVfcGFnZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwgc3RydWN0IHBh Z2UgKnBhZ2UpCj4gICAJc3Bpbl91bmxvY2soJnZtLT5mcmVlX3BhZ2VzLmxvY2spOwo+ICAgfQo+ ICAgCj4gLXN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0KHN0cnVjdCBpOTE1X2Fk ZHJlc3Nfc3BhY2UgKnZtLAo+IC0JCQkJICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiArc3RhdGljIHZvaWQgaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoc3RydWN0IGk5MTVf YWRkcmVzc19zcGFjZSAqdm0sIGludCBzdWJjbGFzcykKPiAgIHsKPiAgIAkvKgo+ICAgCSAqIFRo ZSB2bS0+bXV0ZXggbXVzdCBiZSByZWNsYWltIHNhZmUgKGZvciB1c2UgaW4gdGhlIHNocmlua2Vy KS4KPiBAQCAtNDgzLDYgKzQ4Miw3IEBAIHN0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9p bml0KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCSAqIGF0dGVtcHQgaG9sZGlu ZyB0aGUgbG9jayBpcyBpbW1lZGlhdGVseSByZXBvcnRlZCBieSBsb2NrZGVwLgo+ICAgCSAqLwo+ ICAgCW11dGV4X2luaXQoJnZtLT5tdXRleCk7Cj4gKwlsb2NrZGVwX3NldF9zdWJjbGFzcygmdm0t Pm11dGV4LCBzdWJjbGFzcyk7Cj4gICAJaTkxNV9nZW1fc2hyaW5rZXJfdGFpbnRzX211dGV4KHZt LT5pOTE1LCAmdm0tPm11dGV4KTsKPiAgIAo+ICAgCUdFTV9CVUdfT04oIXZtLT50b3RhbCk7Cj4g QEAgLTE1NDgsNyArMTU0OCw3IEBAIHN0YXRpYyBzdHJ1Y3QgaTkxNV9od19wcGd0dCAqZ2VuOF9w cGd0dF9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAJLyogRnJvbSBi ZHcsIHRoZXJlIGlzIHN1cHBvcnQgZm9yIHJlYWQtb25seSBwYWdlcyBpbiB0aGUgUFBHVFQuICov Cj4gICAJcHBndHQtPnZtLmhhc19yZWFkX29ubHkgPSB0cnVlOwo+ICAgCj4gLQlpOTE1X2FkZHJl c3Nfc3BhY2VfaW5pdCgmcHBndHQtPnZtLCBpOTE1KTsKPiArCWk5MTVfYWRkcmVzc19zcGFjZV9p bml0KCZwcGd0dC0+dm0sIFZNX0NMQVNTX1BQR1RUKTsKPiAgIAo+ICAgCS8qIFRoZXJlIGFyZSBv bmx5IGZldyBleGNlcHRpb25zIGZvciBnZW4gPj02LiBjaHYgYW5kIGJ4dC4KPiAgIAkgKiBBbmQg d2UgYXJlIG5vdCBzdXJlIGFib3V0IHRoZSBsYXR0ZXIgc28gcGxheSBzYWZlIGZvciBub3cuCj4g QEAgLTE5OTcsNyArMTk5Nyw3IEBAIHN0YXRpYyBzdHJ1Y3QgaTkxNV9od19wcGd0dCAqZ2VuNl9w cGd0dF9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAKPiAgIAlwcGd0 dC0+YmFzZS52bS50b3RhbCA9IEk5MTVfUERFUyAqIEdFTjZfUFRFUyAqIEk5MTVfR1RUX1BBR0Vf U0laRTsKPiAgIAo+IC0JaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT5iYXNlLnZtLCBp OTE1KTsKPiArCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZwcGd0dC0+YmFzZS52bSwgVk1fQ0xB U1NfUFBHVFQpOwo+ICAgCj4gICAJcHBndHQtPmJhc2Uudm0uYWxsb2NhdGVfdmFfcmFuZ2UgPSBn ZW42X2FsbG9jX3ZhX3JhbmdlOwo+ICAgCXBwZ3R0LT5iYXNlLnZtLmNsZWFyX3JhbmdlID0gZ2Vu Nl9wcGd0dF9jbGVhcl9yYW5nZTsKPiBAQCAtMzQzNCw3ICszNDM0LDcgQEAgaW50IGk5MTVfZ2d0 dF9pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkgKiBhbmQg YmV5b25kIHRoZSBlbmQgb2YgdGhlIEdUVCBpZiB3ZSBkbyBub3QgcHJvdmlkZSBhIGd1YXJkLgo+ ICAgCSAqLwo+ICAgCW11dGV4X2xvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiAt CWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZnZ3R0LT52bSwgZGV2X3ByaXYpOwo+ICsJaTkxNV9h ZGRyZXNzX3NwYWNlX2luaXQoJmdndHQtPnZtLCBWTV9DTEFTU19HR1RUKTsKPiAgIAo+ICAgCWdn dHQtPnZtLmlzX2dndHQgPSB0cnVlOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2d0dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0 LmgKPiBpbmRleCBlMjM2MGYxNjQyN2EuLjkyMjliMDNkNjI5YiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5oCj4gQEAgLTI4OCw2ICsyODgsOCBAQCBzdHJ1Y3QgaTkxNV9hZGRy ZXNzX3NwYWNlIHsKPiAgIAlib29sIGNsb3NlZDsKPiAgIAo+ICAgCXN0cnVjdCBtdXRleCBtdXRl eDsgLyogcHJvdGVjdHMgdm1hIGFuZCBvdXIgbGlzdHMgKi8KPiArI2RlZmluZSBWTV9DTEFTU19H R1RUIDAKPiArI2RlZmluZSBWTV9DTEFTU19QUEdUVCAxCj4gICAKPiAgIAl1NjQgc2NyYXRjaF9w dGU7Cj4gICAJc3RydWN0IGk5MTVfcGFnZV9kbWEgc2NyYXRjaF9wYWdlOwo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19ndHQuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5jCj4gaW5kZXggNmFlNDE4Yzc2MDE1Li45NzZj ODYyYjM4NDIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21v Y2tfZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19ndHQu Ywo+IEBAIC03MCw3ICs3MCw3IEBAIG1vY2tfcHBndHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUsCj4gICAJcHBndHQtPnZtLnRvdGFsID0gcm91bmRfZG93bihVNjRfTUFYLCBQQUdFX1NJ WkUpOwo+ICAgCXBwZ3R0LT52bS5maWxlID0gRVJSX1BUUigtRU5PREVWKTsKPiAgIAo+IC0JaTkx NV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52bSwgaTkxNSk7Cj4gKwlpOTE1X2FkZHJlc3Nf c3BhY2VfaW5pdCgmcHBndHQtPnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gICAKPiAgIAlwcGd0dC0+ dm0uY2xlYXJfcmFuZ2UgPSBub3BfY2xlYXJfcmFuZ2U7Cj4gICAJcHBndHQtPnZtLmluc2VydF9w YWdlID0gbW9ja19pbnNlcnRfcGFnZTsKPiBAQCAtMTAyLDYgKzEwMiw3IEBAIHZvaWQgbW9ja19p bml0X2dndHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAJc3RydWN0IGk5MTVf Z2d0dCAqZ2d0dCA9ICZpOTE1LT5nZ3R0Owo+ICAgCj4gICAJZ2d0dC0+dm0uaTkxNSA9IGk5MTU7 Cj4gKwlnZ3R0LT52bS5pc19nZ3R0ID0gdHJ1ZTsKPiAgIAo+ICAgCWdndHQtPmdtYWRyID0gKHN0 cnVjdCByZXNvdXJjZSkgREVGSU5FX1JFU19NRU0oMCwgMjA0OCAqIFBBR0VfU0laRSk7Cj4gICAJ Z2d0dC0+bWFwcGFibGVfZW5kID0gcmVzb3VyY2Vfc2l6ZSgmZ2d0dC0+Z21hZHIpOwo+IEBAIC0x MTcsOSArMTE4LDggQEAgdm9pZCBtb2NrX2luaXRfZ2d0dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqaTkxNSkKPiAgIAlnZ3R0LT52bS52bWFfb3BzLnNldF9wYWdlcyAgID0gZ2d0dF9zZXRfcGFn ZXM7Cj4gICAJZ2d0dC0+dm0udm1hX29wcy5jbGVhcl9wYWdlcyA9IGNsZWFyX3BhZ2VzOwo+ICAg Cj4gLQlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIGk5MTUpOwo+ICAgCj4gLQln Z3R0LT52bS5pc19nZ3R0ID0gdHJ1ZTsKPiArCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZnZ3R0 LT52bSwgVk1fQ0xBU1NfR0dUVCk7Cj4gICB9Cj4gICAKPiAgIHZvaWQgbW9ja19maW5pX2dndHQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gCgpBZ2FpbjoKClJldmlld2VkLWJ5OiBU dnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRr bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK