From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1U2ldD-0001ZR-SA for mharc-grub-devel@gnu.org; Tue, 05 Feb 2013 11:44:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2ld5-0001Z0-Qh for grub-devel@gnu.org; Tue, 05 Feb 2013 11:44:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2ld4-0006bT-3M for grub-devel@gnu.org; Tue, 05 Feb 2013 11:44:19 -0500 Received: from collab.rosalab.ru ([217.199.216.181]:41999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2ld3-0006al-Nq for grub-devel@gnu.org; Tue, 05 Feb 2013 11:44:18 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id D2E8F29C321 for ; Tue, 5 Feb 2013 20:44:14 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UDskpf-pR6Rv for ; Tue, 5 Feb 2013 20:44:14 +0400 (MSK) Received: from collab.rosalab.ru (collab.rosalab.ru [192.168.1.89]) by collab.rosalab.ru (Postfix) with ESMTP id 3EE6F29C303 for ; Tue, 5 Feb 2013 20:44:14 +0400 (MSK) Date: Tue, 5 Feb 2013 19:44:14 +0300 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Message-ID: <905524412.2504.1360082654149.JavaMail.root@collab.rosalab.ru> In-Reply-To: <1553109984.2496.1360082210371.JavaMail.root@collab.rosalab.ru> Subject: fixed item-height, item-spacing, max-elements-shown etc MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2503_1419230463.1360082654147" X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2013 16:44:25 -0000 ------=_Part_2503_1419230463.1360082654147 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I'm going to write some patches for GRUB2 - mainly for theme handling. First one - I've faced some bug: maximum number of displayed boot elements is counted in presumption that element's height is item_height and distance between elements is item_spacing. Nevertheless, this conceptions does not work during menu drawing if we have bitmap box of the selected element. Real height of the element will be (item_height + box_pad_top + box_pad_bottom - 1), where box_pad_top and box_pad_bottom are top and bottom dimensions of bitmap box. So we will have strange difficulties with understanding of what will be really drawn and what menu height we should use. The patch fixes these problemes. We will have item_height in every case. So, there will be no troubles with item_height, item_spacing and menu height. These three variables now mean what they suppose to mean. Would be glad if this patch will be accepted. I also have many ideas how to improve GRUB theming functionality. Some of them are completed and I can send them as patches as soon as this patch is accepted. Should I create update-request in bugzilla? If something in the patch is not clear - you can ask me. Also, some time ago I've sent a patch which adds new option - item_pixmap_style for bitmap box of unselected elements. It was not accepted but I didn't received any feedback. With whom should I discuss this patch (now I want to modify it, if the current patch will be accepted). Thanks for your attention. ------=_Part_2503_1419230463.1360082654147 Content-Type: text/x-patch; name=grub2-item-height-size-fix.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=grub2-item-height-size-fix.patch ZGlmZiAtTmF1ciBncnViLTIuMDAvZ3J1Yi1jb3JlL2dmeG1lbnUvZ3VpX2xpc3QuYyBncnViLW5l dy9ncnViLWNvcmUvZ2Z4bWVudS9ndWlfbGlzdC5jCi0tLSBncnViLTIuMDAvZ3J1Yi1jb3JlL2dm eG1lbnUvZ3VpX2xpc3QuYwkyMDExLTEyLTE0IDE0OjM2OjA3LjAwMDAwMDAwMCArMDQwMAorKysg Z3J1Yi1uZXcvZ3J1Yi1jb3JlL2dmeG1lbnUvZ3VpX2xpc3QuYwkyMDEzLTAyLTAzIDEzOjUxOjE3 LjAzODA1MTYyOCArMDQwMApAQCAtMjI3LDggKzIyNywxMCBAQAogCiAgIGdydWJfZ2Z4bWVudV9i b3hfdCBzZWxib3ggPSBzZWxmLT5zZWxlY3RlZF9pdGVtX2JveDsKICAgaW50IHNlbF9sZWZ0cGFk ID0gc2VsYm94LT5nZXRfbGVmdF9wYWQgKHNlbGJveCk7CisgIGludCBzZWxfdmVydGljYWxfcGFk ID0gc2VsX2xlZnRwYWQKKyAgICAgICAgICAgICAgICAgICAgICAgICsgc2VsYm94LT5nZXRfcmln aHRfcGFkIChzZWxib3gpOwogICBpbnQgc2VsX3RvcHBhZCA9IHNlbGJveC0+Z2V0X3RvcF9wYWQg KHNlbGJveCk7Ci0gIGludCBpdGVtX3RvcCA9IHNlbF90b3BwYWQ7CisgIGludCBpdGVtX3RvcCA9 IDA7CiAgIGludCBtZW51X2luZGV4OwogICBpbnQgdmlzaWJsZV9pbmRleDsKICAgc3RydWN0IGdy dWJfdmlkZW9fcmVjdCBvdmlld3BvcnQ7CkBAIC0yNDcsMTQgKzI0OSwxOSBAQAogICAgICAgaW50 IGlzX3NlbGVjdGVkID0gKG1lbnVfaW5kZXggPT0gc2VsZi0+dmlldy0+c2VsZWN0ZWQpOwogICAg ICAgc3RydWN0IGdydWJfdmlkZW9fYml0bWFwICppY29uOwogCisKICAgICAgIGlmIChpc19zZWxl Y3RlZCkKICAgICAgICAgewotCSAgaW50IGN3aWR0aCA9IG92aWV3cG9ydC53aWR0aCAtIDIgKiBi b3hwYWQgLSAyOwotCSAgaWYgKHNlbGJveC0+Z2V0X2JvcmRlcl93aWR0aCkKLQkgICAgY3dpZHRo IC09IHNlbGJveC0+Z2V0X2JvcmRlcl93aWR0aCAoc2VsYm94KTsKLQkgIHNlbGJveC0+c2V0X2Nv bnRlbnRfc2l6ZSAoc2VsYm94LCBjd2lkdGgsIGl0ZW1faGVpZ2h0IC0gMSk7Ci0gICAgICAgICAg c2VsYm94LT5kcmF3IChzZWxib3gsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICBpdGVtX3Rv cCAtIHNlbF90b3BwYWQpOworICAgICAgICAgIGludCBjd2lkdGggPSBvdmlld3BvcnQud2lkdGgg LSAyICogYm94cGFkIC0gMjsKKyAgICAgICAgICBpZiAoc2VsYm94LT5nZXRfYm9yZGVyX3dpZHRo KQorICAgICAgICAgICAgY3dpZHRoIC09IHNlbGJveC0+Z2V0X2JvcmRlcl93aWR0aCAoc2VsYm94 KTsKKyAgICAgICAgICBpbnQgY2hlaWdodCA9IGl0ZW1faGVpZ2h0IC0gc2VsX3ZlcnRpY2FsX3Bh ZDsKKyAgICAgICAgICBpZiAoY3dpZHRoIDwgMSkKKyAgICAgICAgICAgIGN3aWR0aCA9IDE7Cisg ICAgICAgICAgaWYgKGNoZWlnaHQgPCAxKQorICAgICAgICAgICAgY2hlaWdodCA9IDE7CisgICAg ICAgICAgc2VsYm94LT5zZXRfY29udGVudF9zaXplIChzZWxib3gsIGN3aWR0aCwgY2hlaWdodCk7 CisgICAgICAgICAgc2VsYm94LT5kcmF3IChzZWxib3gsIDAsIGl0ZW1fdG9wKTsKICAgICAgICAg fQogCiAgICAgICBpY29uID0gZ2V0X2l0ZW1faWNvbiAoc2VsZiwgbWVudV9pbmRleCk7CkBAIC0z OTEsOSArMzk4LDYgQEAKICAgICAgIGludCBib3hfYm90dG9tX3BhZCA9IGJveC0+Z2V0X2JvdHRv bV9wYWQgKGJveCk7CiAgICAgICB1bnNpZ25lZCB3aWR0aF9zOwogCi0gICAgICBncnViX2dmeG1l bnVfYm94X3Qgc2VsYm94ID0gc2VsZi0+c2VsZWN0ZWRfaXRlbV9ib3g7Ci0gICAgICBpbnQgc2Vs X3RvcHBhZCA9IHNlbGJveC0+Z2V0X3RvcF9wYWQgKHNlbGJveCk7Ci0gICAgICAKICAgICAgICp3 aWR0aCA9IGdydWJfZm9udF9nZXRfc3RyaW5nX3dpZHRoIChzZWxmLT5pdGVtX2ZvbnQsICJUeXBp Y2FsIE9TIik7CiAgICAgICB3aWR0aF9zID0gZ3J1Yl9mb250X2dldF9zdHJpbmdfd2lkdGggKHNl bGYtPnNlbGVjdGVkX2l0ZW1fZm9udCwKIAkJCQkJICAgICJUeXBpY2FsIE9TIik7CkBAIC00MDYs NyArNDEwLDcgQEAKICAgICAgICpoZWlnaHQgPSAoaXRlbV9oZWlnaHQgKiBudW1faXRlbXMKICAg ICAgICAgICAgICAgICAgKyBpdGVtX3ZzcGFjZSAqIChudW1faXRlbXMgLSAxKQogICAgICAgICAg ICAgICAgICArIDIgKiBib3hwYWQKLSAgICAgICAgICAgICAgICAgKyBib3hfdG9wX3BhZCArIGJv eF9ib3R0b21fcGFkICsgc2VsX3RvcHBhZCk7CisgICAgICAgICAgICAgICAgICsgYm94X3RvcF9w YWQgKyBib3hfYm90dG9tX3BhZCk7CiAgICAgfQogICBlbHNlCiAgICAgewo= ------=_Part_2503_1419230463.1360082654147--