Re: [Buildroot] [PATCH] package/e2fsprogs: bump version to fix regression

From: Romain Naour <romain.naour@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Cc: Kevin Tomary <kevin.tomary@hotmail.com>,
	Leon de Rooij <leon@exquisip.nl>
Subject: Re: [Buildroot] [PATCH] package/e2fsprogs: bump version to fix regression
Date: Wed, 8 Sep 2021 22:22:17 +0200	[thread overview]
Message-ID: <90729893-818e-a54e-b3e3-51cee5342873@gmail.com> (raw)
In-Reply-To: <b8b5e5f2-5549-777d-1d94-c93fd21e9d4b@gmail.com>

Hello Yann, All,

Le 08/09/2021 à 21:54, Romain Naour a écrit :
> Hello Yann, All,
> 
> Le 05/09/2021 à 19:44, Yann E. MORIN a écrit :
>> All,
>>
>> On 2021-09-05 19:34 +0200, Yann E. MORIN spake thusly:
>>> Version 1.46.3 had a regression, which meant the file that would store
>>> the filesystem image had to pre-exist, or mkfs.ext2 would fail to
>>> generate the filesystem:
>>>
>>>     mkfs.ext4: No such file or directory while trying to determine
>>>     filesystem size
>>>
>>> The regression was fixed upstream, and is now part of the 1.46.4
>>> release, so bump to that release.
>>>
>>> Fixes: #14196
>>>
>>> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>>> Reported-by: Kevin Tomary <kevin.tomary@hotmail.com>
>>> Reported-by: Leon de Rooij <leon@exquisip.nl>
> 
> There is another regression with e2fsprog 1.46.4:
> 
> https://gitlab.com/kubu93/buildroot/-/jobs/1568672940
> 
> With the fix backported to 1.46.3 the ext4 test is ok.
> 
> https://github.com/tytso/e2fsprogs/commit/53464654bd33e58e3fff079f34261b823d839f3b

Actually there is no regression, e2fsprogs deprecated filesystems with 128-byte
inodes. Now mkfs.ext4 use 256-byte inodes even for small filesystems.

https://github.com/tytso/e2fsprogs/commit/a23b50cdb55cb826b8745cbc37429c93f7b60c66

We have to update our test.

Best regards,
Romain

> 
> Best regards,
> Romain
> 
> 
>>>
>>> ---
>>> For the stable branch 2021.08.x, I'll send a different patch, that just
>>> backports the upstream fix.
>>
>> In fact, 2021.08 still has e2fsprogs 1.46.2, which is not affected; so,
>> no backports needed.
>>
>> Regards,
>> Yann E. MORIN.
>>
>>> ---
>>>  package/e2fsprogs/e2fsprogs.hash | 2 +-
>>>  package/e2fsprogs/e2fsprogs.mk   | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/e2fsprogs/e2fsprogs.hash b/package/e2fsprogs/e2fsprogs.hash
>>> index 3661801199..63c7c9929f 100644
>>> --- a/package/e2fsprogs/e2fsprogs.hash
>>> +++ b/package/e2fsprogs/e2fsprogs.hash
>>> @@ -1,5 +1,5 @@
>>>  # From https://mirrors.edge.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs/v1.46.3/sha256sums.asc
>>> -sha256  86d1580facdd49f2e0e6b027e26b1e6c48af538762dc40aeed2a87153c1f11b7  e2fsprogs-1.46.3.tar.xz
>>> +sha256  b11042533c1b1dcf17512f0da48e05b0c573dada1dd8b762864d10f4dc399713  e2fsprogs-1.46.4.tar.xz
>>>  # Locally calculated
>>>  sha256  5da5ef153e559c1d990d4c3eedbedd4442db892d37eae1f35fff069de8ec9020  NOTICE
>>>  sha256  032989b508f1a72ebee5b3417e55d06d473f9ee203e45ab11864a7e49cdec63d  lib/ss/mit-sipb-copyright.h
>>> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
>>> index 5528ecbc34..ca891066a2 100644
>>> --- a/package/e2fsprogs/e2fsprogs.mk
>>> +++ b/package/e2fsprogs/e2fsprogs.mk
>>> @@ -4,7 +4,7 @@
>>>  #
>>>  ################################################################################
>>>  
>>> -E2FSPROGS_VERSION = 1.46.3
>>> +E2FSPROGS_VERSION = 1.46.4
>>>  E2FSPROGS_SOURCE = e2fsprogs-$(E2FSPROGS_VERSION).tar.xz
>>>  E2FSPROGS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/people/tytso/e2fsprogs/v$(E2FSPROGS_VERSION)
>>>  E2FSPROGS_LICENSE = GPL-2.0, MIT-like with advertising clause (libss and libet)
>>> -- 
>>> 2.25.1
>>>
>>
> 

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot