All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Dunkel <harri@afaics.de>
To: NeilBrown <neilb@suse.de>
Cc: syzbot <syzbot+b568ba42c85a332a88ee@syzkaller.appspotmail.com>,
	Jeff Layton <jlayton@kernel.org>,
	Dai.Ngo@oracle.com, chuck.lever@oracle.com, kolga@netapp.com,
	linux-nfs@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	tom@talpey.com
Subject: Re: [syzbot] [nfs?] INFO: task hung in nfsd_umount
Date: Sun, 29 Sep 2024 10:23:34 +0200	[thread overview]
Message-ID: <90750d21-61fa-4243-8c6b-dbf6fa185ae4@afaics.de> (raw)
In-Reply-To: <172756219838.470955.2955513122187106920@noble.neil.brown.name>

Hi Neil,

On 2024-09-29 00:23:18, NeilBrown wrote:
> 
> Thanks for the logs.  The point to flush_workqueue() being a problem,
> presumably from nfsd4_probe_callback_sync(), though I'm not 100% sure of
> that.  Maybe some deadlock in the callback code.  I'm not very familiar
> with that code and nothing immediately jumps out.
> 
> I had thought that hung_task_all_cpu_backtrace would show a backtrace of
> *all* tasks - I missed the "cpu" in there.
> If if it happens again and if you can
>    echo t > /proc/sysrq-trigger
> to get stack traces of everything, that might help.  Maybe it won't be
> necessary if I or someone else can spot a deadlock with
> flush_workqueue().
> 

I just learned that kernel.hung_task_panic = 1 should have been set, too.
Sorry for that. Currently I have

	kernel.hung_task_panic = 1
	kernel.hung_task_all_cpu_backtrace = 1

Please confirm.

I have set a watchdog to run the sysrq trigger on the NFS server if df
on an NFS client doesn't respond.


Regards
Harri

  reply	other threads:[~2024-09-29  8:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-07  4:37 [syzbot] [nfs?] INFO: task hung in nfsd_umount syzbot
2024-07-07 10:49 ` Jeff Layton
2024-07-08  0:07   ` NeilBrown
2024-09-21  7:58     ` Harald Dunkel
2024-09-28  7:41       ` Harald Dunkel
2024-09-28 22:23         ` NeilBrown
2024-09-29  8:23           ` Harald Dunkel [this message]
2024-09-29  9:59             ` NeilBrown
2024-10-01 10:21               ` Harald Dunkel
2024-10-02 13:55                 ` Harald Dunkel
2024-10-02 14:06                   ` Harald Dunkel
2024-10-04 12:21                     ` Harald Dunkel
2024-10-04 23:37                     ` NeilBrown
2024-10-07 10:51                       ` Harald Dunkel
2024-10-07 18:54                         ` Harald Dunkel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90750d21-61fa-4243-8c6b-dbf6fa185ae4@afaics.de \
    --to=harri@afaics.de \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=kolga@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=syzbot+b568ba42c85a332a88ee@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.