From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6323C43219 for ; Thu, 24 Nov 2022 11:00:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FB5B10E04F; Thu, 24 Nov 2022 11:00:57 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C19710E6F2 for ; Thu, 24 Nov 2022 11:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1669287653; x=1700823653; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TKsmYGKYqQviZJozhSmWaRTpNKVgkOaOV5+wyTY4lf4=; b=ONcIwu8BkzPWoXS/K+DPhaT54ABBqAIf6krONh8mESHEb+LR9Vr6FyJ3 QNrFIZobPZdus6IkRuWcA9mOon3C47f5XknfCu3I7ZB9Lk+4HNl2yS0kV ktcIZ01uFMdB3H6EFYZN1tlowAZ1zoO3fM9HVEdEnqnMv95imWRFt9kjP z5pXPKJHqaPW4XBCE4lX6sgOHExyZYumkvFwoaOF+rc7aiSPGXG1u+W/t 81jHqUIrmLkav+Vp63+DkM6CnJ3Mhr2UdNCXSXG5ulQKhEgPqQT+tS6YM Xgj+pIT3u+dfeZMQdoVwoEmsOX9UgQIaFXPJt3y/ADE8Atk/3JokSSPDx w==; X-IronPort-AV: E=Sophos;i="5.96,190,1665439200"; d="scan'208";a="27559212" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 24 Nov 2022 12:00:50 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 24 Nov 2022 12:00:50 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 24 Nov 2022 12:00:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1669287650; x=1700823650; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TKsmYGKYqQviZJozhSmWaRTpNKVgkOaOV5+wyTY4lf4=; b=lAvHyzOo6Pjn32Y9f9SKk7orxpl0h4UIhBVAXqEoUtTJixflj802qCxj 51wxjUkLMoNdTsxouXcPmaNOy1RU3gumpOD0W2lR+9En+kOKMRs8aSY0F u8rAaz8FUpKZMB/eZaeFeVGy3mrr77ldOrSkM5HLg07eHMFph5ke1cCsh 2TyedO30gaNur/3ECF5LwvvgKyWJFkdh6Q/Vaa1oWyZv6x4Xdx1YMRbtG tSOcqxA9BRGEwTSh7BBPnA8uk+fomj6s3EAaeC0sN8iCvosSuclsg8M9o mNPJZi6PBm8d11SKOOHzwwf32jvT1qwPCP9G5sJFfcJh6+m9DVVpn6IwU Q==; X-IronPort-AV: E=Sophos;i="5.96,190,1665439200"; d="scan'208";a="27559210" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Nov 2022 12:00:50 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 0B7B7280056; Thu, 24 Nov 2022 12:00:50 +0100 (CET) From: Alexander Stein To: Andrzej Hajda , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Frieder Schrempf , Linus Walleij , linux-kernel@vger.kernel.org, Marek Vasut , Neil Armstrong , Robert Foss , Frieder Schrempf Subject: Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Date: Thu, 24 Nov 2022 12:00:48 +0100 Message-ID: <9079928.rMLUfLXkoz@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221122081219.20143-1-frieder@fris.de> References: <20221122081219.20143-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonas Karlman , Jernej Skrabec , Christophe JAILLET , Laurent Pinchart , =?ISO-8859-1?Q?Jos=E9_Exp=F3sito?= , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf: > From: Frieder Schrempf > > The datasheet specifies a delay of 10 milliseconds, but the current > driver only waits for 1 ms. Fix this to make sure the initialization > sequence meets the spec. > > Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and > SN65DSI84 driver") Signed-off-by: Frieder Schrempf > > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 > 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge > *bridge, > > /* Deassert reset */ > gpiod_set_value_cansleep(ctx->enable_gpio, 1); > - usleep_range(1000, 1100); > + usleep_range(10000, 11000); > > /* Get the LVDS format from the bridge state. */ > bridge_state = drm_atomic_get_new_bridge_state(state, bridge); How about using fsleep? Either way: Reviewed-by: Alexander Stein From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178EDC433FE for ; Thu, 24 Nov 2022 11:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbiKXLA7 (ORCPT ); Thu, 24 Nov 2022 06:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiKXLAy (ORCPT ); Thu, 24 Nov 2022 06:00:54 -0500 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B085297348 for ; Thu, 24 Nov 2022 03:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1669287652; x=1700823652; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TKsmYGKYqQviZJozhSmWaRTpNKVgkOaOV5+wyTY4lf4=; b=PqzuJuSBcZIeTxi3+dO14op7fSnmnaavS12lXXa2m1UOsQAFqTzPm3Cd y17/ixXnHJvHjnawq0OdRl1geIN1sQlzqEoueb0Qj3ddJs2rKTyciUZCR +64nEtMPtV724gWTRZD4mtTOo4Uim0J6Mvutujop8SynHbj4h2JqFO8mz qI5viDoJeKnYKIYg6lPiz/hDGQZbUK86oBz0WU7Ermzbv/nj4NVq/D1Xi 0/GR39aaCi4LmVJoBbwUAORFcxX49QNtoYbhkdLoXhmrAWf6urXdbU7sw UXUvBDkJA0oStbpnkBvj0R1vvcZoz2+Q5Xd5XwSkZ85WCTmT/neiC9vZ3 w==; X-IronPort-AV: E=Sophos;i="5.96,190,1665439200"; d="scan'208";a="27559212" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 24 Nov 2022 12:00:50 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 24 Nov 2022 12:00:50 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 24 Nov 2022 12:00:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1669287650; x=1700823650; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TKsmYGKYqQviZJozhSmWaRTpNKVgkOaOV5+wyTY4lf4=; b=lAvHyzOo6Pjn32Y9f9SKk7orxpl0h4UIhBVAXqEoUtTJixflj802qCxj 51wxjUkLMoNdTsxouXcPmaNOy1RU3gumpOD0W2lR+9En+kOKMRs8aSY0F u8rAaz8FUpKZMB/eZaeFeVGy3mrr77ldOrSkM5HLg07eHMFph5ke1cCsh 2TyedO30gaNur/3ECF5LwvvgKyWJFkdh6Q/Vaa1oWyZv6x4Xdx1YMRbtG tSOcqxA9BRGEwTSh7BBPnA8uk+fomj6s3EAaeC0sN8iCvosSuclsg8M9o mNPJZi6PBm8d11SKOOHzwwf32jvT1qwPCP9G5sJFfcJh6+m9DVVpn6IwU Q==; X-IronPort-AV: E=Sophos;i="5.96,190,1665439200"; d="scan'208";a="27559210" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Nov 2022 12:00:50 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 0B7B7280056; Thu, 24 Nov 2022 12:00:50 +0100 (CET) From: Alexander Stein To: Andrzej Hajda , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Frieder Schrempf , Linus Walleij , linux-kernel@vger.kernel.org, Marek Vasut , Neil Armstrong , Robert Foss , Frieder Schrempf Cc: Christophe JAILLET , Jernej Skrabec , Jonas Karlman , =?ISO-8859-1?Q?Jos=E9_Exp=F3sito?= , Laurent Pinchart , Sam Ravnborg , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Date: Thu, 24 Nov 2022 12:00:48 +0100 Message-ID: <9079928.rMLUfLXkoz@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221122081219.20143-1-frieder@fris.de> References: <20221122081219.20143-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf: > From: Frieder Schrempf > > The datasheet specifies a delay of 10 milliseconds, but the current > driver only waits for 1 ms. Fix this to make sure the initialization > sequence meets the spec. > > Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and > SN65DSI84 driver") Signed-off-by: Frieder Schrempf > > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 > 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge > *bridge, > > /* Deassert reset */ > gpiod_set_value_cansleep(ctx->enable_gpio, 1); > - usleep_range(1000, 1100); > + usleep_range(10000, 11000); > > /* Get the LVDS format from the bridge state. */ > bridge_state = drm_atomic_get_new_bridge_state(state, bridge); How about using fsleep? Either way: Reviewed-by: Alexander Stein