From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces
Date: Thu, 5 Dec 2024 10:12:43 +0200 [thread overview]
Message-ID: <907e39c2-ca06-4b51-9fb0-5b0745bf0f56@linux.intel.com> (raw)
In-Reply-To: <Z1Fb7eYPr8y_l2dT@smile.fi.intel.com>
On 12/5/24 9:53 AM, Andy Shevchenko wrote:
> On Wed, Dec 04, 2024 at 11:25:40AM +0100, Uwe Kleine-König wrote:
>> On Wed, Dec 04, 2024 at 03:23:52AM +0200, Andy Shevchenko wrote:
>>> On Tue, Dec 03, 2024 at 11:46:07PM +0100, Uwe Kleine-König wrote:
>>>> On Tue, Dec 03, 2024 at 09:27:35PM +0200, Andy Shevchenko wrote:
>>>>> On Tue, Dec 03, 2024 at 06:36:40PM +0100, Uwe Kleine-König wrote:
>>>>>> DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
>>>>>> is included. So move the define above the include block.
>>>>>
>>>>> As in the other email I pointed out the doc says that we need to undef the
>>>>> symbol. No need to move it around.
>>>>>
>>>>> The only requirement is to place that before any EXPORT_SYMBOL*() we want to
>>>>> add it to.
>>>> [...]
>>>
>>> Perhaps we need to update the documentation first.
>>
>> I addressed that in https://lore.kernel.org/all/3dd7ff6fa0a636de86e091286016be8c90e03631.1733305665.git.ukleinek@kernel.org/
>
> Thank you!
>
Andy: is this your reviewed by? If so then
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2024-12-05 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 17:36 [PATCH] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces Uwe Kleine-König
2024-12-03 19:27 ` Andy Shevchenko
2024-12-03 22:46 ` Uwe Kleine-König
2024-12-04 1:23 ` Andy Shevchenko
2024-12-04 10:25 ` Uwe Kleine-König
2024-12-05 7:53 ` Andy Shevchenko
2024-12-05 8:12 ` Jarkko Nikula [this message]
2024-12-05 8:26 ` Andy Shevchenko
2024-12-27 0:07 ` Andi Shyti
2024-12-28 21:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907e39c2-ca06-4b51-9fb0-5b0745bf0f56@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.