From: David Howells <dhowells@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@google.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-crypto <linux-crypto@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer
Date: Fri, 03 Aug 2018 10:14:28 +0100 [thread overview]
Message-ID: <9082.1533287668@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAGXu5jLVNnUXkyzGdee3zvLHw5zMaDhEGm4c4YLqU=L8q9TshA@mail.gmail.com>
Hmmm... I'm wondering if the skcipher request should be allocated on call
initialisation and a pointer put in the rxrpc_call struct. It's only used
serially for any particular call.
For the moment, I'll pass your patch onto DaveM.
David
next prev parent reply other threads:[~2018-08-03 9:14 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 16:49 [PATCH v6 00/18] crypto: Remove VLA usage Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
[not found] ` <20180724164936.37477-1-keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-24 16:49 ` [PATCH v6 01/18] crypto: xcbc: " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 02/18] crypto: cbc: " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 14/18] staging: rtl8192u: ieee80211: Convert from ahash to shash Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 03/18] crypto: hash: Remove VLA usage Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 04/18] dm: Remove VLA usage from hashes Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 05/18] crypto alg: Introduce generic max blocksize and alignmask Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 06/18] crypto: qat: Remove VLA usage Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 07/18] crypto: shash: Remove VLA usage in unaligned hashing Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 08/18] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 09/18] ppp: mppe: Remove VLA usage Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 10/18] x86/power/64: " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-25 11:32 ` Rafael J. Wysocki
2018-07-25 11:32 ` [Drbd-dev] " Rafael J. Wysocki
2018-07-25 11:32 ` Rafael J. Wysocki
2018-07-25 11:32 ` Rafael J. Wysocki
2018-07-25 11:32 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0gVDotjufLKUW0YuQu2vA4fmU_gqia=ZA4DocW4XHxx0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-25 18:01 ` Kees Cook
2018-07-25 18:01 ` [Drbd-dev] " Kees Cook
2018-07-25 18:01 ` Kees Cook
2018-07-25 18:01 ` Kees Cook
2018-07-25 18:01 ` Kees Cook
2018-08-06 10:28 ` Rafael J. Wysocki
2018-08-06 10:28 ` Rafael J. Wysocki
2018-08-06 10:28 ` Rafael J. Wysocki
2018-08-06 10:28 ` Rafael J. Wysocki
2018-07-24 16:49 ` [PATCH v6 11/18] dm crypt: Convert essiv from ahash to shash Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 12/18] drbd: Convert " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-08-02 23:43 ` Kees Cook
2018-08-02 23:43 ` [Drbd-dev] " Kees Cook
2018-08-02 23:43 ` Kees Cook
2018-08-03 13:44 ` Lars Ellenberg
2018-08-03 13:44 ` [Drbd-dev] " Lars Ellenberg
2018-08-03 13:44 ` Lars Ellenberg
2018-08-06 17:27 ` Kees Cook
2018-08-06 17:27 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` [PATCH v6 13/18] wireless/lib80211: " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-25 7:24 ` Johannes Berg
2018-07-25 7:24 ` [Drbd-dev] " Johannes Berg
2018-07-25 7:24 ` Johannes Berg
2018-07-25 7:24 ` Johannes Berg
2018-07-25 7:24 ` Johannes Berg
2018-07-25 8:05 ` Kalle Valo
2018-07-25 8:05 ` [Drbd-dev] " Kalle Valo
2018-07-25 8:05 ` Kalle Valo
2018-07-25 8:05 ` Kalle Valo
2018-07-24 16:49 ` [PATCH v6 15/18] staging: rtl8192e: ieee80211: " Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-08-02 23:46 ` Kees Cook
2018-08-03 9:14 ` David Howells [this message]
2018-07-24 16:49 ` [PATCH v6 17/18] crypto: ccm: Remove VLA usage Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:57 ` Ard Biesheuvel
2018-07-24 16:57 ` [Drbd-dev] " Ard Biesheuvel
2018-07-24 16:57 ` Ard Biesheuvel
2018-07-24 16:57 ` Ard Biesheuvel
2018-07-24 16:57 ` Ard Biesheuvel
2018-07-24 17:51 ` Kees Cook
2018-07-24 17:51 ` [Drbd-dev] " Kees Cook
2018-07-24 17:51 ` Kees Cook
2018-07-24 17:51 ` Kees Cook
2018-07-24 17:51 ` Kees Cook
2018-07-24 16:49 ` [PATCH v6 18/18] crypto: Remove AHASH_REQUEST_ON_STACK Kees Cook
2018-07-24 16:49 ` [Drbd-dev] " Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 16:49 ` Kees Cook
2018-07-24 17:31 ` Joe Perches
2018-07-24 17:31 ` [Drbd-dev] " Joe Perches
2018-07-24 17:31 ` Joe Perches
2018-07-24 17:31 ` Joe Perches
2018-07-24 17:31 ` Joe Perches
[not found] ` <1bdc706ae86039c4ffcff39698251424d54af116.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-07-24 17:53 ` Kees Cook
2018-07-24 17:53 ` [Drbd-dev] " Kees Cook
2018-07-24 17:53 ` Kees Cook
2018-07-24 17:53 ` Kees Cook
2018-07-24 17:53 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9082.1533287668@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.