From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7CDECAAD2 for ; Mon, 29 Aug 2022 22:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229507AbiH2WZa (ORCPT ); Mon, 29 Aug 2022 18:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiH2WZ3 (ORCPT ); Mon, 29 Aug 2022 18:25:29 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4397725299 for ; Mon, 29 Aug 2022 15:25:28 -0700 (PDT) Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1oSnCA-000DqI-48; Tue, 30 Aug 2022 00:25:26 +0200 Received: from [85.1.206.226] (helo=linux-4.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSnC9-0008mj-Ml; Tue, 30 Aug 2022 00:25:25 +0200 Subject: Re: [PATCH bpf-next 0/2] bpf,ftrace: bpf dispatcher function fix To: Jiri Olsa , Alexei Starovoitov , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Peter Zijlstra , Thomas Gleixner , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= References: <20220826184608.141475-1-jolsa@kernel.org> From: Daniel Borkmann Message-ID: <9099057e-124c-8f30-c29d-54be85eeebfd@iogearbox.net> Date: Tue, 30 Aug 2022 00:25:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220826184608.141475-1-jolsa@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26642/Mon Aug 29 09:54:26 2022) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 8/26/22 8:46 PM, Jiri Olsa wrote: > hi, > as discussed [1] sending fix that moves bpf dispatcher function of out > ftrace locations together with Peter's HAVE_DYNAMIC_FTRACE_NO_PATCHABLE > dependency change. Looks like the series breaks s390x builds; BPF CI link: https://github.com/kernel-patches/bpf/runs/8079411784?check_suite_focus=true [...] CC net/xfrm/xfrm_state.o CC net/packet/af_packet.o {standard input}: Assembler messages: {standard input}:16055: Error: bad expression {standard input}:16056: Error: bad expression {standard input}:16057: Error: bad expression {standard input}:16058: Error: bad expression {standard input}:16059: Error: bad expression CC drivers/s390/char/raw3270.o CC net/ipv6/ip6_output.o [...] CC net/xfrm/xfrm_output.o CC net/ipv6/ip6_input.o {standard input}:16055: Error: invalid operands (*ABS* and *UND* sections) for `%' {standard input}:16056: Error: invalid operands (*ABS* and *UND* sections) for `%' {standard input}:16057: Error: invalid operands (*ABS* and *UND* sections) for `%' {standard input}:16058: Error: invalid operands (*ABS* and *UND* sections) for `%' {standard input}:16059: Error: invalid operands (*ABS* and *UND* sections) for `%' make[3]: *** [scripts/Makefile.build:249: net/core/filter.o] Error 1 make[2]: *** [scripts/Makefile.build:465: net/core] Error 2 make[2]: *** Waiting for unfinished jobs.... CC net/ipv4/tcp_fastopen.o [...] CC lib/percpu-refcount.o make[1]: *** [Makefile:1855: net] Error 2 CC lib/rhashtable.o make[1]: *** Waiting for unfinished jobs.... CC lib/base64.o [...] AR lib/built-in.a CC kernel/kheaders.o AR kernel/built-in.a make: *** [Makefile:353: __build_one_by_one] Error 2 Error: Process completed with exit code 2. > [1] https://lore.kernel.org/bpf/20220722110811.124515-1-jolsa@kernel.org/ > --- > Jiri Olsa (1): > bpf: Move bpf_dispatcher function out of ftrace locations > > Peter Zijlstra (Intel) (1): > ftrace: Add HAVE_DYNAMIC_FTRACE_NO_PATCHABLE > > arch/x86/Kconfig | 1 + > include/asm-generic/vmlinux.lds.h | 11 ++++++++++- > include/linux/bpf.h | 2 ++ > kernel/trace/Kconfig | 6 ++++++ > tools/objtool/check.c | 3 ++- > 5 files changed, 21 insertions(+), 2 deletions(-) >