Re: [PATCH mptcp-next v5 00/16] MPTCP sockmap support

[Matthieu Baerts <matttbe@kernel.org>]

On 14/09/2026 11:48, Geliang Tang wrote:
> Hi Matt,
> 
> On Sun, 2026-09-13 at 18:14 +0800, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v5:
>>  - Patches 1-4 are from "Reduce the differences between TCP and MPTCP
>> for TLS usage" set.
> 
> I put the four patches from the "Reduce the differences between TCP and
> MPTCP for TLS usage" series here because this "MPTCP sockmap support"
> series depends on them. Actually, it doesn't just depend on these four
> patches - it also appears to depend on "mptcp: remove CB offset field"
> (see sashiko's comments on patch 9) and "mptcp: implement peek_len for
> proto_ops" (see sashiko's comments on patch 13).
> 
> So this series depends on the entire "Reduce the differences between
> TCP and MPTCP for TLS usage" series. I could use "Based-on: <...>" to
> trigger CI based on the dependency, but Sashiko doesn't recognize
> "Based-on", so it won't be able to apply successfully.
> 
> Is there some Sashiko feature that can handle this kind of chained
> dependency between patchsets?

Not yet, apparently:

  https://github.com/sashiko-dev/sashiko/issues/49

> Or do I need to include all ten patches
> of the "Reduce the differences between TCP and MPTCP for TLS usage"
> series in the next version? I'd appreciate your thoughts on this.
> 
> Alternatively, let's first do the review of the "Reduce the differences
> between TCP and MPTCP for TLS usage" series - it's already ready for
> review - so that both the subsequent "MPTCP KTLS support" series and
> this "MPTCP sockmap support" series can move forward more easily.
Probably best to do that. I admit that with all the different series and
revisions, I'm sorry, but I'm a bit lost regarding the priorities. What
should be reviewed first?

These series?

 - Reduce the differences between TCP and MPTCP for TLS usage
 - mptcp: remove CB offset field
 - mptcp: implement peek_len for proto_ops

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.