From: Stephen Boyd <sboyd@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-clk@vger.kernel.org, linux-mips@vger.kernel.org,
tsbogend@alpha.franken.de, john@phrozen.org,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
mturquette@baylibre.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, arinc.unal@arinc9.com
Subject: Re: [PATCH 07/10] mips: ralink: remove clock related function prototypes
Date: Mon, 20 Mar 2023 14:21:37 -0700 [thread overview]
Message-ID: <90dd1f841e7941d8b5931ef68cd6d14e.sboyd@kernel.org> (raw)
In-Reply-To: <CAMhs-H-y6TsSoKsJzM0gkFk6wx7xNigXKJb7wm8rBzrigtJANg@mail.gmail.com>
Quoting Sergio Paracuellos (2023-03-20 13:17:47)
> Hi Stephen,
>
> On Mon, Mar 20, 2023 at 8:38 PM Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Quoting Sergio Paracuellos (2023-03-20 09:18:20)
> > > Clock related code has been removed from 'arch/mips/ralink' folder and put
> > > into drivers space. Hence remove clock related prototypes which are not
> > > used anymore.
> > >
> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > > ---
> > > arch/mips/ralink/common.h | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/arch/mips/ralink/common.h b/arch/mips/ralink/common.h
> > > index 87fc16751281..fcdfc9dc6210 100644
> > > --- a/arch/mips/ralink/common.h
> > > +++ b/arch/mips/ralink/common.h
> > > @@ -23,9 +23,6 @@ extern struct ralink_soc_info soc_info;
> > >
> > > extern void ralink_of_remap(void);
> > >
> > > -extern void ralink_clk_init(void);
> >
> > Why isn't this removed in the patch that removes the function?
>
> Because the function exists for all the SoCs code and there are
> several patches removing it; one per SoC, so I decided to remove this
> at the end. Should I squash all patches together instead?
No. But you should squash this with whatever patch removes the last one.
next prev parent reply other threads:[~2023-03-20 21:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:18 [PATCH 00/10] mips: ralink: add complete clock and reset driver for mtmips SoCs Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation Sergio Paracuellos
2023-03-20 16:36 ` Krzysztof Kozlowski
2023-03-20 16:43 ` Arınç ÜNAL
2023-03-20 16:50 ` Krzysztof Kozlowski
2023-03-20 17:24 ` Sergio Paracuellos
2023-03-20 17:36 ` Krzysztof Kozlowski
2023-03-20 17:57 ` Arınç ÜNAL
2023-03-20 18:02 ` Krzysztof Kozlowski
2023-03-20 18:09 ` Arınç ÜNAL
2023-03-20 18:15 ` Krzysztof Kozlowski
2023-03-21 4:34 ` Sergio Paracuellos
2023-03-21 6:32 ` Krzysztof Kozlowski
2023-03-21 6:38 ` Arınç ÜNAL
2023-03-21 6:43 ` Krzysztof Kozlowski
2023-03-21 6:56 ` Sergio Paracuellos
2023-03-21 7:19 ` Krzysztof Kozlowski
2023-03-21 7:27 ` Sergio Paracuellos
2023-03-21 7:39 ` Arınç ÜNAL
2023-03-21 8:04 ` Krzysztof Kozlowski
2023-03-21 8:24 ` Arınç ÜNAL
2023-03-21 8:27 ` Krzysztof Kozlowski
2023-03-21 8:33 ` Arınç ÜNAL
2023-03-21 8:39 ` Krzysztof Kozlowski
2023-03-21 8:53 ` Arınç ÜNAL
2023-03-21 9:01 ` Krzysztof Kozlowski
2023-03-21 9:02 ` Arınç ÜNAL
2023-03-24 22:10 ` Rob Herring
2023-03-24 23:15 ` Arınç ÜNAL
2023-03-24 22:13 ` Rob Herring
2023-03-21 4:29 ` Sergio Paracuellos
2023-03-20 18:01 ` Krzysztof Kozlowski
2023-03-20 18:07 ` Arınç ÜNAL
2023-03-20 18:11 ` Krzysztof Kozlowski
2023-03-20 18:23 ` Arınç ÜNAL
2023-03-21 6:34 ` Krzysztof Kozlowski
2023-03-20 16:18 ` [PATCH 02/10] clk: ralink: add clock and reset driver for MTMIPS SoCs Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 03/10] mips: ralink: rt288x: remove clock related code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 04/10] mips: ralink: rt305x: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 05/10] mips: ralink: rt3883: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 06/10] mips: ralink: mt7620: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 07/10] mips: ralink: remove clock related function prototypes Sergio Paracuellos
2023-03-20 19:38 ` Stephen Boyd
2023-03-20 20:17 ` Sergio Paracuellos
2023-03-20 21:21 ` Stephen Boyd [this message]
2023-03-21 4:23 ` Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 08/10] mips: ralink: remove reset related code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 09/10] mips: ralink: get cpu rate from new driver code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 10/10] MAINTAINERS: add Mediatek MTMIPS Clock maintainer Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90dd1f841e7941d8b5931ef68cd6d14e.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.