All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Hulk Robot <hulkci@huawei.com>, James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	Scott Branden <scott.branden@broadcom.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Tushar Sugandhi <tusharsu@linux.microsoft.com>
Cc: linux-security-module@vger.kernel.org,
	linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH -next] integrity: Make function integrity_add_key() static
Date: Fri, 12 Feb 2021 11:21:43 -0500	[thread overview]
Message-ID: <90e088c262517a608324d523b67fef1ef007370f.camel@linux.ibm.com> (raw)
In-Reply-To: <20210210080131.1209889-1-weiyongjun1@huawei.com>

[Cc: linux-integrity]

On Wed, 2021-02-10 at 08:01 +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> security/integrity/digsig.c:146:12: warning:
>  symbol 'integrity_add_key' was not declared. Should it be static?
> 
> This function is not used outside of digsig.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thanks!   The patch is now queued.
  
Mimi


      parent reply	other threads:[~2021-02-12 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  8:01 [PATCH -next] integrity: Make function integrity_add_key() static Wei Yongjun
2021-02-10 20:52 ` Kees Cook
2021-02-12 16:11 ` Nayna
2021-02-12 16:21 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90e088c262517a608324d523b67fef1ef007370f.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hulkci@huawei.com \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=scott.branden@broadcom.com \
    --cc=serge@hallyn.com \
    --cc=tusharsu@linux.microsoft.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.