From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v1] mptcp: fix cast type of is_fully_established
Date: Tue, 25 Mar 2025 11:49:50 +0100 [thread overview]
Message-ID: <90ea00cb-d57e-411e-9108-624aad2194b9@kernel.org> (raw)
In-Reply-To: <27b15c2de6fe36088ef95c4823d9e4a6d7bc9ec6.1742898970.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 25/03/2025 11:36, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The parameter type of mptcp_is_fully_established() is 'struct sock *',
> not 'void *', so this patch casts 'msk' as 'struct sock *' instead of
> 'void *' in mptcp_can_accept_new_subflow().
Indeed, but it is not really wrong to use 'void *'. Also, it looks like
we are doing that in most other files from the net/mptcp directory.
If you have to modify this line for another commit, feel free to include
the modification in this commit if it bothers you ("While at it, use the
proper cast instead of the generic 'void *'"), but it can also be left
unchanged I think.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-03-25 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 10:36 [PATCH mptcp-next v1] mptcp: fix cast type of is_fully_established Geliang Tang
2025-03-25 10:49 ` Matthieu Baerts [this message]
2025-03-26 1:08 ` Geliang Tang
2025-03-26 10:17 ` Matthieu Baerts
2025-03-26 10:24 ` Geliang Tang
2025-03-25 11:45 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ea00cb-d57e-411e-9108-624aad2194b9@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.