All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemek Socha <soprwa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Subject: Re: BISECTED- amd-staging-drm-next, xorg-server segfault A6-6310 APU - R4 Mullins.
Date: Thu, 10 Jan 2019 17:06:26 +0100	[thread overview]
Message-ID: <91019770.5DcfmtkFX1@eclipse> (raw)
In-Reply-To: <70fd7291-8d04-f7f9-b31b-b19e9ba36f12-otUistvHUpPR7s880joybQ@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 4091 bytes --]

Dnia czwartek, 10 stycznia 2019 12:25:01 CET piszesz:
> On 2019-01-10 10:44 a.m., Przemek Socha wrote:
> > Hi,
> > after yesterday's fetch of amd-staging-drm-next tree from agd5f git repo
> > my
> > xorg server is segfaulting when starting up.
> > 
> > I am using gentoo ~amd64, xorg-server 1.20.3, xf86-video-amdgpu-18.1.0.
> > Machine is an old Lenovo g50-45 netbook with A6-6310 APU - R4 Mullins.
> > 
> > - excerpt from Xorg.log:
> > 
> > "[    21.878] (II) AMDGPU(0): Setting screen physical size to 700 x 270
> > [    21.880] (EE)
> > [    21.880] (EE) Backtrace:
> > [    21.880] (EE) 0: /usr/bin/X (xorg_backtrace+0x4d) [0x559df051f0bd]
> > [    21.880] (EE) 1: /usr/bin/X (0x559df0376000+0x1acc89) [0x559df0522c89]
> > [    21.880] (EE) 2: /lib64/libpthread.so.0 (0x7f6f2edad000+0x14560)
> > [0x7f6f2edc1560]
> > [    21.880] (EE) 3: /usr/lib64/xorg/modules/drivers/amdgpu_drv.so
> > (0x7f6f2f32b000+0x14fce) [0x7f6f2f33ffce]
> > [    21.880] (EE) 4: /usr/lib64/xorg/modules/drivers/amdgpu_drv.so
> > (0x7f6f2f32b000+0xd1c4) [0x7f6f2f3381c4]
> > [    21.880] (EE) 5: /usr/bin/X (0x559df0376000+0xdf024) [0x559df0455024]
> > [    21.881] (EE) 6: /usr/bin/X (InitRootWindow+0x11) [0x559df03f8761]
> > [    21.881] (EE) 7: /usr/bin/X (0x559df0376000+0x5b574) [0x559df03d1574]
> > [    21.881] (EE) 8: /lib64/libc.so.6 (__libc_start_main+0xee)
> > [0x7f6f2ec054ce]
> > [    21.881] (EE) 9: /usr/bin/X (_start+0x2a) [0x559df03bb00a]
> > [    21.881] (EE)
> > [    21.881] (EE) Segmentation fault at address 0x4
> > [    21.881] (EE)
> > Fatal server error:
> > [    21.881] (EE) Caught signal 11 (Segmentation fault). Server aborting
> > [    21.881] (EE)
> > [    21.881] (EE)
> > Please consult the The X.Org Foundation support
> > 
> > 	 at http://wiki.x.org
> >  
> >  for help.
> > 
> > [    21.881] (EE) Please also check the log file at "/var/log/Xorg.0.log"
> > for additional information.
> > [    21.881] (EE)
> > [    21.881] (II) AIGLX: Suspending AIGLX clients for VT switch
> > [    21.957] (EE) Server terminated with error (1). Closing log file."
> > 
> > 
> > I am not sure if I didn't mess up anything, but git bisect gives the
> > results:
> > 
> > [...]
> > 
> > 79c6b898011958fba7722528d567b64e1cdc8dbe is the first bad commit
> > commit 79c6b898011958fba7722528d567b64e1cdc8dbe
> > Author: Yu Zhao <yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> > Date:   Mon Jan 7 15:51:14 2019 -0700
> > 
> >     drm/amdgpu: validate user pitch alignment
> >     
> >     Userspace may request pitch alignment that is not supported by GPU.
> >     Some requests 32, but GPU ignores it and uses default 64 when cpp is
> >     4. If GEM object is allocated based on the smaller alignment, GPU
> >     DMA will go out of bound.
> >     
> >     Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # v4.2+
> >     Reviewed-by: Michel Dänzer <michel.daenzer-5C7GfCeVMHo@public.gmane.org>
> >     Signed-off-by: Yu Zhao <yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> > :
> > :040000 040000 5338964e9975e461ceedb27f6342c2896f54607a
> > 
> > ed2f04fc9b665b27b1905fd60b7d2a3933d1fdcc M      drivers
> 
> Thanks for tracking this down. It turns out the check added by this
> change is too strict for linear framebuffers. I've sent a patch
> reverting it for review: https://patchwork.freedesktop.org/patch/276122/
> 
> Sorry I didn't realize this issue when reviewing this change.

Thanks for the swift response and sorry about the delay on my side.

Unfortunately applying this patch does not help in my case (but could be 
necessarily after all). 

To start xorg-server I had to apply your patch, and, on top of this, reverse 
the  "drm/amdgpu: validate user pitch alignment" - 
79c6b898011958fba7722528d567b64e1cdc8dbe.

Now xorg server starts, but I have doubt about system stability because 
description of reverted one is saying that "if GEM object is allocated based 
on the smaller alignment, GPU
DMA will go out of bound". 
Sorry about being a layman on this.

Thanks,
Przemek.

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-01-10 16:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  9:44 BISECTED- amd-staging-drm-next, xorg-server segfault A6-6310 APU - R4 Mullins Przemek Socha
2019-01-10 11:25 ` Michel Dänzer
     [not found]   ` <70fd7291-8d04-f7f9-b31b-b19e9ba36f12-otUistvHUpPR7s880joybQ@public.gmane.org>
2019-01-10 16:06     ` Przemek Socha [this message]
2019-01-10 16:22       ` Michel Dänzer
     [not found]         ` <641eb681-2952-19d9-5c74-01616a51c6ec-otUistvHUpPR7s880joybQ@public.gmane.org>
2019-01-10 17:56           ` Przemek Socha
2019-01-11 15:27             ` Michel Dänzer
     [not found]               ` <8033aaf7-2e86-9414-c68a-7b17e331f212-otUistvHUpPR7s880joybQ@public.gmane.org>
2019-01-11 21:37                 ` pitch alignment questions Yu Zhao
     [not found]                   ` <20190111213747.GA148783-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-01-14 17:44                     ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91019770.5DcfmtkFX1@eclipse \
    --to=soprwa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
    --cc=yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.