From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBfMw-0005CP-Cr for ath10k@lists.infradead.org; Sat, 21 Sep 2019 13:24:12 +0000 MIME-Version: 1.0 Date: Sat, 21 Sep 2019 21:24:07 +0800 From: Yibo Zhao Subject: Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <877e617qg2.fsf@toke.dk> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-2-git-send-email-yiboz@codeaurora.org> <87pnjyiq7o.fsf@toke.dk> <87sgothmpy.fsf@toke.dk> <8cdece5c030fd95817fb099021c38613@codeaurora.org> <87tv98fu6l.fsf@toke.dk> <1b4ab006d9b5c88035845aaac193ef48@codeaurora.org> <8736gre3bm.fsf@toke.dk> <198124204167325252fcfcd65e3f2733@codeaurora.org> <87ftkp7uuz.fsf@toke.dk> <4574cce4079f8dab2b2bf223431a6eae@codeaurora.org> <877e617qg2.fsf@toke.dk> Message-ID: <910d9bb5f9016b29fb2aaeb0b89bac38@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOS0wOS0yMSAyMTowMiwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFlp Ym8gWmhhbyA8eWlib3pAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiAKPj4gT24gMjAxOS0wOS0y MSAxOToyNywgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4gWWlibyBaaGFvIDx5 aWJvekBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+Pj4gCj4+Pj4gT24gMjAxOS0wOS0yMCAxNzox NSwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4+PiBZaWJvIFpoYW8gPHlpYm96 QGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4+Pj4+IAo+Pj4+Pj4gT24gMjAxOS0wOS0xOSAxODoz NywgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4+Pj4+IFlpYm8gWmhhbyA8eWli b3pAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPj4+Pj4+PiAKPj4+Pj4+Pj4gT24gMjAxOS0wOS0x OCAxOToyMywgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4+Pj4+Pj4gWWlibyBa aGFvIDx5aWJvekBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4g T24gMjAxOS0wOS0xOCAwNToxMCwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4+ Pj4+Pj4+PiBZaWJvIFpoYW8gPHlpYm96QGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4+Pj4+Pj4+ Pj4+IAo+Pj4+Pj4+Pj4+Pj4gSW4gYSBsb29wIHR4cXMgZGVxdWV1ZSBzY2VuYXJpbywgaWYgdGhl IGZpcnN0IHR4cSBpbiB0aGUKPj4+Pj4+Pj4+Pj4+IHJidHJlZQo+Pj4+Pj4+Pj4+Pj4gZ2V0cwo+ Pj4+Pj4+Pj4+Pj4gcmVtb3ZlZCBmcm9tIHJidHJlZSBpbW1lZGlhdGVseSBpbiB0aGUgCj4+Pj4+ Pj4+Pj4+PiBpZWVlODAyMTFfcmV0dXJuX3R4cSgpLAo+Pj4+Pj4+Pj4+Pj4gdGhlCj4+Pj4+Pj4+ Pj4+PiBsb29wIHdpbGwgYnJlYWsgc29vbiBpbiB0aGUgaWVlZTgwMjExX25leHRfdHhxKCkgZHVl IHRvCj4+Pj4+Pj4+Pj4+PiBzY2hlZHVsZV9wb3MKPj4+Pj4+Pj4+Pj4+IG5vdCBsZWFkaW5nIHRv IHRoZSBzZWNvbmQgdHhxIGluIHRoZSByYnRyZWUuIFRodXMsIGRlZmVyaW5nCj4+Pj4+Pj4+Pj4+ PiB0aGUKPj4+Pj4+Pj4+Pj4+IHJlbW92YWwgcmlnaHQgYmVmb3JlIHRoZSBlbmQgb2YgdGhpcyBz Y2hlZHVsZSByb3VuZC4KPj4+Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4+Pj4gQ28tZGV2ZWxvcGVkLWJ5 OiBZaWJvIFpoYW8gPHlpYm96QGNvZGVhdXJvcmEub3JnPgo+Pj4+Pj4+Pj4+Pj4gU2lnbmVkLW9m Zi1ieTogWWlibyBaaGFvIDx5aWJvekBjb2RlYXVyb3JhLm9yZz4KPj4+Pj4+Pj4+Pj4+IFNpZ25l ZC1vZmYtYnk6IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9rZUB0b2tlLmRrPgo+Pj4+Pj4+ Pj4+PiAKPj4+Pj4+Pj4+Pj4gSSBkaWRuJ3Qgd3JpdGUgdGhpcyBwYXRjaCwgc28gcGxlYXNlIGRv bid0IHVzZSBteSBzaWduLW9mZi4KPj4+Pj4+Pj4+Pj4gSSdsbAo+Pj4+Pj4+Pj4+PiBhZGQKPj4+ Pj4+Pj4+Pj4gYWNrIG9yIHJldmlldyB0YWdzIGFzIGFwcHJvcHJpYXRlIGluIHJlcGx5OyBidXQg YSBmZXcgCj4+Pj4+Pj4+Pj4+IGNvbW1lbnRzCj4+Pj4+Pj4+Pj4+IGZpcnN0Ogo+Pj4+Pj4+Pj4+ PiAKPj4+Pj4+Pj4+Pj4+IC0tLQo+Pj4+Pj4+Pj4+Pj4gIGluY2x1ZGUvbmV0L21hYzgwMjExLmgg ICAgIHwgMTYgKysrKysrKysrKy0tCj4+Pj4+Pj4+Pj4+PiAgbmV0L21hYzgwMjExL2llZWU4MDIx MV9pLmggfCAgMyArKysKPj4+Pj4+Pj4+Pj4+ICBuZXQvbWFjODAyMTEvbWFpbi5jICAgICAgICB8 ICA2ICsrKysrCj4+Pj4+Pj4+Pj4+PiAgbmV0L21hYzgwMjExL3R4LmMgICAgICAgICAgfCA2Mwo+ Pj4+Pj4+Pj4+Pj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LQo+Pj4+Pj4+Pj4+Pj4gIDQgZmlsZXMgY2hhbmdlZCwgODMgaW5zZXJ0aW9ucygrKSwgNSBkZWxl dGlvbnMoLSkKPj4+Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv bmV0L21hYzgwMjExLmggYi9pbmNsdWRlL25ldC9tYWM4MDIxMS5oCj4+Pj4+Pj4+Pj4+PiBpbmRl eCBhYzJlZDhlLi5iYTVhMzQ1IDEwMDY0NAo+Pj4+Pj4+Pj4+Pj4gLS0tIGEvaW5jbHVkZS9uZXQv bWFjODAyMTEuaAo+Pj4+Pj4+Pj4+Pj4gKysrIGIvaW5jbHVkZS9uZXQvbWFjODAyMTEuaAo+Pj4+ Pj4+Pj4+Pj4gQEAgLTkyNSw2ICs5MjUsOCBAQCBzdHJ1Y3QgaWVlZTgwMjExX3R4X3JhdGUgewo+ Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiAgI2RlZmluZSBJRUVFODAyMTFfTUFYX1RYX1JFVFJZ CQkzMQo+Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiArI2RlZmluZSBJRUVFODAyMTFfQUlSVElN RV9UWFFfUk1fQ0hLX0lOVFZfSU5fTVMgMTAwCj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiAg c3RhdGljIGlubGluZSB2b2lkIGllZWU4MDIxMV9yYXRlX3NldF92aHQoc3RydWN0Cj4+Pj4+Pj4+ Pj4+PiBpZWVlODAyMTFfdHhfcmF0ZQo+Pj4+Pj4+Pj4+Pj4gKnJhdGUsCj4+Pj4+Pj4+Pj4+PiAg CQkJCQkgIHU4IG1jcywgdTggbnNzKQo+Pj4+Pj4+Pj4+Pj4gIHsKPj4+Pj4+Pj4+Pj4+IEBAIC02 MjMyLDcgKzYyMzQsOCBAQCBzdHJ1Y3Qgc2tfYnVmZgo+Pj4+Pj4+Pj4+Pj4gKmllZWU4MDIxMV90 eF9kZXF1ZXVlKHN0cnVjdAo+Pj4+Pj4+Pj4+Pj4gaWVlZTgwMjExX2h3ICpodywKPj4+Pj4+Pj4+ Pj4+ICAgKiBAYWM6IEFDIG51bWJlciB0byByZXR1cm4gcGFja2V0cyBmcm9tLgo+Pj4+Pj4+Pj4+ Pj4gICAqCj4+Pj4+Pj4+Pj4+PiAgICogU2hvdWxkIG9ubHkgYmUgY2FsbGVkIGJldHdlZW4gY2Fs bHMgdG8KPj4+Pj4+Pj4+Pj4+IGllZWU4MDIxMV90eHFfc2NoZWR1bGVfc3RhcnQoKQo+Pj4+Pj4+ Pj4+Pj4gLSAqIGFuZCBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZCgpLgo+Pj4+Pj4+Pj4+Pj4g KyAqIGFuZCBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZCgpLiBJZiB0aGUgdHhxIGlzIGVtcHR5 LCAKPj4+Pj4+Pj4+Pj4+IGl0Cj4+Pj4+Pj4+Pj4+PiB3aWxsCj4+Pj4+Pj4+Pj4+PiBiZQo+Pj4+ Pj4+Pj4+Pj4gYWRkZWQKPj4+Pj4+Pj4+Pj4+ICsgKiB0byBhIHJlbW92ZSBsaXN0IGFuZCBnZXQg cmVtb3ZlZCBsYXRlci4KPj4+Pj4+Pj4+Pj4+ICAgKiBSZXR1cm5zIHRoZSBuZXh0IHR4cSBpZiBz dWNjZXNzZnVsLCAlTlVMTCBpZiBubyBxdWV1ZSBpcwo+Pj4+Pj4+Pj4+Pj4gZWxpZ2libGUuCj4+ Pj4+Pj4+Pj4+PiBJZiBhIHR4cQo+Pj4+Pj4+Pj4+Pj4gICAqIGlzIHJldHVybmVkLCBpdCBzaG91 bGQgYmUgcmV0dXJuZWQgd2l0aAo+Pj4+Pj4+Pj4+Pj4gaWVlZTgwMjExX3JldHVybl90eHEoKQo+ Pj4+Pj4+Pj4+Pj4gYWZ0ZXIgdGhlCj4+Pj4+Pj4+Pj4+PiAgICogZHJpdmVyIGhhcyBmaW5pc2hl ZCBzY2hlZHVsaW5nIGl0Lgo+Pj4+Pj4+Pj4+Pj4gQEAgLTYyNjgsNyArNjI3MSw4IEBAIHZvaWQg Cj4+Pj4+Pj4+Pj4+PiBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX3N0YXJ0KHN0cnVjdAo+Pj4+Pj4+ Pj4+Pj4gaWVlZTgwMjExX2h3ICpodywgdTggYWMpCj4+Pj4+Pj4+Pj4+PiAgICogQGh3OiBwb2lu dGVyIGFzIG9idGFpbmVkIGZyb20gaWVlZTgwMjExX2FsbG9jX2h3KCkKPj4+Pj4+Pj4+Pj4+ICAg KiBAYWM6IEFDIG51bWJlciB0byBhY3F1aXJlIGxvY2tzIGZvcgo+Pj4+Pj4+Pj4+Pj4gICAqCj4+ Pj4+Pj4+Pj4+PiAtICogUmVsZWFzZSBsb2NrcyBwcmV2aW91c2x5IGFjcXVpcmVkIGJ5Cj4+Pj4+ Pj4+Pj4+PiBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZCgpLgo+Pj4+Pj4+Pj4+Pj4gKyAqIFJl bGVhc2UgbG9ja3MgcHJldmlvdXNseSBhY3F1aXJlZCBieQo+Pj4+Pj4+Pj4+Pj4gaWVlZTgwMjEx X3R4cV9zY2hlZHVsZV9lbmQoKS4KPj4+Pj4+Pj4+Pj4+IENoZWNrCj4+Pj4+Pj4+Pj4+PiArICog YW5kIHJlbW92ZSB0aGUgZW1wdHkgdHhxIGZyb20gcmItdHJlZS4KPj4+Pj4+Pj4+Pj4+ICAgKi8K Pj4+Pj4+Pj4+Pj4+ICB2b2lkIGllZWU4MDIxMV90eHFfc2NoZWR1bGVfZW5kKHN0cnVjdCBpZWVl ODAyMTFfaHcgKmh3LCB1OAo+Pj4+Pj4+Pj4+Pj4gYWMpCj4+Pj4+Pj4+Pj4+PiAgCV9fcmVsZWFz ZXModHhxX2xvY2spOwo+Pj4+Pj4+Pj4+Pj4gQEAgLTYyODcsNiArNjI5MSwxNCBAQCB2b2lkIGll ZWU4MDIxMV9zY2hlZHVsZV90eHEoc3RydWN0Cj4+Pj4+Pj4+Pj4+PiBpZWVlODAyMTFfaHcKPj4+ Pj4+Pj4+Pj4+ICpodywgc3RydWN0IGllZWU4MDIxMV90eHEgKnR4cSkKPj4+Pj4+Pj4+Pj4+ICAJ X19hY3F1aXJlcyh0eHFfbG9jaykgX19yZWxlYXNlcyh0eHFfbG9jayk7Cj4+Pj4+Pj4+Pj4+PiAK Pj4+Pj4+Pj4+Pj4+ICAvKioKPj4+Pj4+Pj4+Pj4+ICsgKiBpZWVlODAyMTFfdHhxc19jaGVjayAt IENoZWNrIHR4cXMgd2FpdGluZyBmb3IgcmVtb3ZhbAo+Pj4+Pj4+Pj4+Pj4gKyAqCj4+Pj4+Pj4+ Pj4+PiArICogQHRtcjogcG9pbnRlciBhcyBvYnRhaW5lZCBmcm9tIGxvY2FsCj4+Pj4+Pj4+Pj4+ PiArICoKPj4+Pj4+Pj4+Pj4+ICsgKi8KPj4+Pj4+Pj4+Pj4+ICt2b2lkIGllZWU4MDIxMV90eHFz X2NoZWNrKHN0cnVjdCB0aW1lcl9saXN0ICp0bXIpOwo+Pj4+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4+ Pj4gKy8qKgo+Pj4+Pj4+Pj4+Pj4gICAqIGllZWU4MDIxMV90eHFfbWF5X3RyYW5zbWl0IC0gY2hl Y2sgd2hldGhlciBUWFEgaXMgCj4+Pj4+Pj4+Pj4+PiBhbGxvd2VkCj4+Pj4+Pj4+Pj4+PiB0bwo+ Pj4+Pj4+Pj4+Pj4gdHJhbnNtaXQKPj4+Pj4+Pj4+Pj4+ICAgKgo+Pj4+Pj4+Pj4+Pj4gICAqIFRo aXMgZnVuY3Rpb24gaXMgdXNlZCB0byBjaGVjayB3aGV0aGVyIGdpdmVuIHR4cSBpcwo+Pj4+Pj4+ Pj4+Pj4gYWxsb3dlZAo+Pj4+Pj4+Pj4+Pj4gdG8KPj4+Pj4+Pj4+Pj4+IHRyYW5zbWl0IGJ5Cj4+ Pj4+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvbmV0L21hYzgwMjExL2llZWU4MDIxMV9pLmgKPj4+Pj4+ Pj4+Pj4+IGIvbmV0L21hYzgwMjExL2llZWU4MDIxMV9pLmgKPj4+Pj4+Pj4+Pj4+IGluZGV4IGE0 NTU2ZjkuLjQ5YWExNDNlIDEwMDY0NAo+Pj4+Pj4+Pj4+Pj4gLS0tIGEvbmV0L21hYzgwMjExL2ll ZWU4MDIxMV9pLmgKPj4+Pj4+Pj4+Pj4+ICsrKyBiL25ldC9tYWM4MDIxMS9pZWVlODAyMTFfaS5o Cj4+Pj4+Pj4+Pj4+PiBAQCAtODQ3LDYgKzg0Nyw3IEBAIHN0cnVjdCB0eHFfaW5mbyB7Cj4+Pj4+ Pj4+Pj4+PiAgCXN0cnVjdCBjb2RlbF9zdGF0cyBjc3RhdHM7Cj4+Pj4+Pj4+Pj4+PiAgCXN0cnVj dCBza19idWZmX2hlYWQgZnJhZ3M7Cj4+Pj4+Pj4+Pj4+PiAgCXN0cnVjdCByYl9ub2RlIHNjaGVk dWxlX29yZGVyOwo+Pj4+Pj4+Pj4+Pj4gKwlzdHJ1Y3QgbGlzdF9oZWFkIGNhbmRpZGF0ZTsKPj4+ Pj4+Pj4+Pj4+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4+ Pj4gIAkvKiBrZWVwIGxhc3QhICovCj4+Pj4+Pj4+Pj4+PiBAQCAtMTE0NSw2ICsxMTQ2LDggQEAg c3RydWN0IGllZWU4MDIxMV9sb2NhbCB7Cj4+Pj4+Pj4+Pj4+PiAgCXU2NCBhaXJ0aW1lX3ZfdFtJ RUVFODAyMTFfTlVNX0FDU107Cj4+Pj4+Pj4+Pj4+PiAgCXU2NCBhaXJ0aW1lX3dlaWdodF9zdW1b SUVFRTgwMjExX05VTV9BQ1NdOwo+Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiArCXN0cnVjdCBs aXN0X2hlYWQgcmVtb3ZlX2xpc3RbSUVFRTgwMjExX05VTV9BQ1NdOwo+Pj4+Pj4+Pj4+Pj4gKwlz dHJ1Y3QgdGltZXJfbGlzdCByZW1vdmVfdGltZXI7Cj4+Pj4+Pj4+Pj4+PiAgCXUxNiBhaXJ0aW1l X2ZsYWdzOwo+Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiAgCWNvbnN0IHN0cnVjdCBpZWVlODAy MTFfb3BzICpvcHM7Cj4+Pj4+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvbmV0L21hYzgwMjExL21haW4u YyBiL25ldC9tYWM4MDIxMS9tYWluLmMKPj4+Pj4+Pj4+Pj4+IGluZGV4IGU5ZmZhOGUuLjc4ZmUy NGEgMTAwNjQ0Cj4+Pj4+Pj4+Pj4+PiAtLS0gYS9uZXQvbWFjODAyMTEvbWFpbi5jCj4+Pj4+Pj4+ Pj4+PiArKysgYi9uZXQvbWFjODAyMTEvbWFpbi5jCj4+Pj4+Pj4+Pj4+PiBAQCAtNjY3LDEwICs2 NjcsMTUgQEAgc3RydWN0IGllZWU4MDIxMV9odwo+Pj4+Pj4+Pj4+Pj4gKmllZWU4MDIxMV9hbGxv Y19od19ubShzaXplX3QgcHJpdl9kYXRhX2xlbiwKPj4+Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4+Pj4g IAlmb3IgKGkgPSAwOyBpIDwgSUVFRTgwMjExX05VTV9BQ1M7IGkrKykgewo+Pj4+Pj4+Pj4+Pj4g IAkJbG9jYWwtPmFjdGl2ZV90eHFzW2ldID0gUkJfUk9PVF9DQUNIRUQ7Cj4+Pj4+Pj4+Pj4+PiAr CQlJTklUX0xJU1RfSEVBRCgmbG9jYWwtPnJlbW92ZV9saXN0W2ldKTsKPj4+Pj4+Pj4+Pj4+ICAJ CXNwaW5fbG9ja19pbml0KCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2ldKTsKPj4+Pj4+Pj4+Pj4+ ICAJfQo+Pj4+Pj4+Pj4+Pj4gIAlsb2NhbC0+YWlydGltZV9mbGFncyA9IEFJUlRJTUVfVVNFX1RY IHwgQUlSVElNRV9VU0VfUlg7Cj4+Pj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+Pj4+ICsJdGltZXJfc2V0 dXAoJmxvY2FsLT5yZW1vdmVfdGltZXIsIGllZWU4MDIxMV90eHFzX2NoZWNrLCAKPj4+Pj4+Pj4+ Pj4+IDApOwo+Pj4+Pj4+Pj4+Pj4gKwltb2RfdGltZXIoJmxvY2FsLT5yZW1vdmVfdGltZXIsCj4+ Pj4+Pj4+Pj4+PiArCQkgIGppZmZpZXMgKwo+Pj4+Pj4+Pj4+Pj4gbXNlY3NfdG9famlmZmllcyhJ RUVFODAyMTFfQUlSVElNRV9UWFFfUk1fQ0hLX0lOVFZfSU5fTVMpKTsKPj4+Pj4+Pj4+Pj4+ICsK Pj4+Pj4+Pj4+Pj4+ICAJSU5JVF9MSVNUX0hFQUQoJmxvY2FsLT5jaGFuY3R4X2xpc3QpOwo+Pj4+ Pj4+Pj4+Pj4gIAltdXRleF9pbml0KCZsb2NhbC0+Y2hhbmN0eF9tdHgpOwo+Pj4+Pj4+Pj4+Pj4g Cj4+Pj4+Pj4+Pj4+PiBAQCAtMTMwNSw2ICsxMzEwLDcgQEAgdm9pZCBpZWVlODAyMTFfdW5yZWdp c3Rlcl9odyhzdHJ1Y3QKPj4+Pj4+Pj4+Pj4+IGllZWU4MDIxMV9odwo+Pj4+Pj4+Pj4+Pj4gKmh3 KQo+Pj4+Pj4+Pj4+Pj4gIAl0YXNrbGV0X2tpbGwoJmxvY2FsLT50eF9wZW5kaW5nX3Rhc2tsZXQp Owo+Pj4+Pj4+Pj4+Pj4gIAl0YXNrbGV0X2tpbGwoJmxvY2FsLT50YXNrbGV0KTsKPj4+Pj4+Pj4+ Pj4+IAo+Pj4+Pj4+Pj4+Pj4gKwlkZWxfdGltZXJfc3luYygmbG9jYWwtPnJlbW92ZV90aW1lcik7 Cj4+Pj4+Pj4+Pj4+PiAgI2lmZGVmIENPTkZJR19JTkVUCj4+Pj4+Pj4+Pj4+PiAgCXVucmVnaXN0 ZXJfaW5ldGFkZHJfbm90aWZpZXIoJmxvY2FsLT5pZmFfbm90aWZpZXIpOwo+Pj4+Pj4+Pj4+Pj4g ICNlbmRpZgo+Pj4+Pj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL25ldC9tYWM4MDIxMS90eC5jIGIvbmV0 L21hYzgwMjExL3R4LmMKPj4+Pj4+Pj4+Pj4+IGluZGV4IGQwMGJhYWEuLjQyY2EwMTAgMTAwNjQ0 Cj4+Pj4+Pj4+Pj4+PiAtLS0gYS9uZXQvbWFjODAyMTEvdHguYwo+Pj4+Pj4+Pj4+Pj4gKysrIGIv bmV0L21hYzgwMjExL3R4LmMKPj4+Pj4+Pj4+Pj4+IEBAIC0xNDUwLDYgKzE0NTAsNyBAQCB2b2lk IGllZWU4MDIxMV90eHFfaW5pdChzdHJ1Y3QKPj4+Pj4+Pj4+Pj4+IGllZWU4MDIxMV9zdWJfaWZf ZGF0YSAqc2RhdGEsCj4+Pj4+Pj4+Pj4+PiAgCWNvZGVsX3N0YXRzX2luaXQoJnR4cWktPmNzdGF0 cyk7Cj4+Pj4+Pj4+Pj4+PiAgCV9fc2tiX3F1ZXVlX2hlYWRfaW5pdCgmdHhxaS0+ZnJhZ3MpOwo+ Pj4+Pj4+Pj4+Pj4gIAlSQl9DTEVBUl9OT0RFKCZ0eHFpLT5zY2hlZHVsZV9vcmRlcik7Cj4+Pj4+ Pj4+Pj4+PiArCUlOSVRfTElTVF9IRUFEKCZ0eHFpLT5jYW5kaWRhdGUpOwo+Pj4+Pj4+Pj4+Pj4g Cj4+Pj4+Pj4+Pj4+PiAgCXR4cWktPnR4cS52aWYgPSAmc2RhdGEtPnZpZjsKPj4+Pj4+Pj4+Pj4+ IAo+Pj4+Pj4+Pj4+Pj4gQEAgLTM3MjQsNiArMzcyNSw5IEBAIHZvaWQgaWVlZTgwMjExX3NjaGVk dWxlX3R4cShzdHJ1Y3QKPj4+Pj4+Pj4+Pj4+IGllZWU4MDIxMV9odwo+Pj4+Pj4+Pj4+Pj4gKmh3 LAo+Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiAgCXNwaW5fbG9ja19iaCgmbG9jYWwtPmFjdGl2 ZV90eHFfbG9ja1thY10pOwo+Pj4+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+Pj4+PiArCWlmICghbGlzdF9l bXB0eSgmdHhxaS0+Y2FuZGlkYXRlKSkKPj4+Pj4+Pj4+Pj4+ICsJCWxpc3RfZGVsX2luaXQoJnR4 cWktPmNhbmRpZGF0ZSk7Cj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiAgCWlmICghUkJfRU1Q VFlfTk9ERSgmdHhxaS0+c2NoZWR1bGVfb3JkZXIpKQo+Pj4+Pj4+Pj4+Pj4gIAkJZ290byBvdXQ7 Cj4+Pj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+Pj4+IEBAIC0zNzgzLDYgKzM3ODcsMjAgQEAgc3RhdGlj IHZvaWQKPj4+Pj4+Pj4+Pj4+IF9faWVlZTgwMjExX3Vuc2NoZWR1bGVfdHhxKHN0cnVjdAo+Pj4+ Pj4+Pj4+Pj4gaWVlZTgwMjExX2h3ICpodywKPj4+Pj4+Pj4+Pj4+ICAJUkJfQ0xFQVJfTk9ERSgm dHhxaS0+c2NoZWR1bGVfb3JkZXIpOwo+Pj4+Pj4+Pj4+Pj4gIH0KPj4+Pj4+Pj4+Pj4+IAo+Pj4+ Pj4+Pj4+Pj4gK3ZvaWQgaWVlZTgwMjExX3JlbW92ZV90eHEoc3RydWN0IGllZWU4MDIxMV9odyAq aHcsCj4+Pj4+Pj4+Pj4+PiArCQkJICBzdHJ1Y3QgaWVlZTgwMjExX3R4cSAqdHhxKQo+Pj4+Pj4+ Pj4+Pj4gK3sKPj4+Pj4+Pj4+Pj4+ICsJc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9jYWwgPSBo d190b19sb2NhbChodyk7Cj4+Pj4+Pj4+Pj4+PiArCXN0cnVjdCB0eHFfaW5mbyAqdHhxaSA9IHRv X3R4cV9pbmZvKHR4cSk7Cj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiArCWxvY2tkZXBfYXNz ZXJ0X2hlbGQoJmxvY2FsLT5hY3RpdmVfdHhxX2xvY2tbdHhxLT5hY10pOwo+Pj4+Pj4+Pj4+Pj4g Kwo+Pj4+Pj4+Pj4+Pj4gKwlpZiAoIVJCX0VNUFRZX05PREUoJnR4cWktPnNjaGVkdWxlX29yZGVy KSkgewo+Pj4+Pj4+Pj4+Pj4gKwkJX19pZWVlODAyMTFfdW5zY2hlZHVsZV90eHEoaHcsIHR4cSk7 Cj4+Pj4+Pj4+Pj4+PiArCQlsaXN0X2RlbF9pbml0KCZ0eHFpLT5jYW5kaWRhdGUpOwo+Pj4+Pj4+ Pj4+Pj4gKwl9Cj4+Pj4+Pj4+Pj4+PiArfQo+Pj4+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4+Pj4gIHZv aWQgaWVlZTgwMjExX3Vuc2NoZWR1bGVfdHhxKHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LAo+Pj4+ Pj4+Pj4+Pj4gIAkJCSAgICAgIHN0cnVjdCBpZWVlODAyMTFfdHhxICp0eHEpCj4+Pj4+Pj4+Pj4+ PiAgCV9fYWNxdWlyZXModHhxX2xvY2spIF9fcmVsZWFzZXModHhxX2xvY2spCj4+Pj4+Pj4+Pj4+ PiBAQCAtMzc5MCw3ICszODA4LDcgQEAgdm9pZCBpZWVlODAyMTFfdW5zY2hlZHVsZV90eHEoc3Ry dWN0Cj4+Pj4+Pj4+Pj4+PiBpZWVlODAyMTFfaHcgKmh3LAo+Pj4+Pj4+Pj4+Pj4gIAlzdHJ1Y3Qg aWVlZTgwMjExX2xvY2FsICpsb2NhbCA9IGh3X3RvX2xvY2FsKGh3KTsKPj4+Pj4+Pj4+Pj4+IAo+ Pj4+Pj4+Pj4+Pj4gIAlzcGluX2xvY2tfYmgoJmxvY2FsLT5hY3RpdmVfdHhxX2xvY2tbdHhxLT5h Y10pOwo+Pj4+Pj4+Pj4+Pj4gLQlfX2llZWU4MDIxMV91bnNjaGVkdWxlX3R4cShodywgdHhxKTsK Pj4+Pj4+Pj4+Pj4+ICsJaWVlZTgwMjExX3JlbW92ZV90eHEoaHcsIHR4cSk7Cj4+Pj4+Pj4+Pj4+ PiAgCXNwaW5fdW5sb2NrX2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW3R4cS0+YWNdKTsKPj4+ Pj4+Pj4+Pj4+ICB9Cj4+Pj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+Pj4+IEBAIC0zODAzLDExICszODIx LDQ4IEBAIHZvaWQgaWVlZTgwMjExX3JldHVybl90eHEoc3RydWN0Cj4+Pj4+Pj4+Pj4+PiBpZWVl ODAyMTFfaHcKPj4+Pj4+Pj4+Pj4+ICpodywKPj4+Pj4+Pj4+Pj4+ICAJbG9ja2RlcF9hc3NlcnRf aGVsZCgmbG9jYWwtPmFjdGl2ZV90eHFfbG9ja1t0eHEtPmFjXSk7Cj4+Pj4+Pj4+Pj4+PiAKPj4+ Pj4+Pj4+Pj4+ICAJaWYgKCFSQl9FTVBUWV9OT0RFKCZ0eHFpLT5zY2hlZHVsZV9vcmRlcikgJiYK Pj4+Pj4+Pj4+Pj4+IC0JICAgIChza2JfcXVldWVfZW1wdHkoJnR4cWktPmZyYWdzKSAmJgo+Pj4+ Pj4+Pj4+Pj4gIXR4cWktPnRpbi5iYWNrbG9nX3BhY2tldHMpKQo+Pj4+Pj4+Pj4+Pj4gLQkJX19p ZWVlODAyMTFfdW5zY2hlZHVsZV90eHEoaHcsIHR4cSk7Cj4+Pj4+Pj4+Pj4+PiArCQkhdHhxX2hh c19xdWV1ZSgmdHhxaS0+dHhxKSAmJgo+Pj4+Pj4+Pj4+Pj4gKwkJbGlzdF9lbXB0eSgmdHhxaS0+ Y2FuZGlkYXRlKSkKPj4+Pj4+Pj4+Pj4+ICsJCWxpc3RfYWRkX3RhaWwoJnR4cWktPmNhbmRpZGF0 ZSwKPj4+Pj4+Pj4+Pj4+ICZsb2NhbC0+cmVtb3ZlX2xpc3RbdHhxLT5hY10pOwo+Pj4+Pj4+Pj4+ Pj4gKwo+Pj4+Pj4+Pj4+Pj4gIH0KPj4+Pj4+Pj4+Pj4+ICBFWFBPUlRfU1lNQk9MKGllZWU4MDIx MV9yZXR1cm5fdHhxKTsKPj4+Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4+Pj4gK3ZvaWQgX19pZWVlODAy MTFfY2hlY2tfdHhxcyhzdHJ1Y3QgaWVlZTgwMjExX2xvY2FsICpsb2NhbCwKPj4+Pj4+Pj4+Pj4+ IGludAo+Pj4+Pj4+Pj4+Pj4gYWMpCj4+Pj4+Pj4+Pj4+PiArewo+Pj4+Pj4+Pj4+Pj4gKwlzdHJ1 Y3QgdHhxX2luZm8gKml0ZXIsICp0bXA7Cj4+Pj4+Pj4+Pj4+PiArCXN0cnVjdCBzdGFfaW5mbyAq c3RhOwo+Pj4+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4+Pj4gKwlsb2NrZGVwX2Fzc2VydF9oZWxkKCZs b2NhbC0+YWN0aXZlX3R4cV9sb2NrW2FjXSk7Cj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiAr CWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShpdGVyLCB0bXAsIAo+Pj4+Pj4+Pj4+Pj4gJmxvY2Fs LT5yZW1vdmVfbGlzdFthY10sCj4+Pj4+Pj4+Pj4+PiArCQkJCSBjYW5kaWRhdGUpIHsKPj4+Pj4+ Pj4+Pj4+ICsJCXN0YSA9IGNvbnRhaW5lcl9vZihpdGVyLT50eHEuc3RhLCBzdHJ1Y3Qgc3RhX2lu Zm8sIHN0YSk7Cj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiArCQlpZiAodHhxX2hhc19xdWV1 ZSgmaXRlci0+dHhxKSkKPj4+Pj4+Pj4+Pj4+ICsJCQlsaXN0X2RlbF9pbml0KCZpdGVyLT5jYW5k aWRhdGUpOwo+Pj4+Pj4+Pj4+Pj4gKwkJZWxzZQo+Pj4+Pj4+Pj4+Pj4gKwkJCWllZWU4MDIxMV9y ZW1vdmVfdHhxKCZsb2NhbC0+aHcsICZpdGVyLT50eHEpOwo+Pj4+Pj4+Pj4+Pj4gKwl9Cj4+Pj4+ Pj4+Pj4+PiArfQo+Pj4+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4+Pj4gK3ZvaWQgaWVlZTgwMjExX3R4 cXNfY2hlY2soc3RydWN0IHRpbWVyX2xpc3QgKnQpCj4+Pj4+Pj4+Pj4+PiArewo+Pj4+Pj4+Pj4+ Pj4gKwlzdHJ1Y3QgaWVlZTgwMjExX2xvY2FsICpsb2NhbCA9IGZyb21fdGltZXIobG9jYWwsIHQs Cj4+Pj4+Pj4+Pj4+PiByZW1vdmVfdGltZXIpOwo+Pj4+Pj4+Pj4+Pj4gKwlzdHJ1Y3QgdHhxX2lu Zm8gKml0ZXIsICp0bXA7Cj4+Pj4+Pj4+Pj4+PiArCXN0cnVjdCBzdGFfaW5mbyAqc3RhOwo+Pj4+ Pj4+Pj4+Pj4gKwlpbnQgYWM7Cj4+Pj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+Pj4+PiArCWZvciAoYWMg PSAwOyBhYyA8IElFRUU4MDIxMV9OVU1fQUNTOyBhYysrKSB7Cj4+Pj4+Pj4+Pj4+PiArCQlzcGlu X2xvY2tfYmgoJmxvY2FsLT5hY3RpdmVfdHhxX2xvY2tbYWNdKTsKPj4+Pj4+Pj4+Pj4+ICsJCV9f aWVlZTgwMjExX2NoZWNrX3R4cXMobG9jYWwsIGFjKTsKPj4+Pj4+Pj4+Pj4+ICsJCXNwaW5fdW5s b2NrX2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2FjXSk7Cj4+Pj4+Pj4+Pj4+PiArCX0KPj4+ Pj4+Pj4+Pj4+ICsKPj4+Pj4+Pj4+Pj4+ICsJbW9kX3RpbWVyKCZsb2NhbC0+cmVtb3ZlX3RpbWVy LAo+Pj4+Pj4+Pj4+Pj4gKwkJICBqaWZmaWVzICsKPj4+Pj4+Pj4+Pj4+IG1zZWNzX3RvX2ppZmZp ZXMoSUVFRTgwMjExX0FJUlRJTUVfVFhRX1JNX0NIS19JTlRWX0lOX01TKSk7Cj4+Pj4+Pj4+Pj4+ PiArfQo+Pj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+Pj4gSSdsbCBhc2sgdGhlIHNhbWUgYXMgSSBkaWQg bGFzdCB0aW1lICh3aGVyZSB5b3UgdG9sZCBtZSB0byAKPj4+Pj4+Pj4+Pj4gaG9sZAo+Pj4+Pj4+ Pj4+PiBvZmYKPj4+Pj4+Pj4+Pj4gdW50aWwgdGhpcyByb3VuZCk6Cj4+Pj4+Pj4+Pj4+IAo+Pj4+ Pj4+Pj4+PiBXaHkgZG8geW91IG5lZWQgdGhlIHRpbWVyIGFuZCB0aGUgcGVyaW9kaWMgY2hlY2s/ IElmIFRYUXMgYXJlCj4+Pj4+Pj4+Pj4+IGFkZGVkCj4+Pj4+Pj4+Pj4+IHRvCj4+Pj4+Pj4+Pj4+ IHRoZSByZW1vdmUgbGlzdCBkdXJpbmcgdGhlIHNjaGVkdWxpbmcgcnVuLCBhbmQKPj4+Pj4+Pj4+ Pj4gX19pZWVlODAyMTFfY2hlY2tfdHhxcygpCj4+Pj4+Pj4+Pj4+IGlzIHJ1biBmcm9tIHNjaGVk dWxlX2VuZCgpLCBpc24ndCB0aGF0IHN1ZmZpY2llbnQgdG8gY2xlYXIgCj4+Pj4+Pj4+Pj4+IHRo ZQo+Pj4+Pj4+Pj4+PiBsaXN0Pwo+Pj4+Pj4+Pj4+IElzIGl0IHBvc3NpYmxlIHRoYXQgYSB0eHEg aXMgbm90IGFkZGVkIHRvIHRoZSByZW1vdmUgbGlzdCBidXQKPj4+Pj4+Pj4+PiB0aGVuCj4+Pj4+ Pj4+Pj4gcGFja2V0cyBpbiBpdCBhcmUgZHJvcHBlZCBieSBmcV9jb2RlbCBhbGdvPyBMaWtlIHRo ZSBzdGF0aW9uCj4+Pj4+Pj4+Pj4gZGlzY29ubmVjdHMKPj4+Pj4+Pj4+PiB3aXRob3V0IGFueSBu b3RpZmljYXRpb24uCj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+IFdlbGwgYXMgbG9uZyBhcyBhbGwgdGhl IG90aGVyIGNsZWFudXAgcGF0aHMgY2FsbCBkaXJlY3RseSBpbnRvCj4+Pj4+Pj4+PiBfX3Vuc2No ZWR1bGVfdHhxKCksIHRoYXQgc2hvdWxkIHJlbW92ZSBzdGF0aW9ucyBmcm9tIHRoZQo+Pj4+Pj4+ Pj4gc2NoZWR1bGVyCj4+Pj4+Pj4+PiB3aGVuCj4+Pj4+Pj4+PiB0aGV5IGRpc2Nvbm5lY3QgZXRj Lgo+Pj4+Pj4+PiBZZXMsIHRoZSBkaXNjb25uZWN0IHNjZW5hcmlvIGlzIGEgYmFkIGV4YW1wbGUu IE15IGNvbmNlcm4gaXMsIAo+Pj4+Pj4+PiBzYXksCj4+Pj4+Pj4+IHdlCj4+Pj4+Pj4+IGhhdmUg MTAgc3RhdGlvbnMgYW5kIG9ubHkgb25lIG9mIHRoZW0gaXMgYXNzaWduZWQgYSB2ZXJ5IHNtYWxs Cj4+Pj4+Pj4+IHdlaWdodAo+Pj4+Pj4+PiBjb21wYXJlZCB3aXRoIHRoYXQgb2Ygb3RoZXJzLiBT dXBwb3NlLCBhZnRlciBpdHMgY2hhbmNlIG9mIFR4LCAKPj4+Pj4+Pj4gaXQKPj4+Pj4+Pj4gaXMK Pj4+Pj4+Pj4gbW9zdCBsaWtlbHkgdG8gYmUgcGxhY2VkIGluIHRoZSByaWdodG1vc3Qoc3RpbGwg aGFzIHNvbWUgcGFja2V0cwo+Pj4+Pj4+PiBpbgo+Pj4+Pj4+PiB0aGUKPj4+Pj4+Pj4gdHhxKSBh bmQgbm8gbW9yZSBpbmNvbWluZyBkYXRhIGZvciBpdC4gVGhlIHJlbWFpbmluZyBwYWNrZXRzIGlu Cj4+Pj4+Pj4+IHR4cQo+Pj4+Pj4+PiB3aWxsCj4+Pj4+Pj4+IGJlIGRyb3BwZWQgZHVlIHRvIHRp bWVvdXQgYWxnbyBpbiBjb2RlbChjb3JyZWN0IG1lIGlmIEkgYW0gCj4+Pj4+Pj4+IHdyb25nKQo+ Pj4+Pj4+PiBidXQKPj4+Pj4+Pj4gdGhpcyBlbXB0eSB0eHEgd2lsbCBzdGF5IG9uIHRoZSByYnRy ZWUgdW50aWwgb3RoZXIgdHhxcyBnZXQKPj4+Pj4+Pj4gZHJhaW5lZAo+Pj4+Pj4+PiBvcgo+Pj4+ Pj4+PiBnbG9iYWwgdnQgY2F0Y2ggdXAgd2l0aCBpdHMgdnQuIFRoZSBzdGF5aW5nIHRpbWUgY291 bGQgYmUgbG9uZyAKPj4+Pj4+Pj4gaWYKPj4+Pj4+Pj4gd2VpZ2h0Cj4+Pj4+Pj4+IGlzIGV4dHJl bWVseSBzbWFsbC4gVGhlbiBkbyB3ZSBuZWVkIHRpbWVyIHRvIGNoZWNrIG9yIGFueSBvdGhlcgo+ Pj4+Pj4+PiBiZXR0ZXIKPj4+Pj4+Pj4gc29sdXRpb24/Cj4+Pj4+Pj4gCj4+Pj4+Pj4gQWgsIEkg c2VlIHdoYXQgeW91IG1lYW4uIE5vLCBJIGRvbid0IHRoaW5rIHRoaXMgd2lsbCBiZSBhIAo+Pj4+ Pj4+IHByb2JsZW07Cj4+Pj4+Pj4gdGhlCj4+Pj4+Pj4gc2NlbmFyaW8geW91J3JlIGRlc2NyaWJp bmcgd291bGQgcGxheSBvdXQgbGlrZSB0aGlzOgo+Pj4+Pj4+IAo+Pj4+Pj4+IDEuIFN0YXRpb24g ZW5kcyB0cmFuc21pdHRpbmcsIHN0aWxsIGhhcyBhIHNpbmdsZSBwYWNrZXQgcXVldWVkLAo+Pj4+ Pj4+IGdldHMKPj4+Pj4+PiAgICBtb3ZlZCB0byB0aGUgZW5kIG9mIHRoZSByYnRyZWUgKGFuZCBz dGF5cyB0aGVyZSBmb3IgYSB3aGlsZSkuCj4+Pj4+Pj4gCj4+Pj4+Pj4gMi4gV2hlbiB3ZSBmaW5h bGx5IGdldCB0byB0aGUgcG9pbnQgd2hlcmUgdGhpcyBzdGF0aW9uIGdldHMgCj4+Pj4+Pj4gYW5v dGhlcgo+Pj4+Pj4+ICAgIGNoYW5jZSB0byB0cmFuc21pdCwgdGhlIENvRGVsIGRyb3AgdGltZXIg dHJpZ2dlcnMgYW5kIHRoZSBsYXN0Cj4+Pj4+Pj4gcGFja2V0Cj4+Pj4+Pj4gICAgaXMgZHJvcHBl ZFswXS4gVGhpcyBtZWFucyB0aGF0IHRoZSBxdWV1ZSB3aWxsIGp1c3QgYmUgZW1wdHkKPj4+Pj4+ PiAgICAoYW5kIGllZWU4MDIxMV90eF9kZXF1ZXVlKCkgd2lsbCByZXR1cm4gTlVMTCkuCj4+Pj4+ Pj4gCj4+Pj4+Pj4gMy4gQmVjYXVzZSB0aGUgcXVldWUgaXMgZW1wdHksIGllZWU4MDIxMV9yZXR1 cm5fdHhxKCkgd2lsbCBub3QgCj4+Pj4+Pj4gcHV0Cj4+Pj4+Pj4gaXQKPj4+Pj4+PiAgICBiYWNr IG9uIHRoZSByYnRyZWUuCj4+Pj4+Pj4gCj4+Pj4+Pj4gQ3J1Y2lhbGx5LCBpbiAyLiB0aGUgQ29E ZWwgYWxnb3JpdGhtIGRvZXNuJ3Qga2ljayBpbiB1bnRpbCB0aGUKPj4+Pj4+PiBwb2ludAo+Pj4+ Pj4+IG9mCj4+Pj4+Pj4gcGFja2V0IGRlcXVldWUuIEJ1dCBldmVuIGlmIGFuIGVtcHR5IHF1ZXVl IHN0YXlzIG9uIHRoZSByYnRyZWUgCj4+Pj4+Pj4gZm9yCj4+Pj4+Pj4gYQo+Pj4+Pj4+IHdoaWxl LCB0aGVyZSBpcyBubyBoYXJtIGluIHRoYXQ6IGV2ZW50dWFsbHkgaXQgd2lsbCBnZXQgaXRzIHR1 cm4sCj4+Pj4+Pj4gaXQKPj4+Pj4+PiB3aWxsIHR1cm4gb3V0IHRvIGJlIGVtcHR5LCBhbmQganVz dCBiZSBza2lwcGVkIG92ZXIuCj4+Pj4+PiBUaGVuIHRoYXQgd2lsbCBiZSBmaW5lLiBUaGFua3Mg Zm9yIHRoZSBleHBsYW5hdGlvbiBvZiB0aGUgZHJvcHBpbmcKPj4+Pj4+IHBhcnQKPj4+Pj4+IGlu IENvRGVsIGFsZ29yaXRobS4KPj4+Pj4gCj4+Pj4+IFl1cCwgdGhpbmsgc28uIEFuZCB5b3UncmUg d2VsY29tZSA6KQo+Pj4+PiAKPj4+Pj4+PiBUaGUgaXNzdWUgd2UgbmVlZCB0byBiZSBjb25jZXJu ZWQgYWJvdXQgaXMgdGhlIG9wcG9zaXRlOiBJZiB3ZSAKPj4+Pj4+PiBoYXZlCj4+Pj4+Pj4gYQo+ Pj4+Pj4+IHF1ZXVlIHRoYXQgKmRvZXMqIGhhdmUgcGFja2V0cyBxdWV1ZWQsIGJ1dCB3aGljaCBp cyAqbm90KiAKPj4+Pj4+PiBzY2hlZHVsZWQKPj4+Pj4+PiBmb3IKPj4+Pj4+PiB0cmFuc21pc3Np b24sIHRoYXQgd2lsbCBzdGFsbCBUWC4KPj4+Pj4+IElzIGl0IGJ5IGRlc2lnbiBzaW5jZSBpdHMg dnQgaXMgbW9yZSB0aGFuIGdsb2JhbCB2dCwgcmlnaHQ/IFRoZQo+Pj4+Pj4gbGF0dGVuY3kKPj4+ Pj4+IG1heSBzb21laG93IGdldCBpbXBhY3RlZCB0aG91Z2guCj4+Pj4+IAo+Pj4+PiBXZWxsLCBp dCBzaG91bGQgc3RpbGwgc3RheSBvbiB0aGUgcmJ0cmVlIGFzIGxvbmcgYXMgaXQgaGFzIHBhY2tl dHMKPj4+Pj4gcXVldWVkLiBXZSBkb24ndCBoYXZlIGEgY2hlY2sgYW55d2hlcmUgdGhhdCByZXNj aGVkdWxlcyBUWFFzIHdob3NlCj4+Pj4+IHZfdAo+Pj4+PiBkcm9wcyBiZWxvdyBnbG9iYWwgdl90 Li4uCj4+Pj4+IAo+Pj4+Pj4+IFswXSBDb0RlbCBpbiBtb3N0IGNhc2VzIG9ubHkgZHJvcHMgYSBz aW5nbGUgcGFja2V0IGF0IGEgdGltZSwgc28gCj4+Pj4+Pj4gaXQKPj4+Pj4+PiB3aWxsCj4+Pj4+ Pj4gbm90IGNsZWFyIG91dCBhbiBlbnRpcmUgcXVldWUgd2l0aCBtdWx0aXBsZSBwYWNrZXRzIGlu IG9uZSBnby4gCj4+Pj4+Pj4gQnV0Cj4+Pj4+Pj4geW91Cj4+Pj4+Pj4gYXJlIHJpZ2h0IHRoYXQg aXQgY291bGQgY29uY2VpdmFibHkgZHJvcCB0aGUgbGFzdCBwYWNrZXQgaW4gYQo+Pj4+Pj4+IHF1 ZXVlLgo+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gV2Ugb25seSBuZWVkIHRvIGRlZmVyIHJlbW92YWwgaW5z aWRlIGEgc2luZ2xlICJzY2hlZHVsaW5nIAo+Pj4+Pj4+Pj4gcm91bmQiCj4+Pj4+Pj4+PiAoaS5l LiwKPj4+Pj4+Pj4+IGJldHdlZW4gYSBwYWlyIG9mIGllZWU4MDIxMV90eHFfc2NoZWR1bGVfc3Rh cnQvZW5kLiBTbyBpZiB3ZSAKPj4+Pj4+Pj4+IGp1c3QKPj4+Pj4+Pj4+IHdhbGsKPj4+Pj4+Pj4+ IHRoZSByZW1vdmUgbGlzdCBpbiBzY2hlZHVsZV9lbmQoKSB3ZSBzaG91bGQgYmUgZW5vdWdoLCBu bz8KPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gSG1tLCBvciBtYXliZSBhIHNpbXBsZXIgd2F5IHRvIGZp eCB0aGUgb3JpZ2luYWwgaXNzdWUgaXMganVzdCAKPj4+Pj4+Pj4+IHRvCj4+Pj4+Pj4+PiBoYXZl Cj4+Pj4+Pj4+PiB1bnNjaGVkdWxlX3R4cSgpIHVwZGF0ZSB0aGUgc2NoZWR1bGVfcG9zKCkgcG9p bnRlcj8KPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gSS5lLiwgdW5zY2hlZHVsZV90eHEgY2hlY2tzIGlm IHRoZSB0eHEgYmVpbmcgcmVtb3ZlZCBpcyAKPj4+Pj4+Pj4+IGN1cnJlbnRseQo+Pj4+Pj4+Pj4g YmVpbmcKPj4+Pj4+Pj4+IHBvaW50ZWQgdG8gYnkgc2NoZWR1bGVfcG9zW2FjXSwgYW5kIGlmIGl0 IGlzLCBpdCB1cGRhdGVzCj4+Pj4+Pj4+PiBzY2hlZHVsZV9wb3MKPj4+Pj4+Pj4+IHRvCj4+Pj4+ Pj4+PiBiZSB0aGUgcmJfbmV4dCBvZiB0aGUgY3VycmVudCB2YWx1ZT8KPj4+Pj4+Pj4gQWN0dWFs bHksIGlmIHNjaGVkdWxlX3BvcyBpcyB1cGRhdGVkIHRvIHJiX25leHQgb2YgdGhlIGN1cnJlbnQK Pj4+Pj4+Pj4gdmFsdWUsCj4+Pj4+Pj4+IHRoZW4gaW4gdGhlIG5leHRfdHhxKCkgd2hlcmUgd2Ug YXJlIGdvaW5nIHRvIHVzZSByYl9uZXh0IGFnYWluIAo+Pj4+Pj4+PiBhbmQKPj4+Pj4+Pj4gZmlu YWxseSBwaWNrIHRoZSBuZXh0IG5vZGUgb2YgdGhlIG5vZGUgd2UgcmVhbGx5IHdhbnQuIElzIGl0 IAo+Pj4+Pj4+PiBmaW5lCj4+Pj4+Pj4+IHRvCj4+Pj4+Pj4+IHVwZGF0ZSBzY2hlZHVsZV9wb3Mg dG8gTlVMTD8KPj4+Pj4+PiAKPj4+Pj4+PiBIbW0sIHllYWgsIGdvb2QgcG9pbnQuCj4+Pj4+Pj4g Cj4+Pj4+Pj4gSWYgd2UgZG8gZW5kIHVwIHNldHRpbmcgc2NoZWR1bGVfcG9zIHRvIE5VTEwgaW4g dGhlIG1pZGRsZSBvZiBhCj4+Pj4+Pj4gc2NoZWR1bGluZyByb3VuZCwgdGhhdCB3aWxsIG1ha2Ug bmV4dF90eHEoKSAic3RhcnQgb3ZlciIsIGFuZCBkbwo+Pj4+Pj4+IGFub3RoZXIKPj4+Pj4+PiBs b29wIHRocm91Z2ggdGhlIHdob2xlIHRoaW5nLiBJIGd1ZXNzIHdlIG1heSBiZSBhYmxlIGhpdCBh IGNhc2UKPj4+Pj4+PiB3aGVyZQo+Pj4+Pj4+IHRoaW5ncyBjYW4gb3NjaWxsYXRlIGJhY2sgYW5k IGZvcnRoIGJldHdlZW4gYWRkaXRpb24gYW5kIHJlbW92YWwKPj4+Pj4+PiByZXN1bHRpbmcgaW4g YW4gaW5maW5pdGUgbG9vcD8gTm90IHN1cmUsIGJ1dCBhdCBsZWFzdCBJIGNhbid0IAo+Pj4+Pj4+ IHNlZW0KPj4+Pj4+PiB0bwo+Pj4+Pj4+IGNvbnZpbmNlIG15c2VsZiB0aGF0IHRoaXMgY2FuJ3Qg aGFwcGVuLgo+Pj4+Pj4gCj4+Pj4+PiBBcyB0aGUgbG9vcCBvZiBuZXh0X3R4cSB1bmRlciBsb2Nr IHByb3RlY3Rpb24gYXMgYmVsb3csCj4+Pj4+PiAKPj4+Pj4+IHR4cV9zY2hlZHVsZV9zdGFydCgp Owo+Pj4+Pj4gd2hpbGUodHhxPW5leHRfdHhxKCkpewo+Pj4+Pj4gLi4uCj4+Pj4+PiByZXR1cm5f dHhxKHR4cSk7Cj4+Pj4+PiB9Cj4+Pj4+PiB0eHFfc2NoZWR1bGVfZW5kKCk7Cj4+Pj4+PiAKPj4+ Pj4+IEkgZG8gbm90IHNlZSBhbnkgY2hhbmNlIG9mIGFkZGl0aW9uLCBubz8KPj4+Pj4gCj4+Pj4+ IEFzIHlvdSBub3RlZCBpbiB5b3VyIG90aGVyIGVtYWlsLCBGZWxpeCByZWR1Y2VkIHRoZSBsb2Nr aW5nLiBBbmQKPj4+Pj4geWVhaCwKPj4+Pj4gd2UgbmVlZCB0byByZWJhc2UgdGhpcyBzZXJpZXMg dG8gYWxzbyBpbmNvcnBvcmF0ZSB0aGF0LiBJIGZpZ3VyZSBJCj4+Pj4+IGNhbgo+Pj4+PiBzZW5k IGFuIHVwZGF0ZWQgdmVyc2lvbiBvZiB0aGUgZmlyc3QgcGF0Y2ggaW4gdGhlIHNlcmllcyBvbmNl IHdlJ3ZlCj4+Pj4+IHdvcmtlZCBvdXQgdGhlIHJlbWFpbmluZyBpc3N1ZXMgd2l0aCB5b3VyIGZv bGxvdy11cCBwYXRjaGVzLgo+Pj4+PiAKPj4+PiBPaCwgSSB3YXMgdGhpbmtpbmcgd2Ugd2VyZSBk aXNjdXNzaW5nIHdpdGhvdXQgbG9ja2luZyByZWR1Y2VkLiBZZXMsIAo+Pj4+IEkKPj4+PiBhbHNv IGFncmVlIHRoZXJlIG1pZ2h0IGJlIGEgY2FzZSBjYXVzaW5nIGluZmluaXRlIGxvb3AuIFdpdGgg bG9ja2luZwo+Pj4+IHJlZHVjZWQsIHRoZSB0cmVlIGNhbiBiZSBhZGp1c3RlZCBiZXR3ZWVuIG5l eHRfdHhxKCkgYW5kIAo+Pj4+IHJldHVybl90eHEoKQo+Pj4+IGluCj4+Pj4gdGhlIGxvb3Agc2l0 dWF0aW9uLiBGb3IgZnVydGhlciBkaXNjdXNzaW9uLCBsZXQgJ3MgY29uc2lkZXIsCj4+Pj4gMSkg dGhlIHRyZWUgc3RhcnRzIGxpa2U6Cj4+Pj4gICAgICAgICBBLT5CLT5DLT5ELT5FCj4+Pj4gMikg dGhlbiBuZXh0X3R4cSgpIHJldHVybnMgQSBmb3IgZGVxdWV1aW5nCj4+Pj4gMykgZHJpdmVyIGRl cXVldWVzIEEgYW5kIGRyYWluZXMgQSB3aXRob3V0IGFueSBhY3RpdmUgdHhxIGxvY2tlZAo+Pj4+ IG1lYW5pbmcKPj4+PiB0aGUgdHJlZSBjb3VsZCBiZSBjaGFuZ2VkIHVwb24gVHggY29tcGVsZXRp b24uCj4+Pj4gNCkgdGhlbiBpbiByZXR1cm5fdHhxKCksIHRoZSB0cmVlIGNvdWxkIGJlLAo+Pj4+ ICAgICAgICAgaSAgIEEtPkItPkMtPkQtPkUg77yIQSBpcyBlbXB0eSwgYW5kIG1heWJlIHNvb24g YmUgYWRkZWQgYmFjawo+Pj4+IGJlZm9yZSB0aGUgbG9vcCBlbmTvvIkKPj4+PiAgICAgICAgIGlp ICBCLT5DLT5BLT5ELT5FIO+8iEEgaXMgZW1wdHksIGFuZCBtYXliZSBzb29uIGJlIGFkZGVkIGJh Y2sKPj4+PiBiZWZvcmUgdGhlIGxvb3AgZW5k77yJCj4+Pj4gICAgICAgICBpaWkgQi0+Qy0+RC0+ RS0+QSDvvIhBIGlzIGVtcHR5LCBhbmQgbWF5YmUgc29vbiBiZSBhZGRlZCBiYWNrCj4+Pj4gYmVm b3JlIHRoZSBsb29wIGVuZCkKPj4+PiAKPj4+PiB3aXRoIHRoaXMgY2hhbmdlOgo+Pj4+ICAgbG9j YWwtPnNjaGVkdWxlX3Bvc1thY10gPSByYl9uZXh0KG5vZGUpID86IHJiX3ByZXYobm9kZSk7Cj4+ Pj4gCj4+Pj4gZm9yIGNhc2UgaSwgbG9jYWwtPnNjaGVkdWxlX3Bvc1thY10gaXMgcmJfbmV4dChB KSB3aGljaCBpcyBCLCBhbmQgaW4KPj4+PiBuZXh0X3R4cSgpLCByYl9uZXh0KEIpIGlzIHdoYXQg d2UgcmV0dXJucyB3aGljaCBhY3R1YWxseSBpcyBDIGFuZCBCIAo+Pj4+IGlzCj4+Pj4gc2tpcHBl ZCwgbm8/Cj4+Pj4gCj4+Pj4gU2ltaWxpYXIgZm9yIGNhc2UgaWksIHdlIHNraXAgQiwgQywgRC4K Pj4+IAo+Pj4gWXVwLCBJIHRoaW5rIHlvdSdyZSByaWdodC4gQnV0IGlmIHdlIGNhbiBmaXggdGhp cyBieSBtYWtpbmcKPj4+IGllZWU4MDIxMV9yZXNvcnRfdHhxKCkgYXdhcmUgb2YgdGhlIHNjaGVk dWxlX3BvcyBhcyB3ZWxsLCBubz8gSS5lLiwgCj4+PiBpZgo+Pj4gcmVzb3J0X3R4cSgpIGFjdHMg b24gdGhlIHR4cSB0aGF0J3MgY3VycmVudGx5IGluIHNjaGVkdWxlX3BvcywgaXQgCj4+PiB3aWxs Cj4+PiB1cGRhdGUgc2NoZWR1bGUgcG9zIHdpdGggdGhlIHNhbWUgcmJfbmV4dChub2RlKSA/OiBy Yl9wcmV2KG5vZGUpOwo+Pj4gKG9wdGlvbmFsbHkgYWZ0ZXIgY2hlY2tpbmcgdGhhdCB0aGUgcG9z aXRpb24gb2YgdGhlIG5vZGUgaXMgYWN0dWFsbHkKPj4+IGdvaW5nIHRvIGNoYW5nZSkuCj4+IFNv cnJ5LCBwbGVhc2UgaWdvcmUgbGFzdCBlbWFpbCBzZW50IGJ5IG1pc3Rha2UuCj4+IAo+PiBJIGRv bid0IHRoaW5rIGl0IG1ha2VzIGFueSBkaWZmZXJlbmNlIHdpdGggdGhhdCBpbiB1bnNjaGVkdWxl X3R4cSgpLiAKPj4gRm9yCj4+IGNhc2UgaSwgaXQgZmluYWxseSBwaWNrcyBDIGFzIHdlbGwgaW4g bmV4dF90eHEoKS4gRm9yIG5leHRfdHhxKCksCj4+IHNjaGVkdWxlX3BvcyBtZWFucyBwcmV2aW91 cyBjYW5kaWRhdGUgbm9kZSB3aGVyZWFzIHdpdGggeW91ciBjaGFuZ2UsIAo+PiBpdAo+PiBsb29r cyBsaWtlIHNjaGVkdWxlX3BvcyBpcyBjdXJyZW50IGNhbmRpZGF0ZSBub2RlIGluc3RlYWQuCj4g Cj4gSG1tLCB0aGF0IHdhcyBub3QgYWN0dWFsbHkgd2hhdCBJIHdhcyB0aGlua2luZywgYnV0IHll YWggSSB0aGluayB5b3UncmUKPiByaWdodCB0aGF0IGl0IHdvdWxkIGJlIGVhc2llciB0byBqdXN0 IGNoYW5nZSBpdCBzbyBzY2hlZHVsZV9wb3MgaXMKPiBwb2ludGluZyB0byB0aGUgbmV4dCBhbmQg bm90IHRoZSBjdXJyZW50IHR4cSB3ZSB3YW50IHRvIHNjaGVkdWxlLgpTbyBkbyB5b3UgbWVhbiB3 ZSBjYW4gY2hhbmdlIG5leHRfdHhxIGxpa2UgdGhpcywKCiAgc3RydWN0IGllZWU4MDIxMV90eHEg KmllZWU4MDIxMV9uZXh0X3R4cShzdHJ1Y3QgaWVlZTgwMjExX2h3ICpodywgdTggCmFjKQogIHsK ICAJc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9jYWwgPSBod190b19sb2NhbChodyk7CglzdHJ1 Y3QgcmJfbm9kZSAqbm9kZSA9IGxvY2FsLT5zY2hlZHVsZV9wb3NbYWNdOwogIAlzdHJ1Y3QgdHhx X2luZm8gKnR4cWkgPSBOVUxMOwoJYm9vbCBmaXJzdCA9IGZhbHNlOwoKICAJbG9ja2RlcF9hc3Nl cnRfaGVsZCgmbG9jYWwtPmFjdGl2ZV90eHFfbG9ja1thY10pOwoKCWlmICghbm9kZSkgewoJICAg ICAgICBub2RlID0gcmJfZmlyc3RfY2FjaGVkKCZsb2NhbC0+YWN0aXZlX3R4cXNbYWNdKTsKCQlm aXJzdCA9IHRydWU7Ci0JfSBlbHNlCi0JCW5vZGUgPSByYl9uZXh0KG5vZGUpOworICAgICAgIH0K KwoJaWYgKCFub2RlKQogIAkJcmV0dXJuIE5VTEw7CgoKCj4gCj4gV2UnZCBzdGlsbCBuZWVkIGEg Y2hlY2sgaW4gcmVzb3J0X3R4cSgpIHRoZW4sIGJ1dCBpdCB3b3VsZCBtYWtlIGl0IHNhZmUKPiB0 byB1bnNjaGVkdWxlIGluIHJldHVybl90eHEoKS4uLgpZZXMsIGFncmVlIHdpdGggdGhhdC4KCgo+ IAo+Pj4+IEFsc28gSSBhbSB3b25kZXJpbmcgaWYgdGhlcmUgd2lsbCBiZSBzb21lIFNNUCBpc3N1 ZXMgcmVsYXRpbmcgd2l0aAo+Pj4+IGxvY2FsLT5zY2hlZHVsZV9wb3NbYWNdLgo+Pj4gCj4+PiBO b3Qgc3VyZSB3aGF0IHlvdSBtZWFuIGJ5IHRoaXM/Cj4+IE15IGJhZC4gUGxlYXNlIGlnbm9yZSB0 aGlzLgo+PiAKPj4gCj4+PiAKPj4+Pj4+IEluIGF0aDEwaywgd2Ugd2lsbCB1c3VhbGx5IHB1c2gg cGFja2V0cyBvZiBmaXJzdCB0eHEgYXMgbWFueSBhcyB3ZQo+Pj4+Pj4gY2FuCj4+Pj4+PiB1bnRp bCBpdCBpcyBkcmFpbmVkIGFuZCB0aGVuIG1vdmUgdG8gdGhlIG5leHQgb25lLiBTbyBpZiBhIHR4 cSAKPj4+Pj4+IGdldHMKPj4+Pj4+IHJlbW92ZWQgaW4gdGhlIHJldHVybl90eHEsIGl0IHNob3Vs ZCBhbHdheXMgYmUgdGhlIGxlZnRtb3N0LiBBbmQKPj4+Pj4+IGR1cmluZyB0aGlzIHBlcmlvZCwg bmVpdGhlciB2dCBvZiBhbnkgc3RhdGlvbiBvciBnbG9iYWwgdnQgY2FuIGJlCj4+Pj4+PiB1cGRh dGVkIGR1ZSB0byBsb2NrIHByb3RlY3Rpb24uCj4+Pj4+PiAKPj4+Pj4+PiAKPj4+Pj4+PiBCdXQg aW4gdGhhdCBjYXNlLCB3ZSBjb3VsZCBmaXggaXQgYnkganVzdCBjb25kaXRpb25hbGx5IGFzc2ln bmluZwo+Pj4+Pj4+IGVpdGhlcgo+Pj4+Pj4+IHJiX25leHQgb3IgcmJfcHJldiB0byB0aGUgc2No ZWR1bGVfcG9zIGluIHVuc2NoZWR1bGVfdHhxKCk/IEkuZS4sCj4+Pj4+Pj4gc29tZXRoaW5nIGxp a2U6Cj4+Pj4+Pj4gCj4+Pj4+Pj4gbG9jYWwtPnNjaGVkdWxlX3Bvc1thY10gPSByYl9uZXh0KG5v ZGUpID86IHJiX3ByZXYobm9kZSk7Cj4+Pj4+PiBJIGFtIG5vdCBzdXJlIEkgYW0gZ2V0dGluZyB5 b3VyIHBvaW50LiBTdGlsbCBpbiBuZXh0X3R4cSwKPj4+Pj4+IHNjaGVkdWxlX3Bvc1thY10gd2ls bCBsZWFkIHVzIHRvIHRoZSBuZXh0IG5vZGUgb2YgdGhlIG9uZSB3ZSB3YW50Lgo+Pj4+PiAKPj4+ Pj4gVGhlIGxvZ2ljIGluIG5leHRfdHhxIGlzIGRpZmZlcmVudCB3aGVuIHNjaGVkdWxlX3Bvc1th Y10gaXMgTlVMTCwgCj4+Pj4+IHZzCj4+Pj4+IHdoZW4gcmJfbmV4dChzY2hlZHVsZV9wb3NbYWNd KSBpcyBOVUxMLiBUaGUgZm9ybWVyIHJlc3RhcnRzIGEgbmV3Cj4+Pj4+IHNjaGVkdWxpbmcgcm91 bmQsIHdoaWxlIHRoZSBsYXR0ZXIgZW5kcyB0aGUgY3VycmVudCByb3VuZC4KPj4+Pj4gCj4+Pj4+ IC1Ub2tlCj4+Pj4gCj4+Pj4gLS0KPj4+PiBZaWJvCj4+IAo+PiAtLQo+PiBZaWJvCgotLSAKWWli bwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBr IG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A65C49ED7 for ; Sat, 21 Sep 2019 13:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FA38208C0 for ; Sat, 21 Sep 2019 13:24:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CduRAqk7"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ID6Vm9U5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393376AbfIUNYO (ORCPT ); Sat, 21 Sep 2019 09:24:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50398 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388184AbfIUNYO (ORCPT ); Sat, 21 Sep 2019 09:24:14 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5C968614BF; Sat, 21 Sep 2019 13:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569072250; bh=ohRaCfskydQ6st8liCwF9KtxdsrIVGkPbFHwugJ3Wak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CduRAqk7rU6H6H/CeBUjpUZ5yCHRE0AoIc6tyj9lf0K0XwBoP9magqK/WYB/g3/6m GWawvCN8ZE3l3QaAeWCqrMSgpB7Z+je/1Dkx2g07x7V18H7jk3pOf/LzLlUbgnnGjA sIo9sEa088E2YDmq6CgLFNoozxSfbtkHIN8MqBAw= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id EB75361418; Sat, 21 Sep 2019 13:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569072248; bh=ohRaCfskydQ6st8liCwF9KtxdsrIVGkPbFHwugJ3Wak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ID6Vm9U5EsP5IupNZEOrZmKUfXoxGA8dODo2EJxvWLWfyzydVtM6pnVo/s9bR4+AM jJf/BrnMAzFgqKF1Cf80RJiLdFDBgLYiPcZz5lfmK2DfrVT9H9xvH9qYWVE8kfWp5T DEneyh1qyhg5bSBmOKOI76l/z339mHlhY6fjwrfQ= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 21 Sep 2019 21:24:07 +0800 From: Yibo Zhao To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <877e617qg2.fsf@toke.dk> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-2-git-send-email-yiboz@codeaurora.org> <87pnjyiq7o.fsf@toke.dk> <87sgothmpy.fsf@toke.dk> <8cdece5c030fd95817fb099021c38613@codeaurora.org> <87tv98fu6l.fsf@toke.dk> <1b4ab006d9b5c88035845aaac193ef48@codeaurora.org> <8736gre3bm.fsf@toke.dk> <198124204167325252fcfcd65e3f2733@codeaurora.org> <87ftkp7uuz.fsf@toke.dk> <4574cce4079f8dab2b2bf223431a6eae@codeaurora.org> <877e617qg2.fsf@toke.dk> Message-ID: <910d9bb5f9016b29fb2aaeb0b89bac38@codeaurora.org> X-Sender: yiboz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-09-21 21:02, Toke Høiland-Jørgensen wrote: > Yibo Zhao writes: > >> On 2019-09-21 19:27, Toke Høiland-Jørgensen wrote: >>> Yibo Zhao writes: >>> >>>> On 2019-09-20 17:15, Toke Høiland-Jørgensen wrote: >>>>> Yibo Zhao writes: >>>>> >>>>>> On 2019-09-19 18:37, Toke Høiland-Jørgensen wrote: >>>>>>> Yibo Zhao writes: >>>>>>> >>>>>>>> On 2019-09-18 19:23, Toke Høiland-Jørgensen wrote: >>>>>>>>> Yibo Zhao writes: >>>>>>>>> >>>>>>>>>> On 2019-09-18 05:10, Toke Høiland-Jørgensen wrote: >>>>>>>>>>> Yibo Zhao writes: >>>>>>>>>>> >>>>>>>>>>>> In a loop txqs dequeue scenario, if the first txq in the >>>>>>>>>>>> rbtree >>>>>>>>>>>> gets >>>>>>>>>>>> removed from rbtree immediately in the >>>>>>>>>>>> ieee80211_return_txq(), >>>>>>>>>>>> the >>>>>>>>>>>> loop will break soon in the ieee80211_next_txq() due to >>>>>>>>>>>> schedule_pos >>>>>>>>>>>> not leading to the second txq in the rbtree. Thus, defering >>>>>>>>>>>> the >>>>>>>>>>>> removal right before the end of this schedule round. >>>>>>>>>>>> >>>>>>>>>>>> Co-developed-by: Yibo Zhao >>>>>>>>>>>> Signed-off-by: Yibo Zhao >>>>>>>>>>>> Signed-off-by: Toke Høiland-Jørgensen >>>>>>>>>>> >>>>>>>>>>> I didn't write this patch, so please don't use my sign-off. >>>>>>>>>>> I'll >>>>>>>>>>> add >>>>>>>>>>> ack or review tags as appropriate in reply; but a few >>>>>>>>>>> comments >>>>>>>>>>> first: >>>>>>>>>>> >>>>>>>>>>>> --- >>>>>>>>>>>> include/net/mac80211.h | 16 ++++++++++-- >>>>>>>>>>>> net/mac80211/ieee80211_i.h | 3 +++ >>>>>>>>>>>> net/mac80211/main.c | 6 +++++ >>>>>>>>>>>> net/mac80211/tx.c | 63 >>>>>>>>>>>> +++++++++++++++++++++++++++++++++++++++++++--- >>>>>>>>>>>> 4 files changed, 83 insertions(+), 5 deletions(-) >>>>>>>>>>>> >>>>>>>>>>>> diff --git a/include/net/mac80211.h b/include/net/mac80211.h >>>>>>>>>>>> index ac2ed8e..ba5a345 100644 >>>>>>>>>>>> --- a/include/net/mac80211.h >>>>>>>>>>>> +++ b/include/net/mac80211.h >>>>>>>>>>>> @@ -925,6 +925,8 @@ struct ieee80211_tx_rate { >>>>>>>>>>>> >>>>>>>>>>>> #define IEEE80211_MAX_TX_RETRY 31 >>>>>>>>>>>> >>>>>>>>>>>> +#define IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS 100 >>>>>>>>>>>> + >>>>>>>>>>>> static inline void ieee80211_rate_set_vht(struct >>>>>>>>>>>> ieee80211_tx_rate >>>>>>>>>>>> *rate, >>>>>>>>>>>> u8 mcs, u8 nss) >>>>>>>>>>>> { >>>>>>>>>>>> @@ -6232,7 +6234,8 @@ struct sk_buff >>>>>>>>>>>> *ieee80211_tx_dequeue(struct >>>>>>>>>>>> ieee80211_hw *hw, >>>>>>>>>>>> * @ac: AC number to return packets from. >>>>>>>>>>>> * >>>>>>>>>>>> * Should only be called between calls to >>>>>>>>>>>> ieee80211_txq_schedule_start() >>>>>>>>>>>> - * and ieee80211_txq_schedule_end(). >>>>>>>>>>>> + * and ieee80211_txq_schedule_end(). If the txq is empty, >>>>>>>>>>>> it >>>>>>>>>>>> will >>>>>>>>>>>> be >>>>>>>>>>>> added >>>>>>>>>>>> + * to a remove list and get removed later. >>>>>>>>>>>> * Returns the next txq if successful, %NULL if no queue is >>>>>>>>>>>> eligible. >>>>>>>>>>>> If a txq >>>>>>>>>>>> * is returned, it should be returned with >>>>>>>>>>>> ieee80211_return_txq() >>>>>>>>>>>> after the >>>>>>>>>>>> * driver has finished scheduling it. >>>>>>>>>>>> @@ -6268,7 +6271,8 @@ void >>>>>>>>>>>> ieee80211_txq_schedule_start(struct >>>>>>>>>>>> ieee80211_hw *hw, u8 ac) >>>>>>>>>>>> * @hw: pointer as obtained from ieee80211_alloc_hw() >>>>>>>>>>>> * @ac: AC number to acquire locks for >>>>>>>>>>>> * >>>>>>>>>>>> - * Release locks previously acquired by >>>>>>>>>>>> ieee80211_txq_schedule_end(). >>>>>>>>>>>> + * Release locks previously acquired by >>>>>>>>>>>> ieee80211_txq_schedule_end(). >>>>>>>>>>>> Check >>>>>>>>>>>> + * and remove the empty txq from rb-tree. >>>>>>>>>>>> */ >>>>>>>>>>>> void ieee80211_txq_schedule_end(struct ieee80211_hw *hw, u8 >>>>>>>>>>>> ac) >>>>>>>>>>>> __releases(txq_lock); >>>>>>>>>>>> @@ -6287,6 +6291,14 @@ void ieee80211_schedule_txq(struct >>>>>>>>>>>> ieee80211_hw >>>>>>>>>>>> *hw, struct ieee80211_txq *txq) >>>>>>>>>>>> __acquires(txq_lock) __releases(txq_lock); >>>>>>>>>>>> >>>>>>>>>>>> /** >>>>>>>>>>>> + * ieee80211_txqs_check - Check txqs waiting for removal >>>>>>>>>>>> + * >>>>>>>>>>>> + * @tmr: pointer as obtained from local >>>>>>>>>>>> + * >>>>>>>>>>>> + */ >>>>>>>>>>>> +void ieee80211_txqs_check(struct timer_list *tmr); >>>>>>>>>>>> + >>>>>>>>>>>> +/** >>>>>>>>>>>> * ieee80211_txq_may_transmit - check whether TXQ is >>>>>>>>>>>> allowed >>>>>>>>>>>> to >>>>>>>>>>>> transmit >>>>>>>>>>>> * >>>>>>>>>>>> * This function is used to check whether given txq is >>>>>>>>>>>> allowed >>>>>>>>>>>> to >>>>>>>>>>>> transmit by >>>>>>>>>>>> diff --git a/net/mac80211/ieee80211_i.h >>>>>>>>>>>> b/net/mac80211/ieee80211_i.h >>>>>>>>>>>> index a4556f9..49aa143e 100644 >>>>>>>>>>>> --- a/net/mac80211/ieee80211_i.h >>>>>>>>>>>> +++ b/net/mac80211/ieee80211_i.h >>>>>>>>>>>> @@ -847,6 +847,7 @@ struct txq_info { >>>>>>>>>>>> struct codel_stats cstats; >>>>>>>>>>>> struct sk_buff_head frags; >>>>>>>>>>>> struct rb_node schedule_order; >>>>>>>>>>>> + struct list_head candidate; >>>>>>>>>>>> unsigned long flags; >>>>>>>>>>>> >>>>>>>>>>>> /* keep last! */ >>>>>>>>>>>> @@ -1145,6 +1146,8 @@ struct ieee80211_local { >>>>>>>>>>>> u64 airtime_v_t[IEEE80211_NUM_ACS]; >>>>>>>>>>>> u64 airtime_weight_sum[IEEE80211_NUM_ACS]; >>>>>>>>>>>> >>>>>>>>>>>> + struct list_head remove_list[IEEE80211_NUM_ACS]; >>>>>>>>>>>> + struct timer_list remove_timer; >>>>>>>>>>>> u16 airtime_flags; >>>>>>>>>>>> >>>>>>>>>>>> const struct ieee80211_ops *ops; >>>>>>>>>>>> diff --git a/net/mac80211/main.c b/net/mac80211/main.c >>>>>>>>>>>> index e9ffa8e..78fe24a 100644 >>>>>>>>>>>> --- a/net/mac80211/main.c >>>>>>>>>>>> +++ b/net/mac80211/main.c >>>>>>>>>>>> @@ -667,10 +667,15 @@ struct ieee80211_hw >>>>>>>>>>>> *ieee80211_alloc_hw_nm(size_t priv_data_len, >>>>>>>>>>>> >>>>>>>>>>>> for (i = 0; i < IEEE80211_NUM_ACS; i++) { >>>>>>>>>>>> local->active_txqs[i] = RB_ROOT_CACHED; >>>>>>>>>>>> + INIT_LIST_HEAD(&local->remove_list[i]); >>>>>>>>>>>> spin_lock_init(&local->active_txq_lock[i]); >>>>>>>>>>>> } >>>>>>>>>>>> local->airtime_flags = AIRTIME_USE_TX | AIRTIME_USE_RX; >>>>>>>>>>>> >>>>>>>>>>>> + timer_setup(&local->remove_timer, ieee80211_txqs_check, >>>>>>>>>>>> 0); >>>>>>>>>>>> + mod_timer(&local->remove_timer, >>>>>>>>>>>> + jiffies + >>>>>>>>>>>> msecs_to_jiffies(IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS)); >>>>>>>>>>>> + >>>>>>>>>>>> INIT_LIST_HEAD(&local->chanctx_list); >>>>>>>>>>>> mutex_init(&local->chanctx_mtx); >>>>>>>>>>>> >>>>>>>>>>>> @@ -1305,6 +1310,7 @@ void ieee80211_unregister_hw(struct >>>>>>>>>>>> ieee80211_hw >>>>>>>>>>>> *hw) >>>>>>>>>>>> tasklet_kill(&local->tx_pending_tasklet); >>>>>>>>>>>> tasklet_kill(&local->tasklet); >>>>>>>>>>>> >>>>>>>>>>>> + del_timer_sync(&local->remove_timer); >>>>>>>>>>>> #ifdef CONFIG_INET >>>>>>>>>>>> unregister_inetaddr_notifier(&local->ifa_notifier); >>>>>>>>>>>> #endif >>>>>>>>>>>> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c >>>>>>>>>>>> index d00baaa..42ca010 100644 >>>>>>>>>>>> --- a/net/mac80211/tx.c >>>>>>>>>>>> +++ b/net/mac80211/tx.c >>>>>>>>>>>> @@ -1450,6 +1450,7 @@ void ieee80211_txq_init(struct >>>>>>>>>>>> ieee80211_sub_if_data *sdata, >>>>>>>>>>>> codel_stats_init(&txqi->cstats); >>>>>>>>>>>> __skb_queue_head_init(&txqi->frags); >>>>>>>>>>>> RB_CLEAR_NODE(&txqi->schedule_order); >>>>>>>>>>>> + INIT_LIST_HEAD(&txqi->candidate); >>>>>>>>>>>> >>>>>>>>>>>> txqi->txq.vif = &sdata->vif; >>>>>>>>>>>> >>>>>>>>>>>> @@ -3724,6 +3725,9 @@ void ieee80211_schedule_txq(struct >>>>>>>>>>>> ieee80211_hw >>>>>>>>>>>> *hw, >>>>>>>>>>>> >>>>>>>>>>>> spin_lock_bh(&local->active_txq_lock[ac]); >>>>>>>>>>>> >>>>>>>>>>>> + if (!list_empty(&txqi->candidate)) >>>>>>>>>>>> + list_del_init(&txqi->candidate); >>>>>>>>>>>> + >>>>>>>>>>>> if (!RB_EMPTY_NODE(&txqi->schedule_order)) >>>>>>>>>>>> goto out; >>>>>>>>>>>> >>>>>>>>>>>> @@ -3783,6 +3787,20 @@ static void >>>>>>>>>>>> __ieee80211_unschedule_txq(struct >>>>>>>>>>>> ieee80211_hw *hw, >>>>>>>>>>>> RB_CLEAR_NODE(&txqi->schedule_order); >>>>>>>>>>>> } >>>>>>>>>>>> >>>>>>>>>>>> +void ieee80211_remove_txq(struct ieee80211_hw *hw, >>>>>>>>>>>> + struct ieee80211_txq *txq) >>>>>>>>>>>> +{ >>>>>>>>>>>> + struct ieee80211_local *local = hw_to_local(hw); >>>>>>>>>>>> + struct txq_info *txqi = to_txq_info(txq); >>>>>>>>>>>> + >>>>>>>>>>>> + lockdep_assert_held(&local->active_txq_lock[txq->ac]); >>>>>>>>>>>> + >>>>>>>>>>>> + if (!RB_EMPTY_NODE(&txqi->schedule_order)) { >>>>>>>>>>>> + __ieee80211_unschedule_txq(hw, txq); >>>>>>>>>>>> + list_del_init(&txqi->candidate); >>>>>>>>>>>> + } >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> void ieee80211_unschedule_txq(struct ieee80211_hw *hw, >>>>>>>>>>>> struct ieee80211_txq *txq) >>>>>>>>>>>> __acquires(txq_lock) __releases(txq_lock) >>>>>>>>>>>> @@ -3790,7 +3808,7 @@ void ieee80211_unschedule_txq(struct >>>>>>>>>>>> ieee80211_hw *hw, >>>>>>>>>>>> struct ieee80211_local *local = hw_to_local(hw); >>>>>>>>>>>> >>>>>>>>>>>> spin_lock_bh(&local->active_txq_lock[txq->ac]); >>>>>>>>>>>> - __ieee80211_unschedule_txq(hw, txq); >>>>>>>>>>>> + ieee80211_remove_txq(hw, txq); >>>>>>>>>>>> spin_unlock_bh(&local->active_txq_lock[txq->ac]); >>>>>>>>>>>> } >>>>>>>>>>>> >>>>>>>>>>>> @@ -3803,11 +3821,48 @@ void ieee80211_return_txq(struct >>>>>>>>>>>> ieee80211_hw >>>>>>>>>>>> *hw, >>>>>>>>>>>> lockdep_assert_held(&local->active_txq_lock[txq->ac]); >>>>>>>>>>>> >>>>>>>>>>>> if (!RB_EMPTY_NODE(&txqi->schedule_order) && >>>>>>>>>>>> - (skb_queue_empty(&txqi->frags) && >>>>>>>>>>>> !txqi->tin.backlog_packets)) >>>>>>>>>>>> - __ieee80211_unschedule_txq(hw, txq); >>>>>>>>>>>> + !txq_has_queue(&txqi->txq) && >>>>>>>>>>>> + list_empty(&txqi->candidate)) >>>>>>>>>>>> + list_add_tail(&txqi->candidate, >>>>>>>>>>>> &local->remove_list[txq->ac]); >>>>>>>>>>>> + >>>>>>>>>>>> } >>>>>>>>>>>> EXPORT_SYMBOL(ieee80211_return_txq); >>>>>>>>>>>> >>>>>>>>>>>> +void __ieee80211_check_txqs(struct ieee80211_local *local, >>>>>>>>>>>> int >>>>>>>>>>>> ac) >>>>>>>>>>>> +{ >>>>>>>>>>>> + struct txq_info *iter, *tmp; >>>>>>>>>>>> + struct sta_info *sta; >>>>>>>>>>>> + >>>>>>>>>>>> + lockdep_assert_held(&local->active_txq_lock[ac]); >>>>>>>>>>>> + >>>>>>>>>>>> + list_for_each_entry_safe(iter, tmp, >>>>>>>>>>>> &local->remove_list[ac], >>>>>>>>>>>> + candidate) { >>>>>>>>>>>> + sta = container_of(iter->txq.sta, struct sta_info, sta); >>>>>>>>>>>> + >>>>>>>>>>>> + if (txq_has_queue(&iter->txq)) >>>>>>>>>>>> + list_del_init(&iter->candidate); >>>>>>>>>>>> + else >>>>>>>>>>>> + ieee80211_remove_txq(&local->hw, &iter->txq); >>>>>>>>>>>> + } >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> +void ieee80211_txqs_check(struct timer_list *t) >>>>>>>>>>>> +{ >>>>>>>>>>>> + struct ieee80211_local *local = from_timer(local, t, >>>>>>>>>>>> remove_timer); >>>>>>>>>>>> + struct txq_info *iter, *tmp; >>>>>>>>>>>> + struct sta_info *sta; >>>>>>>>>>>> + int ac; >>>>>>>>>>>> + >>>>>>>>>>>> + for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) { >>>>>>>>>>>> + spin_lock_bh(&local->active_txq_lock[ac]); >>>>>>>>>>>> + __ieee80211_check_txqs(local, ac); >>>>>>>>>>>> + spin_unlock_bh(&local->active_txq_lock[ac]); >>>>>>>>>>>> + } >>>>>>>>>>>> + >>>>>>>>>>>> + mod_timer(&local->remove_timer, >>>>>>>>>>>> + jiffies + >>>>>>>>>>>> msecs_to_jiffies(IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS)); >>>>>>>>>>>> +} >>>>>>>>>>> >>>>>>>>>>> I'll ask the same as I did last time (where you told me to >>>>>>>>>>> hold >>>>>>>>>>> off >>>>>>>>>>> until this round): >>>>>>>>>>> >>>>>>>>>>> Why do you need the timer and the periodic check? If TXQs are >>>>>>>>>>> added >>>>>>>>>>> to >>>>>>>>>>> the remove list during the scheduling run, and >>>>>>>>>>> __ieee80211_check_txqs() >>>>>>>>>>> is run from schedule_end(), isn't that sufficient to clear >>>>>>>>>>> the >>>>>>>>>>> list? >>>>>>>>>> Is it possible that a txq is not added to the remove list but >>>>>>>>>> then >>>>>>>>>> packets in it are dropped by fq_codel algo? Like the station >>>>>>>>>> disconnects >>>>>>>>>> without any notification. >>>>>>>>> >>>>>>>>> Well as long as all the other cleanup paths call directly into >>>>>>>>> __unschedule_txq(), that should remove stations from the >>>>>>>>> scheduler >>>>>>>>> when >>>>>>>>> they disconnect etc. >>>>>>>> Yes, the disconnect scenario is a bad example. My concern is, >>>>>>>> say, >>>>>>>> we >>>>>>>> have 10 stations and only one of them is assigned a very small >>>>>>>> weight >>>>>>>> compared with that of others. Suppose, after its chance of Tx, >>>>>>>> it >>>>>>>> is >>>>>>>> most likely to be placed in the rightmost(still has some packets >>>>>>>> in >>>>>>>> the >>>>>>>> txq) and no more incoming data for it. The remaining packets in >>>>>>>> txq >>>>>>>> will >>>>>>>> be dropped due to timeout algo in codel(correct me if I am >>>>>>>> wrong) >>>>>>>> but >>>>>>>> this empty txq will stay on the rbtree until other txqs get >>>>>>>> drained >>>>>>>> or >>>>>>>> global vt catch up with its vt. The staying time could be long >>>>>>>> if >>>>>>>> weight >>>>>>>> is extremely small. Then do we need timer to check or any other >>>>>>>> better >>>>>>>> solution? >>>>>>> >>>>>>> Ah, I see what you mean. No, I don't think this will be a >>>>>>> problem; >>>>>>> the >>>>>>> scenario you're describing would play out like this: >>>>>>> >>>>>>> 1. Station ends transmitting, still has a single packet queued, >>>>>>> gets >>>>>>> moved to the end of the rbtree (and stays there for a while). >>>>>>> >>>>>>> 2. When we finally get to the point where this station gets >>>>>>> another >>>>>>> chance to transmit, the CoDel drop timer triggers and the last >>>>>>> packet >>>>>>> is dropped[0]. This means that the queue will just be empty >>>>>>> (and ieee80211_tx_dequeue() will return NULL). >>>>>>> >>>>>>> 3. Because the queue is empty, ieee80211_return_txq() will not >>>>>>> put >>>>>>> it >>>>>>> back on the rbtree. >>>>>>> >>>>>>> Crucially, in 2. the CoDel algorithm doesn't kick in until the >>>>>>> point >>>>>>> of >>>>>>> packet dequeue. But even if an empty queue stays on the rbtree >>>>>>> for >>>>>>> a >>>>>>> while, there is no harm in that: eventually it will get its turn, >>>>>>> it >>>>>>> will turn out to be empty, and just be skipped over. >>>>>> Then that will be fine. Thanks for the explanation of the dropping >>>>>> part >>>>>> in CoDel algorithm. >>>>> >>>>> Yup, think so. And you're welcome :) >>>>> >>>>>>> The issue we need to be concerned about is the opposite: If we >>>>>>> have >>>>>>> a >>>>>>> queue that *does* have packets queued, but which is *not* >>>>>>> scheduled >>>>>>> for >>>>>>> transmission, that will stall TX. >>>>>> Is it by design since its vt is more than global vt, right? The >>>>>> lattency >>>>>> may somehow get impacted though. >>>>> >>>>> Well, it should still stay on the rbtree as long as it has packets >>>>> queued. We don't have a check anywhere that reschedules TXQs whose >>>>> v_t >>>>> drops below global v_t... >>>>> >>>>>>> [0] CoDel in most cases only drops a single packet at a time, so >>>>>>> it >>>>>>> will >>>>>>> not clear out an entire queue with multiple packets in one go. >>>>>>> But >>>>>>> you >>>>>>> are right that it could conceivably drop the last packet in a >>>>>>> queue. >>>>>>> >>>>>>>>> We only need to defer removal inside a single "scheduling >>>>>>>>> round" >>>>>>>>> (i.e., >>>>>>>>> between a pair of ieee80211_txq_schedule_start/end. So if we >>>>>>>>> just >>>>>>>>> walk >>>>>>>>> the remove list in schedule_end() we should be enough, no? >>>>>>>>> >>>>>>>>> Hmm, or maybe a simpler way to fix the original issue is just >>>>>>>>> to >>>>>>>>> have >>>>>>>>> unschedule_txq() update the schedule_pos() pointer? >>>>>>>>> >>>>>>>>> I.e., unschedule_txq checks if the txq being removed is >>>>>>>>> currently >>>>>>>>> being >>>>>>>>> pointed to by schedule_pos[ac], and if it is, it updates >>>>>>>>> schedule_pos >>>>>>>>> to >>>>>>>>> be the rb_next of the current value? >>>>>>>> Actually, if schedule_pos is updated to rb_next of the current >>>>>>>> value, >>>>>>>> then in the next_txq() where we are going to use rb_next again >>>>>>>> and >>>>>>>> finally pick the next node of the node we really want. Is it >>>>>>>> fine >>>>>>>> to >>>>>>>> update schedule_pos to NULL? >>>>>>> >>>>>>> Hmm, yeah, good point. >>>>>>> >>>>>>> If we do end up setting schedule_pos to NULL in the middle of a >>>>>>> scheduling round, that will make next_txq() "start over", and do >>>>>>> another >>>>>>> loop through the whole thing. I guess we may be able hit a case >>>>>>> where >>>>>>> things can oscillate back and forth between addition and removal >>>>>>> resulting in an infinite loop? Not sure, but at least I can't >>>>>>> seem >>>>>>> to >>>>>>> convince myself that this can't happen. >>>>>> >>>>>> As the loop of next_txq under lock protection as below, >>>>>> >>>>>> txq_schedule_start(); >>>>>> while(txq=next_txq()){ >>>>>> ... >>>>>> return_txq(txq); >>>>>> } >>>>>> txq_schedule_end(); >>>>>> >>>>>> I do not see any chance of addition, no? >>>>> >>>>> As you noted in your other email, Felix reduced the locking. And >>>>> yeah, >>>>> we need to rebase this series to also incorporate that. I figure I >>>>> can >>>>> send an updated version of the first patch in the series once we've >>>>> worked out the remaining issues with your follow-up patches. >>>>> >>>> Oh, I was thinking we were discussing without locking reduced. Yes, >>>> I >>>> also agree there might be a case causing infinite loop. With locking >>>> reduced, the tree can be adjusted between next_txq() and >>>> return_txq() >>>> in >>>> the loop situation. For further discussion, let 's consider, >>>> 1) the tree starts like: >>>> A->B->C->D->E >>>> 2) then next_txq() returns A for dequeuing >>>> 3) driver dequeues A and draines A without any active txq locked >>>> meaning >>>> the tree could be changed upon Tx compeletion. >>>> 4) then in return_txq(), the tree could be, >>>> i A->B->C->D->E （A is empty, and maybe soon be added back >>>> before the loop end） >>>> ii B->C->A->D->E （A is empty, and maybe soon be added back >>>> before the loop end） >>>> iii B->C->D->E->A （A is empty, and maybe soon be added back >>>> before the loop end) >>>> >>>> with this change: >>>> local->schedule_pos[ac] = rb_next(node) ?: rb_prev(node); >>>> >>>> for case i, local->schedule_pos[ac] is rb_next(A) which is B, and in >>>> next_txq(), rb_next(B) is what we returns which actually is C and B >>>> is >>>> skipped, no? >>>> >>>> Similiar for case ii, we skip B, C, D. >>> >>> Yup, I think you're right. But if we can fix this by making >>> ieee80211_resort_txq() aware of the schedule_pos as well, no? I.e., >>> if >>> resort_txq() acts on the txq that's currently in schedule_pos, it >>> will >>> update schedule pos with the same rb_next(node) ?: rb_prev(node); >>> (optionally after checking that the position of the node is actually >>> going to change). >> Sorry, please igore last email sent by mistake. >> >> I don't think it makes any difference with that in unschedule_txq(). >> For >> case i, it finally picks C as well in next_txq(). For next_txq(), >> schedule_pos means previous candidate node whereas with your change, >> it >> looks like schedule_pos is current candidate node instead. > > Hmm, that was not actually what I was thinking, but yeah I think you're > right that it would be easier to just change it so schedule_pos is > pointing to the next and not the current txq we want to schedule. So do you mean we can change next_txq like this, struct ieee80211_txq *ieee80211_next_txq(struct ieee80211_hw *hw, u8 ac) { struct ieee80211_local *local = hw_to_local(hw); struct rb_node *node = local->schedule_pos[ac]; struct txq_info *txqi = NULL; bool first = false; lockdep_assert_held(&local->active_txq_lock[ac]); if (!node) { node = rb_first_cached(&local->active_txqs[ac]); first = true; - } else - node = rb_next(node); + } + if (!node) return NULL; > > We'd still need a check in resort_txq() then, but it would make it safe > to unschedule in return_txq()... Yes, agree with that. > >>>> Also I am wondering if there will be some SMP issues relating with >>>> local->schedule_pos[ac]. >>> >>> Not sure what you mean by this? >> My bad. Please ignore this. >> >> >>> >>>>>> In ath10k, we will usually push packets of first txq as many as we >>>>>> can >>>>>> until it is drained and then move to the next one. So if a txq >>>>>> gets >>>>>> removed in the return_txq, it should always be the leftmost. And >>>>>> during this period, neither vt of any station or global vt can be >>>>>> updated due to lock protection. >>>>>> >>>>>>> >>>>>>> But in that case, we could fix it by just conditionally assigning >>>>>>> either >>>>>>> rb_next or rb_prev to the schedule_pos in unschedule_txq()? I.e., >>>>>>> something like: >>>>>>> >>>>>>> local->schedule_pos[ac] = rb_next(node) ?: rb_prev(node); >>>>>> I am not sure I am getting your point. Still in next_txq, >>>>>> schedule_pos[ac] will lead us to the next node of the one we want. >>>>> >>>>> The logic in next_txq is different when schedule_pos[ac] is NULL, >>>>> vs >>>>> when rb_next(schedule_pos[ac]) is NULL. The former restarts a new >>>>> scheduling round, while the latter ends the current round. >>>>> >>>>> -Toke >>>> >>>> -- >>>> Yibo >> >> -- >> Yibo -- Yibo