From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine Date: Thu, 8 Nov 2018 15:00:01 -0800 Message-ID: <911ca9fa-e994-d3f3-2e8d-6f16631c1757@gmail.com> References: <922c223b-7bc0-e0ec-345d-2034b796af91@gmail.com> <20181108.145846.295661679780466934.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, netdev@vger.kernel.org To: David Miller , hkallweit1@gmail.com Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:41449 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbeKIIh6 (ORCPT ); Fri, 9 Nov 2018 03:37:58 -0500 Received: by mail-pg1-f196.google.com with SMTP id 70so3919980pgh.8 for ; Thu, 08 Nov 2018 15:00:11 -0800 (PST) In-Reply-To: <20181108.145846.295661679780466934.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/8/18 2:58 PM, David Miller wrote: > From: Heiner Kallweit > Date: Wed, 7 Nov 2018 20:41:52 +0100 > >> This patch series is based on two axioms: >> >> - During autoneg a PHY always reports the link being down >> >> - Info in clause 22/45 registers doesn't allow to differentiate between >> these two states: >> 1. Link is physically down >> 2. A link partner is connected and PHY is autonegotiating >> In both cases "link up" and "aneg finished" bits aren't set. >> One consequence is that having separate states PHY_NOLINK and PHY_AN >> isn't needed. >> >> By using these two axioms the state machine can be significantly >> simplified. > > So how are we going to move forward on this? > > Maybe we can apply this series and just watch carefully for any > problems that get reported or are found? Given Heiner is always responsive and taking care of fixing what might be/have broken, no objections with me on that. -- Florian