From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, stable@dpdk.org, talshn@mellanox.com,
fady@mellanox.com, tbashar@mellanox.com,
harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
pallavi.kadam@intel.com, ranjit.menon@intel.com,
cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] meter: remove inline functions from export list
Date: Tue, 23 Jun 2020 19:36:18 +0200 [thread overview]
Message-ID: <9144704.TjrKS6luVr@thomas> (raw)
In-Reply-To: <20200617082431.23156-1-fady@mellanox.com>
17/06/2020 10:24, Fady Bader:
> The code didn't compile when using exported meter functions under windows.
>
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_blind_check
>
> The cause was that there were some inline functions that were included in
> the export list.
> To solve this the functions were removed from rte_meter_version.map export
> list which are implemented in the header and shouldn't be exported.
>
> Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
> Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
Applied, thanks
prev parent reply other threads:[~2020-06-23 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:15 [dpdk-dev] [PATCH] meter: remove inline functions from export list Fady Bader
2020-06-17 8:24 ` [dpdk-dev] [PATCH v2] " Fady Bader
2020-06-23 17:36 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9144704.TjrKS6luVr@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.