From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/uaccess: Check CONFIG_PPC_E500
Date: Wed, 24 Jun 2026 10:41:02 +0200 [thread overview]
Message-ID: <9145eec2-9124-4c3b-911d-c005b29d2deb@kernel.org> (raw)
In-Reply-To: <20260624081523.88025-1-pengpeng@iscas.ac.cn>
Hi,
Le 24/06/2026 à 10:15, Pengpeng Hou a écrit :
> The powerpc CPU Kconfig defines `PPC_E500`. There is no generated
> `CONFIG_E500` symbol for `IS_ENABLED()` to test here.
>
> `mask_user_address()` therefore checks an impossible symbol before
> choosing the E500-specific masking helper. Use `CONFIG_PPC_E500`, which
> matches the actual Kconfig provider for this CPU family.
There is already a fix in the queue waiting to be applied:
https://lore.kernel.org/all/20260615233729.29386-1-enelsonmoore@gmail.com/
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> arch/powerpc/include/asm/uaccess.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
> --- a/arch/powerpc/include/asm/uaccess.h
> +++ b/arch/powerpc/include/asm/uaccess.h
> @@ -537,7 +537,7 @@ static __always_inline unsigned long mask_user_address(const void __user *ptr)
>
> if (IS_ENABLED(CONFIG_PPC64))
> return mask_user_address_simple(ptr);
> - if (IS_ENABLED(CONFIG_E500))
> + if (IS_ENABLED(CONFIG_PPC_E500))
> return mask_user_address_isel(ptr);
> if (TASK_SIZE <= UL(SZ_2G) && border >= UL(SZ_2G))
> return mask_user_address_simple(ptr);
>
prev parent reply other threads:[~2026-06-24 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 8:15 [PATCH] powerpc/uaccess: Check CONFIG_PPC_E500 Pengpeng Hou
2026-06-24 8:41 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9145eec2-9124-4c3b-911d-c005b29d2deb@kernel.org \
--to=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.