From: David Howells <dhowells@redhat.com>
To: Rohith Surabattula <rohiths.msft@gmail.com>
Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
Paulo Alcantara <pc@cjr.nz>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] [CIFS]: Add clamp_length support
Date: Wed, 16 Feb 2022 21:25:59 +0000 [thread overview]
Message-ID: <914621.1645046759@warthog.procyon.org.uk> (raw)
In-Reply-To: <CACdtm0Z4crPr868DRGCYNd=euVXzm+T+rPHT4PdqK66TV7iioQ@mail.gmail.com>
Rohith Surabattula <rohiths.msft@gmail.com> wrote:
> + credits = kmalloc(sizeof(struct cifs_credits), GFP_KERNEL);
> ...
> + subreq->subreq_priv = credits;
Would it be better if I made it so that the netfs could specify the size of
the netfs_read_subrequest struct to be allocated, thereby allowing it to tag
extra data on the end?
David
next prev parent reply other threads:[~2022-02-16 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 5:53 [PATCH] [CIFS]: Add clamp_length support Rohith Surabattula
2022-02-16 21:25 ` David Howells [this message]
2022-02-28 14:23 ` Rohith Surabattula
2022-02-28 14:39 ` David Howells
2022-03-02 11:05 ` Rohith Surabattula
2022-03-02 15:16 ` David Howells
2022-03-02 15:26 ` Rohith Surabattula
2022-03-02 15:47 ` David Howells
2022-03-09 12:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=914621.1645046759@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=rohiths.msft@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.